From 7eb9a189f92768bd91e8e830e448bdcb136cb3e2 Mon Sep 17 00:00:00 2001 From: Austin Eng Date: Wed, 23 Jun 2021 00:42:39 +0000 Subject: [PATCH] Remove TODO for invalid bug This bug does not need any work done. The code is correct. Depth stencil store operations occur in the LATE_FRAGMENT_TESTS_BIT stage. See crbug.com/dawn/853 for more information. Fixes: dawn:853 Change-Id: Ib0b7a5af65d09d67d7500ad89dd88c32e13c6d91 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/55602 Reviewed-by: Corentin Wallez Reviewed-by: Jiawei Shao Auto-Submit: Austin Eng Commit-Queue: Jiawei Shao --- src/dawn_native/vulkan/TextureVk.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/dawn_native/vulkan/TextureVk.cpp b/src/dawn_native/vulkan/TextureVk.cpp index deac7a10b9..87783fcbf9 100644 --- a/src/dawn_native/vulkan/TextureVk.cpp +++ b/src/dawn_native/vulkan/TextureVk.cpp @@ -135,8 +135,6 @@ namespace dawn_native { namespace vulkan { if (format.HasDepthOrStencil()) { flags |= VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT | VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT; - // TODO(crbug.com/dawn/853): This is missing the stage where the depth and - // stencil values are written, but it isn't clear which one it is. } else { flags |= VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT; }