From 7f426898efe02309b4a0d4589a2f10394c2a62ff Mon Sep 17 00:00:00 2001 From: Austin Eng Date: Wed, 16 Oct 2019 18:59:04 +0000 Subject: [PATCH] Skip BufferUploadPerf 16MB SetSubData on all backends. This test is flaky on all backends. Bug: dawn:239, chromium:1014946 TBR=cwallez@chromium.org Change-Id: I77dd261420c78d4b7f21a9e54b835ee3466df97d Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12360 Reviewed-by: Austin Eng Commit-Queue: Austin Eng --- src/tests/perf_tests/BufferUploadPerf.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/tests/perf_tests/BufferUploadPerf.cpp b/src/tests/perf_tests/BufferUploadPerf.cpp index fcc85a5169..f0161c509c 100644 --- a/src/tests/perf_tests/BufferUploadPerf.cpp +++ b/src/tests/perf_tests/BufferUploadPerf.cpp @@ -147,11 +147,8 @@ void BufferUploadPerf::Step() { } TEST_P(BufferUploadPerf, Run) { - // TODO(crbug.com/dawn/239): Investigate why large buffer uploads via SetSubData fail on some - // configurations. - DAWN_SKIP_TEST_IF(IsMetal() && GetParam().uploadMethod == UploadMethod::SetSubData && - GetParam().uploadSize == UploadSize::BufferSize_16MB); - DAWN_SKIP_TEST_IF(IsVulkan() && GetParam().uploadMethod == UploadMethod::SetSubData && + // TODO(crbug.com/dawn/239): Investigate why large buffer uploads via SetSubData fail. + DAWN_SKIP_TEST_IF(GetParam().uploadMethod == UploadMethod::SetSubData && GetParam().uploadSize == UploadSize::BufferSize_16MB); RunTest();