From 864a3647420511313a4f3f91d6591ed56706ee5d Mon Sep 17 00:00:00 2001 From: Hao Li Date: Wed, 31 Mar 2021 01:22:02 +0000 Subject: [PATCH] Suppress OcclusionQueryTests.QueryWithScissorTest on Intel This case is failed weirdly on Intel TGL (Window Vulkan) which says the destination buffer keep sentinel value in the second case, it cannot be reproduced with any debug actions including Vulkan validation layers enabled, and takes time to find out if the WriteBuffer and ResolveQuerySet are not executed in order or the ResolveQuerySet does not copy the results to the buffer. In order to integrate end2end tests to Intel driver CL without unknown issues, skip it until we find the root cause. Bug:dawn:434 Change-Id: Ibdba667cb662ba69c8468d5b2ac2e84bcd3df5bc Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46321 Reviewed-by: Jiawei Shao Reviewed-by: Corentin Wallez Reviewed-by: Austin Eng Commit-Queue: Hao Li --- src/tests/end2end/QueryTests.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/tests/end2end/QueryTests.cpp b/src/tests/end2end/QueryTests.cpp index e69ba92405..1f6f37aa39 100644 --- a/src/tests/end2end/QueryTests.cpp +++ b/src/tests/end2end/QueryTests.cpp @@ -242,6 +242,14 @@ TEST_P(OcclusionQueryTests, QueryWithDepthStencilTest) { // zero indicates that no sample passed scissor testing, // non-zero indicates that at least one sample passed scissor testing. TEST_P(OcclusionQueryTests, QueryWithScissorTest) { + // TODO(hao.x.li@intel.com): It's failed weirdly on Intel TGL（Window Vulkan) which says + // the destination buffer keep sentinel value in the second case, it cannot be reproduced with + // any debug actions including Vulkan validation layers enabled, and takes time to find out if + // the WriteBuffer and ResolveQuerySet are not executed in order or the ResolveQuerySet does not + // copy the result to the buffer. In order to integrate end2end tests to Intel driver CL without + // unknown issues, skip it until we find the root cause. + DAWN_SKIP_TEST_IF(IsWindows() && IsVulkan() && IsIntel()); + // Test there are samples passed scissor testing, the expected occlusion result is non-zero. TestOcclusionQueryWithScissorTest({2, 1, 2, 1}, OcclusionExpectation::Result::NonZero);