From 8b5d8049633adc3b72d2e4d16e553a0765916432 Mon Sep 17 00:00:00 2001 From: Corentin Wallez Date: Thu, 19 Jan 2023 16:05:27 +0000 Subject: [PATCH] Revert "DISABLE WireBufferMappingReadTests.DestroyInsideMapReadCallback" This reverts commit 1966ea9727de342342bea9a60667d6467f8f8b74. Reason for revert: dawn:1619 has been fixed. Original change's description: > DISABLE WireBufferMappingReadTests.DestroyInsideMapReadCallback > > It is failing under ASAN but should be fixed after at the same time as > issue dawn:1619 that makes mapping callbacks called only at the end of > the BufferBase method. > > Bug: dawn:1619, dawn:1621 > Change-Id: Idfdb6e36432a47eaef63b46e041f1404a2562f40 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116284 > Auto-Submit: Corentin Wallez > Reviewed-by: Austin Eng > Kokoro: Kokoro > Commit-Queue: Austin Eng # Not skipping CQ checks because original CL landed > 1 day ago. Bug: dawn:1619 Fixed: dawn:1621 Change-Id: Ib700147543c12b35005b718b50ed1b19245cf0ff Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/117440 Kokoro: Kokoro Reviewed-by: Austin Eng Commit-Queue: Corentin Wallez --- src/dawn/tests/unittests/wire/WireBufferMappingTests.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/dawn/tests/unittests/wire/WireBufferMappingTests.cpp b/src/dawn/tests/unittests/wire/WireBufferMappingTests.cpp index 119ceeb085..dd37ade4e3 100644 --- a/src/dawn/tests/unittests/wire/WireBufferMappingTests.cpp +++ b/src/dawn/tests/unittests/wire/WireBufferMappingTests.cpp @@ -335,9 +335,7 @@ TEST_F(WireBufferMappingReadTests, UnmapInsideMapReadCallback) { // Test that the MapReadCallback isn't fired twice the buffer external refcount reaches 0 in the // callback -// TODO(dawn:1621): Suppressed because the mapping handling still touches the buffer after it is -// destroyed triggering an ASAN error. -TEST_F(WireBufferMappingReadTests, DISABLED_DestroyInsideMapReadCallback) { +TEST_F(WireBufferMappingReadTests, DestroyInsideMapReadCallback) { wgpuBufferMapAsync(buffer, WGPUMapMode_Read, 0, kBufferSize, ToMockBufferMapCallback, nullptr); uint32_t bufferContent = 31337;