From 8c590acda0dcefcc7c916c59bf0102073d917bba Mon Sep 17 00:00:00 2001 From: Jiawei Shao Date: Tue, 2 Aug 2022 01:45:34 +0000 Subject: [PATCH] Remove the deprecated toggle DEPRECATED_DumpTranslatedShaders Bug: dawn:792 Change-Id: I2eee16490617c3371bfd65a69aca678aa4a6f3dc Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97780 Reviewed-by: Corentin Wallez Reviewed-by: Austin Eng Commit-Queue: Jiawei Shao --- src/dawn/native/Toggles.cpp | 9 --------- src/dawn/native/Toggles.h | 1 - 2 files changed, 10 deletions(-) diff --git a/src/dawn/native/Toggles.cpp b/src/dawn/native/Toggles.cpp index 55ac82ff49..5c90de2aa4 100644 --- a/src/dawn/native/Toggles.cpp +++ b/src/dawn/native/Toggles.cpp @@ -203,8 +203,6 @@ static constexpr ToggleEnumAndInfoList kToggleNameAndInfoList = {{ "Dump shaders for debugging purposes. Dumped shaders will be log via EmitLog, thus printed " "in Chrome console or consumed by user-defined callback function.", "https://crbug.com/dawn/792"}}, - {Toggle::DEPRECATED_DumpTranslatedShaders, - {"dump_translated_shaders", "Deprecated. Use dump_shaders", "https://crbug.com/dawn/792"}}, {Toggle::ForceWGSLStep, {"force_wgsl_step", "When ingesting SPIR-V shaders, force a first conversion to WGSL. This allows testing Tint's " @@ -297,19 +295,12 @@ static constexpr ToggleEnumAndInfoList kToggleNameAndInfoList = {{ } // anonymous namespace void TogglesSet::Set(Toggle toggle, bool enabled) { - if (toggle == Toggle::DEPRECATED_DumpTranslatedShaders) { - Set(Toggle::DumpShaders, enabled); - return; - } ASSERT(toggle != Toggle::InvalidEnum); const size_t toggleIndex = static_cast(toggle); toggleBitset.set(toggleIndex, enabled); } bool TogglesSet::Has(Toggle toggle) const { - if (toggle == Toggle::DEPRECATED_DumpTranslatedShaders) { - return Has(Toggle::DumpShaders); - } ASSERT(toggle != Toggle::InvalidEnum); const size_t toggleIndex = static_cast(toggle); return toggleBitset.test(toggleIndex); diff --git a/src/dawn/native/Toggles.h b/src/dawn/native/Toggles.h index 32aa009076..ceb8bf7075 100644 --- a/src/dawn/native/Toggles.h +++ b/src/dawn/native/Toggles.h @@ -59,7 +59,6 @@ enum class Toggle { EmitHLSLDebugSymbols, DisallowSpirv, DumpShaders, - DEPRECATED_DumpTranslatedShaders, // Use DumpShaders ForceWGSLStep, DisableWorkgroupInit, DisableSymbolRenaming,