From 8d000e0cc230663dbeae86f59aaa16fc91b1eac1 Mon Sep 17 00:00:00 2001 From: Corentin Wallez Date: Thu, 17 Oct 2019 15:51:38 +0000 Subject: [PATCH] Remove unneeded GN config removal after generated file cleanup We now have a build step that ensures only the allowed generated file directories are present so we don't need to remove the default includes config anymore. BUG=dawn:22 Change-Id: Id835d1bbb1f52a46ea6502f33b419e70207bba10 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12420 Commit-Queue: Stephen White Reviewed-by: Austin Eng Reviewed-by: Stephen White --- scripts/dawn_component.gni | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/scripts/dawn_component.gni b/scripts/dawn_component.gni index d2af95a6f5..3e854dae61 100644 --- a/scripts/dawn_component.gni +++ b/scripts/dawn_component.gni @@ -95,13 +95,6 @@ template("dawn_component") { defines = [] } defines += [ "${invoker.DEFINE_PREFIX}_IMPLEMENTATION" ] - - # TODO(cwallez@chromium.org): Remove this when we are sure the bots have - # been clobbered. This is necessary because when moving generated files - # around we ended up with bad generated files in cached build - # directories that get picked up because of the default inclusion of - # target_gen_dir as an include directory. - configs -= [ "//build/config/compiler:default_include_dirs" ] } static_library("${libname}_static") { @@ -114,13 +107,6 @@ template("dawn_component") { if (defined(invoker.configs)) { configs += invoker.configs } - - # TODO(cwallez@chromium.org): Remove this when we are sure the bots have - # been clobbered. This is necessary because when moving generated files - # around we ended up with bad generated files in cached build - # directories that get picked up because of the default inclusion of - # target_gen_dir as an include directory. - configs -= [ "//build/config/compiler:default_include_dirs" ] } group(libname) {