From 8fa07c6470815161618ec88ba901990979e35365 Mon Sep 17 00:00:00 2001 From: Stephen White Date: Fri, 27 May 2022 22:32:06 +0000 Subject: [PATCH] ANGLE/D3D11: reenable now-passing bind groups tests. Reenable the following tests: BindGroupTests.DrawTwiceInSamePipelineWithFourBindGroupSets and BindGroupTests.ArbitraryBindingNumbers Fixed by https://chromium-review.googlesource.com/c/angle/angle/+/3668840. Bug: angleproject:7304, angleproject:7305 Change-Id: I9482ddfb26246fa4ed123654645cbcedc266294a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/91723 Reviewed-by: Austin Eng Commit-Queue: Stephen White Kokoro: Kokoro --- src/dawn/tests/end2end/BindGroupTests.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/dawn/tests/end2end/BindGroupTests.cpp b/src/dawn/tests/end2end/BindGroupTests.cpp index 7704efd6e2..40663bebe8 100644 --- a/src/dawn/tests/end2end/BindGroupTests.cpp +++ b/src/dawn/tests/end2end/BindGroupTests.cpp @@ -553,9 +553,6 @@ TEST_P(BindGroupTests, MultipleEntryPointsWithMultipleNonZeroGroups) { // This test reproduces an out-of-bound bug on D3D12 backends when calling draw command twice with // one pipeline that has 4 bind group sets in one render pass. TEST_P(BindGroupTests, DrawTwiceInSamePipelineWithFourBindGroupSets) { - // TODO(anglebug.com/7304): fix failure in ANGLE/D3D11 - DAWN_SUPPRESS_TEST_IF(IsANGLE() && IsWindows()); - utils::BasicRenderPass renderPass = utils::CreateBasicRenderPass(device, kRTSize, kRTSize); wgpu::BindGroupLayout layout = utils::MakeBindGroupLayout( @@ -1236,9 +1233,6 @@ TEST_P(BindGroupTests, DynamicBindingNoneVisibility) { // Test that bind group bindings may have unbounded and arbitrary binding numbers TEST_P(BindGroupTests, ArbitraryBindingNumbers) { - // TODO(anglebug.com/7305): fix failure in ANGLE/D3D11 - DAWN_SUPPRESS_TEST_IF(IsANGLE() && IsWindows()); - // TODO(crbug.com/dawn/736): Test output is wrong with D3D12 + WARP. DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsWARP());