From 93fc1138378037ccc383c17dfd91ada5fbd7e533 Mon Sep 17 00:00:00 2001 From: Ben Clayton Date: Tue, 23 Nov 2021 20:31:37 +0000 Subject: [PATCH] reader/spirv: Remove test that only tests SPIR-V val The error message has recently changed, and is causing rolls to fail. I don't see any reason why we're testing SPIR-V val here. Just remove the test. Bug: tint:912 Change-Id: Ia24f81a8cc86edafe893493279f7aaa73f1d746a Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/70666 Kokoro: Kokoro Reviewed-by: David Neto Commit-Queue: Ben Clayton --- .../spirv/parser_impl_module_var_test.cc | 44 ------------------- 1 file changed, 44 deletions(-) diff --git a/src/reader/spirv/parser_impl_module_var_test.cc b/src/reader/spirv/parser_impl_module_var_test.cc index 9d12fcd0bd..9347c770df 100644 --- a/src/reader/spirv/parser_impl_module_var_test.cc +++ b/src/reader/spirv/parser_impl_module_var_test.cc @@ -4698,50 +4698,6 @@ fn main([[location(9)]] x_1_param : f32, [[location(11)]] x_1_param_1 : vec4Parse()) << p->error() << assembly; - EXPECT_THAT(p->error(), - HasSubstr("Location decoration can only be applied to a variable " - "or member of a structure type")); -} - TEST_F(SpvModuleScopeVarParserTest, EntryPointWrapping_Interpolation_Flat_Vertex_In) { // Flat decorations are dropped for integral