diff --git a/src/tint/ast/accessor_expression.cc b/src/tint/ast/accessor_expression.cc index 55cdabf103..6d0a751af3 100644 --- a/src/tint/ast/accessor_expression.cc +++ b/src/tint/ast/accessor_expression.cc @@ -29,8 +29,6 @@ AccessorExpression::AccessorExpression(ProgramID pid, TINT_ASSERT_PROGRAM_IDS_EQUAL_IF_VALID(AST, object, program_id); } -AccessorExpression::AccessorExpression(AccessorExpression&&) = default; - AccessorExpression::~AccessorExpression() = default; } // namespace tint::ast diff --git a/src/tint/ast/accessor_expression.h b/src/tint/ast/accessor_expression.h index 653eccb042..d668f1f2a5 100644 --- a/src/tint/ast/accessor_expression.h +++ b/src/tint/ast/accessor_expression.h @@ -28,8 +28,8 @@ class AccessorExpression : public Castable { /// @param source the member accessor expression source /// @param object the object AccessorExpression(ProgramID pid, NodeID nid, const Source& source, const Expression* object); - /// Move constructor - AccessorExpression(AccessorExpression&&); + + /// Destructor ~AccessorExpression() override; /// The object being accessed diff --git a/src/tint/ast/alias.cc b/src/tint/ast/alias.cc index ec5cf43156..c8787930a4 100644 --- a/src/tint/ast/alias.cc +++ b/src/tint/ast/alias.cc @@ -25,8 +25,6 @@ Alias::Alias(ProgramID pid, NodeID nid, const Source& src, const Identifier* n, TINT_ASSERT(AST, type); } -Alias::Alias(Alias&&) = default; - Alias::~Alias() = default; const Alias* Alias::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/alias.h b/src/tint/ast/alias.h index 267a313c33..c30d38747b 100644 --- a/src/tint/ast/alias.h +++ b/src/tint/ast/alias.h @@ -32,8 +32,7 @@ class Alias final : public Castable { /// @param name the symbol for the alias /// @param subtype the alias'd type Alias(ProgramID pid, NodeID nid, const Source& src, const Identifier* name, Type subtype); - /// Move constructor - Alias(Alias&&); + /// Destructor ~Alias() override; diff --git a/src/tint/ast/assignment_statement.cc b/src/tint/ast/assignment_statement.cc index 6a835b88ec..0441665510 100644 --- a/src/tint/ast/assignment_statement.cc +++ b/src/tint/ast/assignment_statement.cc @@ -32,8 +32,6 @@ AssignmentStatement::AssignmentStatement(ProgramID pid, TINT_ASSERT_PROGRAM_IDS_EQUAL_IF_VALID(AST, rhs, program_id); } -AssignmentStatement::AssignmentStatement(AssignmentStatement&&) = default; - AssignmentStatement::~AssignmentStatement() = default; const AssignmentStatement* AssignmentStatement::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/assignment_statement.h b/src/tint/ast/assignment_statement.h index 6b8c412f47..01a1a752c8 100644 --- a/src/tint/ast/assignment_statement.h +++ b/src/tint/ast/assignment_statement.h @@ -34,8 +34,8 @@ class AssignmentStatement final : public Castable { const Source& source, Type type, const Expression* expr); - /// Move constructor - BitcastExpression(BitcastExpression&&); + + /// Destructor ~BitcastExpression() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/block_statement.cc b/src/tint/ast/block_statement.cc index 5d75d27de2..7c7631981f 100644 --- a/src/tint/ast/block_statement.cc +++ b/src/tint/ast/block_statement.cc @@ -36,8 +36,6 @@ BlockStatement::BlockStatement(ProgramID pid, } } -BlockStatement::BlockStatement(BlockStatement&&) = default; - BlockStatement::~BlockStatement() = default; const BlockStatement* BlockStatement::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/block_statement.h b/src/tint/ast/block_statement.h index 87989d8394..2044b5b16d 100644 --- a/src/tint/ast/block_statement.h +++ b/src/tint/ast/block_statement.h @@ -40,8 +40,8 @@ class BlockStatement final : public Castable { const Source& source, utils::VectorRef statements, utils::VectorRef attributes); - /// Move constructor - BlockStatement(BlockStatement&&); + + /// Destructor ~BlockStatement() override; /// @returns true if the block has no statements diff --git a/src/tint/ast/break_if_statement.cc b/src/tint/ast/break_if_statement.cc index a931541253..dad7beb5ba 100644 --- a/src/tint/ast/break_if_statement.cc +++ b/src/tint/ast/break_if_statement.cc @@ -29,8 +29,6 @@ BreakIfStatement::BreakIfStatement(ProgramID pid, TINT_ASSERT_PROGRAM_IDS_EQUAL_IF_VALID(AST, condition, program_id); } -BreakIfStatement::BreakIfStatement(BreakIfStatement&&) = default; - BreakIfStatement::~BreakIfStatement() = default; const BreakIfStatement* BreakIfStatement::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/break_if_statement.h b/src/tint/ast/break_if_statement.h index 1437797bde..a366240368 100644 --- a/src/tint/ast/break_if_statement.h +++ b/src/tint/ast/break_if_statement.h @@ -32,8 +32,7 @@ class BreakIfStatement final : public Castable { /// @param condition the if condition BreakIfStatement(ProgramID pid, NodeID nid, const Source& src, const Expression* condition); - /// Move constructor - BreakIfStatement(BreakIfStatement&&); + /// Destructor ~BreakIfStatement() override; /// Clones this node and all transitive child nodes using the `CloneContext` `ctx`. diff --git a/src/tint/ast/break_statement.cc b/src/tint/ast/break_statement.cc index ecd5f06e69..e898d8c860 100644 --- a/src/tint/ast/break_statement.cc +++ b/src/tint/ast/break_statement.cc @@ -23,8 +23,6 @@ namespace tint::ast { BreakStatement::BreakStatement(ProgramID pid, NodeID nid, const Source& src) : Base(pid, nid, src) {} -BreakStatement::BreakStatement(BreakStatement&&) = default; - BreakStatement::~BreakStatement() = default; const BreakStatement* BreakStatement::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/break_statement.h b/src/tint/ast/break_statement.h index 92f67b7c63..d9676bbd4d 100644 --- a/src/tint/ast/break_statement.h +++ b/src/tint/ast/break_statement.h @@ -27,8 +27,8 @@ class BreakStatement final : public Castable { /// @param nid the unique node identifier /// @param src the source of this node BreakStatement(ProgramID pid, NodeID nid, const Source& src); - /// Move constructor - BreakStatement(BreakStatement&&); + + /// Destructor ~BreakStatement() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/builtin_texture_helper_test.h b/src/tint/ast/builtin_texture_helper_test.h index 738db0ccb3..2f941bb09c 100644 --- a/src/tint/ast/builtin_texture_helper_test.h +++ b/src/tint/ast/builtin_texture_helper_test.h @@ -219,6 +219,7 @@ struct TextureOverloadCase { bool /* returns_value */); /// Copy constructor TextureOverloadCase(const TextureOverloadCase&); + /// Destructor ~TextureOverloadCase(); diff --git a/src/tint/ast/call_expression.cc b/src/tint/ast/call_expression.cc index 9da71066f6..2e49c5faec 100644 --- a/src/tint/ast/call_expression.cc +++ b/src/tint/ast/call_expression.cc @@ -36,8 +36,6 @@ CallExpression::CallExpression(ProgramID pid, } } -CallExpression::CallExpression(CallExpression&&) = default; - CallExpression::~CallExpression() = default; const CallExpression* CallExpression::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/call_expression.h b/src/tint/ast/call_expression.h index 5085818ba8..66604945f9 100644 --- a/src/tint/ast/call_expression.h +++ b/src/tint/ast/call_expression.h @@ -43,8 +43,7 @@ class CallExpression final : public Castable { const IdentifierExpression* target, utils::VectorRef args); - /// Move constructor - CallExpression(CallExpression&&); + /// Destructor ~CallExpression() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/call_statement.cc b/src/tint/ast/call_statement.cc index 597e30fe3a..89772dcecd 100644 --- a/src/tint/ast/call_statement.cc +++ b/src/tint/ast/call_statement.cc @@ -29,8 +29,6 @@ CallStatement::CallStatement(ProgramID pid, TINT_ASSERT_PROGRAM_IDS_EQUAL_IF_VALID(AST, expr, program_id); } -CallStatement::CallStatement(CallStatement&&) = default; - CallStatement::~CallStatement() = default; const CallStatement* CallStatement::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/call_statement.h b/src/tint/ast/call_statement.h index daf0b3f1af..9af47a183b 100644 --- a/src/tint/ast/call_statement.h +++ b/src/tint/ast/call_statement.h @@ -29,8 +29,8 @@ class CallStatement final : public Castable { /// @param src the source of this node for the statement /// @param call the function CallStatement(ProgramID pid, NodeID nid, const Source& src, const CallExpression* call); - /// Move constructor - CallStatement(CallStatement&&); + + /// Destructor ~CallStatement() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/case_selector.cc b/src/tint/ast/case_selector.cc index 7419fe524d..a7f14461d0 100644 --- a/src/tint/ast/case_selector.cc +++ b/src/tint/ast/case_selector.cc @@ -25,8 +25,6 @@ namespace tint::ast { CaseSelector::CaseSelector(ProgramID pid, NodeID nid, const Source& src, const Expression* e) : Base(pid, nid, src), expr(e) {} -CaseSelector::CaseSelector(CaseSelector&&) = default; - CaseSelector::~CaseSelector() = default; const CaseSelector* CaseSelector::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/case_selector.h b/src/tint/ast/case_selector.h index b4c3ca7f57..f2bc1b341c 100644 --- a/src/tint/ast/case_selector.h +++ b/src/tint/ast/case_selector.h @@ -31,8 +31,8 @@ class CaseSelector final : public Castable { /// @param src the source of this node /// @param expr the selector expression, |nullptr| for a `default` selector CaseSelector(ProgramID pid, NodeID nid, const Source& src, const Expression* expr = nullptr); - /// Move constructor - CaseSelector(CaseSelector&&); + + /// Destructor ~CaseSelector() override; /// @returns true if this is a default statement diff --git a/src/tint/ast/case_statement.cc b/src/tint/ast/case_statement.cc index 7b2e798ecb..b7e6970687 100644 --- a/src/tint/ast/case_statement.cc +++ b/src/tint/ast/case_statement.cc @@ -37,8 +37,6 @@ CaseStatement::CaseStatement(ProgramID pid, } } -CaseStatement::CaseStatement(CaseStatement&&) = default; - CaseStatement::~CaseStatement() = default; bool CaseStatement::ContainsDefault() const { diff --git a/src/tint/ast/case_statement.h b/src/tint/ast/case_statement.h index acd502afcf..a06c720a7f 100644 --- a/src/tint/ast/case_statement.h +++ b/src/tint/ast/case_statement.h @@ -36,8 +36,8 @@ class CaseStatement final : public Castable { const Source& src, utils::VectorRef selectors, const BlockStatement* body); - /// Move constructor - CaseStatement(CaseStatement&&); + + /// Destructor ~CaseStatement() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/compound_assignment_statement.cc b/src/tint/ast/compound_assignment_statement.cc index f7528625f2..fc9d30073a 100644 --- a/src/tint/ast/compound_assignment_statement.cc +++ b/src/tint/ast/compound_assignment_statement.cc @@ -33,8 +33,6 @@ CompoundAssignmentStatement::CompoundAssignmentStatement(ProgramID pid, TINT_ASSERT_PROGRAM_IDS_EQUAL_IF_VALID(AST, rhs, program_id); } -CompoundAssignmentStatement::CompoundAssignmentStatement(CompoundAssignmentStatement&&) = default; - CompoundAssignmentStatement::~CompoundAssignmentStatement() = default; const CompoundAssignmentStatement* CompoundAssignmentStatement::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/compound_assignment_statement.h b/src/tint/ast/compound_assignment_statement.h index 9fbd22c2b3..bb1f34f88c 100644 --- a/src/tint/ast/compound_assignment_statement.h +++ b/src/tint/ast/compound_assignment_statement.h @@ -37,8 +37,8 @@ class CompoundAssignmentStatement final : public Castable { const Expression* initializer, utils::VectorRef attributes); - /// Move constructor - Const(Const&&); - /// Destructor ~Const() override; diff --git a/src/tint/ast/const_assert.cc b/src/tint/ast/const_assert.cc index 5f9978d08c..0dcdc1668c 100644 --- a/src/tint/ast/const_assert.cc +++ b/src/tint/ast/const_assert.cc @@ -26,8 +26,6 @@ ConstAssert::ConstAssert(ProgramID pid, NodeID nid, const Source& src, const Exp TINT_ASSERT_PROGRAM_IDS_EQUAL_IF_VALID(AST, cond, program_id); } -ConstAssert::ConstAssert(ConstAssert&&) = default; - ConstAssert::~ConstAssert() = default; const ConstAssert* ConstAssert::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/const_assert.h b/src/tint/ast/const_assert.h index 8f0aae5f11..6774f5e7d5 100644 --- a/src/tint/ast/const_assert.h +++ b/src/tint/ast/const_assert.h @@ -30,9 +30,6 @@ class ConstAssert final : public Castable { /// @param condition the assertion condition ConstAssert(ProgramID pid, NodeID nid, const Source& source, const Expression* condition); - /// Move constructor - ConstAssert(ConstAssert&&); - /// Destructor ~ConstAssert() override; diff --git a/src/tint/ast/continue_statement.cc b/src/tint/ast/continue_statement.cc index 53bd6a9a2f..a7868e825d 100644 --- a/src/tint/ast/continue_statement.cc +++ b/src/tint/ast/continue_statement.cc @@ -23,8 +23,6 @@ namespace tint::ast { ContinueStatement::ContinueStatement(ProgramID pid, NodeID nid, const Source& src) : Base(pid, nid, src) {} -ContinueStatement::ContinueStatement(ContinueStatement&&) = default; - ContinueStatement::~ContinueStatement() = default; const ContinueStatement* ContinueStatement::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/continue_statement.h b/src/tint/ast/continue_statement.h index 09b8254373..10af08b353 100644 --- a/src/tint/ast/continue_statement.h +++ b/src/tint/ast/continue_statement.h @@ -27,8 +27,8 @@ class ContinueStatement final : public Castable { /// @param nid the unique node identifier /// @param src the source of this node ContinueStatement(ProgramID pid, NodeID nid, const Source& src); - /// Move constructor - ContinueStatement(ContinueStatement&&); + + /// Destructor ~ContinueStatement() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/diagnostic_control.cc b/src/tint/ast/diagnostic_control.cc index e269446f8a..a2bdd46523 100644 --- a/src/tint/ast/diagnostic_control.cc +++ b/src/tint/ast/diagnostic_control.cc @@ -22,6 +22,8 @@ namespace tint::ast { +DiagnosticControl::DiagnosticControl() = default; + DiagnosticControl::DiagnosticControl(builtin::DiagnosticSeverity sev, const Identifier* rule) : severity(sev), rule_name(rule) { TINT_ASSERT(AST, rule != nullptr); @@ -31,4 +33,6 @@ DiagnosticControl::DiagnosticControl(builtin::DiagnosticSeverity sev, const Iden } } +DiagnosticControl::DiagnosticControl(DiagnosticControl&&) = default; + } // namespace tint::ast diff --git a/src/tint/ast/diagnostic_control.h b/src/tint/ast/diagnostic_control.h index a0f5a9d698..f99d002c4e 100644 --- a/src/tint/ast/diagnostic_control.h +++ b/src/tint/ast/diagnostic_control.h @@ -32,13 +32,16 @@ namespace tint::ast { struct DiagnosticControl { public: /// Default constructor. - DiagnosticControl() {} + DiagnosticControl(); /// Constructor /// @param sev the diagnostic severity /// @param rule the diagnostic rule name DiagnosticControl(builtin::DiagnosticSeverity sev, const Identifier* rule); + /// Move constructor + DiagnosticControl(DiagnosticControl&&); + /// The diagnostic severity control. builtin::DiagnosticSeverity severity; diff --git a/src/tint/ast/diagnostic_directive.cc b/src/tint/ast/diagnostic_directive.cc index 42e1169bb0..f0ef041f82 100644 --- a/src/tint/ast/diagnostic_directive.cc +++ b/src/tint/ast/diagnostic_directive.cc @@ -26,8 +26,6 @@ DiagnosticDirective::DiagnosticDirective(ProgramID pid, DiagnosticControl&& dc) : Base(pid, nid, src), control(std::move(dc)) {} -DiagnosticDirective::DiagnosticDirective(DiagnosticDirective&&) = default; - DiagnosticDirective::~DiagnosticDirective() = default; const DiagnosticDirective* DiagnosticDirective::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/diagnostic_directive.h b/src/tint/ast/diagnostic_directive.h index ee84381899..979f32c7fb 100644 --- a/src/tint/ast/diagnostic_directive.h +++ b/src/tint/ast/diagnostic_directive.h @@ -38,9 +38,6 @@ class DiagnosticDirective final : public Castable { /// @param dc the diagnostic control DiagnosticDirective(ProgramID pid, NodeID nid, const Source& src, DiagnosticControl&& dc); - /// Move constructor - DiagnosticDirective(DiagnosticDirective&&); - /// Destructor ~DiagnosticDirective() override; diff --git a/src/tint/ast/discard_statement.cc b/src/tint/ast/discard_statement.cc index fc9e75bbff..e76d01e591 100644 --- a/src/tint/ast/discard_statement.cc +++ b/src/tint/ast/discard_statement.cc @@ -23,8 +23,6 @@ namespace tint::ast { DiscardStatement::DiscardStatement(ProgramID pid, NodeID nid, const Source& src) : Base(pid, nid, src) {} -DiscardStatement::DiscardStatement(DiscardStatement&&) = default; - DiscardStatement::~DiscardStatement() = default; const DiscardStatement* DiscardStatement::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/discard_statement.h b/src/tint/ast/discard_statement.h index 272cc2dbf2..a7646835f9 100644 --- a/src/tint/ast/discard_statement.h +++ b/src/tint/ast/discard_statement.h @@ -27,8 +27,8 @@ class DiscardStatement final : public Castable { /// @param nid the unique node identifier /// @param src the source of this node DiscardStatement(ProgramID pid, NodeID nid, const Source& src); - /// Move constructor - DiscardStatement(DiscardStatement&&); + + /// Destructor ~DiscardStatement() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/enable.cc b/src/tint/ast/enable.cc index bb2b3b6248..b449444e03 100644 --- a/src/tint/ast/enable.cc +++ b/src/tint/ast/enable.cc @@ -26,8 +26,6 @@ Enable::Enable(ProgramID pid, utils::VectorRef exts) : Base(pid, nid, src), extensions(std::move(exts)) {} -Enable::Enable(Enable&&) = default; - Enable::~Enable() = default; bool Enable::HasExtension(builtin::Extension ext) const { diff --git a/src/tint/ast/enable.h b/src/tint/ast/enable.h index d87d12fd34..53f0218347 100644 --- a/src/tint/ast/enable.h +++ b/src/tint/ast/enable.h @@ -36,9 +36,8 @@ class Enable final : public Castable { /// @param src the source of this node /// @param exts the extensions being enabled by this directive Enable(ProgramID pid, NodeID nid, const Source& src, utils::VectorRef exts); - /// Move constructor - Enable(Enable&&); + /// Destructor ~Enable() override; /// @param ext the extension to search for diff --git a/src/tint/ast/expression.cc b/src/tint/ast/expression.cc index b9482fa18a..21989d0623 100644 --- a/src/tint/ast/expression.cc +++ b/src/tint/ast/expression.cc @@ -20,8 +20,6 @@ namespace tint::ast { Expression::Expression(ProgramID pid, NodeID nid, const Source& src) : Base(pid, nid, src) {} -Expression::Expression(Expression&&) = default; - Expression::~Expression() = default; } // namespace tint::ast diff --git a/src/tint/ast/expression.h b/src/tint/ast/expression.h index d851cb1c00..e4a94cb58f 100644 --- a/src/tint/ast/expression.h +++ b/src/tint/ast/expression.h @@ -33,8 +33,6 @@ class Expression : public Castable { /// @param nid the unique node identifier /// @param src the source of this node Expression(ProgramID pid, NodeID nid, const Source& src); - /// Move constructor - Expression(Expression&&); }; } // namespace tint::ast diff --git a/src/tint/ast/extension.cc b/src/tint/ast/extension.cc index a45c704156..bfb8ffd5cf 100644 --- a/src/tint/ast/extension.cc +++ b/src/tint/ast/extension.cc @@ -26,8 +26,6 @@ namespace tint::ast { Extension::Extension(ProgramID pid, NodeID nid, const Source& src, builtin::Extension ext) : Base(pid, nid, src), name(ext) {} -Extension::Extension(Extension&&) = default; - Extension::~Extension() = default; const Extension* Extension::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/extension.h b/src/tint/ast/extension.h index 93f3baa3f0..4988edbd4d 100644 --- a/src/tint/ast/extension.h +++ b/src/tint/ast/extension.h @@ -32,9 +32,8 @@ class Extension final : public Castable { /// @param src the source of this node /// @param ext the extension Extension(ProgramID pid, NodeID nid, const Source& src, builtin::Extension ext); - /// Move constructor - Extension(Extension&&); + /// Destructor ~Extension() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/for_loop_statement.cc b/src/tint/ast/for_loop_statement.cc index b2a547098b..faec8784d9 100644 --- a/src/tint/ast/for_loop_statement.cc +++ b/src/tint/ast/for_loop_statement.cc @@ -48,8 +48,6 @@ ForLoopStatement::ForLoopStatement(ProgramID pid, } } -ForLoopStatement::ForLoopStatement(ForLoopStatement&&) = default; - ForLoopStatement::~ForLoopStatement() = default; const ForLoopStatement* ForLoopStatement::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/for_loop_statement.h b/src/tint/ast/for_loop_statement.h index 6063dda3e0..00fcf1d19d 100644 --- a/src/tint/ast/for_loop_statement.h +++ b/src/tint/ast/for_loop_statement.h @@ -41,8 +41,8 @@ class ForLoopStatement final : public Castable { const Statement* continuing, const BlockStatement* body, utils::VectorRef attributes); - /// Move constructor - ForLoopStatement(ForLoopStatement&&); + + /// Destructor ~ForLoopStatement() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/function.cc b/src/tint/ast/function.cc index 3c5446c066..59a4571a87 100644 --- a/src/tint/ast/function.cc +++ b/src/tint/ast/function.cc @@ -57,8 +57,6 @@ Function::Function(ProgramID pid, } } -Function::Function(Function&&) = default; - Function::~Function() = default; PipelineStage Function::PipelineStage() const { diff --git a/src/tint/ast/function.h b/src/tint/ast/function.h index dc8cc70316..8fa009f2b0 100644 --- a/src/tint/ast/function.h +++ b/src/tint/ast/function.h @@ -59,9 +59,8 @@ class Function final : public Castable { const BlockStatement* body, utils::VectorRef attributes, utils::VectorRef return_type_attributes); - /// Move constructor - Function(Function&&); + /// Destructor ~Function() override; /// @returns the functions pipeline stage or None if not set diff --git a/src/tint/ast/identifier.cc b/src/tint/ast/identifier.cc index 8b8c3f51ca..49b9c86c09 100644 --- a/src/tint/ast/identifier.cc +++ b/src/tint/ast/identifier.cc @@ -26,8 +26,6 @@ Identifier::Identifier(ProgramID pid, NodeID nid, const Source& src, Symbol sym) TINT_ASSERT(AST, symbol.IsValid()); } -Identifier::Identifier(Identifier&&) = default; - Identifier::~Identifier() = default; const Identifier* Identifier::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/identifier.h b/src/tint/ast/identifier.h index 71601735b4..df138e9dbd 100644 --- a/src/tint/ast/identifier.h +++ b/src/tint/ast/identifier.h @@ -28,8 +28,8 @@ class Identifier : public Castable { /// @param src the source of this node /// @param sym the symbol for the identifier Identifier(ProgramID pid, NodeID nid, const Source& src, Symbol sym); - /// Move constructor - Identifier(Identifier&&); + + /// Destructor ~Identifier() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/identifier_expression.cc b/src/tint/ast/identifier_expression.cc index ca4e0cb99f..d3ee29b73a 100644 --- a/src/tint/ast/identifier_expression.cc +++ b/src/tint/ast/identifier_expression.cc @@ -29,8 +29,6 @@ IdentifierExpression::IdentifierExpression(ProgramID pid, TINT_ASSERT_PROGRAM_IDS_EQUAL(AST, identifier, program_id); } -IdentifierExpression::IdentifierExpression(IdentifierExpression&&) = default; - IdentifierExpression::~IdentifierExpression() = default; const IdentifierExpression* IdentifierExpression::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/identifier_expression.h b/src/tint/ast/identifier_expression.h index 475249c073..c2200bd1ae 100644 --- a/src/tint/ast/identifier_expression.h +++ b/src/tint/ast/identifier_expression.h @@ -36,8 +36,8 @@ class IdentifierExpression final : public Castable { const BlockStatement* body, const Statement* else_stmt, utils::VectorRef attributes); - /// Move constructor - IfStatement(IfStatement&&); + + /// Destructor ~IfStatement() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/increment_decrement_statement.cc b/src/tint/ast/increment_decrement_statement.cc index 5b10e5fb8c..f37242eefd 100644 --- a/src/tint/ast/increment_decrement_statement.cc +++ b/src/tint/ast/increment_decrement_statement.cc @@ -29,8 +29,6 @@ IncrementDecrementStatement::IncrementDecrementStatement(ProgramID pid, TINT_ASSERT_PROGRAM_IDS_EQUAL_IF_VALID(AST, lhs, program_id); } -IncrementDecrementStatement::IncrementDecrementStatement(IncrementDecrementStatement&&) = default; - IncrementDecrementStatement::~IncrementDecrementStatement() = default; const IncrementDecrementStatement* IncrementDecrementStatement::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/increment_decrement_statement.h b/src/tint/ast/increment_decrement_statement.h index ec9923ab69..9046e46f9d 100644 --- a/src/tint/ast/increment_decrement_statement.h +++ b/src/tint/ast/increment_decrement_statement.h @@ -34,8 +34,8 @@ class IncrementDecrementStatement final : public Castable { const Expression* initializer, utils::VectorRef attributes); - /// Move constructor - Let(Let&&); - /// Destructor ~Let() override; diff --git a/src/tint/ast/loop_statement.cc b/src/tint/ast/loop_statement.cc index b7e7a1bd71..731dee7b3d 100644 --- a/src/tint/ast/loop_statement.cc +++ b/src/tint/ast/loop_statement.cc @@ -31,8 +31,6 @@ LoopStatement::LoopStatement(ProgramID pid, TINT_ASSERT_PROGRAM_IDS_EQUAL_IF_VALID(AST, continuing, program_id); } -LoopStatement::LoopStatement(LoopStatement&&) = default; - LoopStatement::~LoopStatement() = default; const LoopStatement* LoopStatement::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/loop_statement.h b/src/tint/ast/loop_statement.h index d4b24cf7bc..c1e5cc0fdb 100644 --- a/src/tint/ast/loop_statement.h +++ b/src/tint/ast/loop_statement.h @@ -33,8 +33,8 @@ class LoopStatement final : public Castable { const Source& source, const BlockStatement* body, const BlockStatement* continuing); - /// Move constructor - LoopStatement(LoopStatement&&); + + /// Destructor ~LoopStatement() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/member_accessor_expression.cc b/src/tint/ast/member_accessor_expression.cc index 3886502c28..4b062fb2f3 100644 --- a/src/tint/ast/member_accessor_expression.cc +++ b/src/tint/ast/member_accessor_expression.cc @@ -35,8 +35,6 @@ MemberAccessorExpression::MemberAccessorExpression(ProgramID pid, } } -MemberAccessorExpression::MemberAccessorExpression(MemberAccessorExpression&&) = default; - MemberAccessorExpression::~MemberAccessorExpression() = default; const MemberAccessorExpression* MemberAccessorExpression::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/member_accessor_expression.h b/src/tint/ast/member_accessor_expression.h index 6833f93d84..95fbbd265a 100644 --- a/src/tint/ast/member_accessor_expression.h +++ b/src/tint/ast/member_accessor_expression.h @@ -35,8 +35,8 @@ class MemberAccessorExpression final const Source& source, const Expression* object, const Identifier* member); - /// Move constructor - MemberAccessorExpression(MemberAccessorExpression&&); + + /// Destructor ~MemberAccessorExpression() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/node.cc b/src/tint/ast/node.cc index ce3a71d1b9..772c7886b2 100644 --- a/src/tint/ast/node.cc +++ b/src/tint/ast/node.cc @@ -21,8 +21,6 @@ namespace tint::ast { Node::Node(ProgramID pid, NodeID nid, const Source& src) : program_id(pid), node_id(nid), source(src) {} -Node::Node(Node&&) = default; - Node::~Node() = default; } // namespace tint::ast diff --git a/src/tint/ast/node.h b/src/tint/ast/node.h index 6eaa1e94f0..afea2e8b1d 100644 --- a/src/tint/ast/node.h +++ b/src/tint/ast/node.h @@ -42,11 +42,10 @@ class Node : public Castable { /// @param nid the unique node identifier /// @param src the input source for the node Node(ProgramID pid, NodeID nid, const Source& src); - /// Move constructor - Node(Node&&); private: Node(const Node&) = delete; + Node(Node&&) = delete; }; } // namespace tint::ast diff --git a/src/tint/ast/override.cc b/src/tint/ast/override.cc index 79f0772098..ff1836efc7 100644 --- a/src/tint/ast/override.cc +++ b/src/tint/ast/override.cc @@ -31,8 +31,6 @@ Override::Override(ProgramID pid, utils::VectorRef attrs) : Base(pid, nid, src, n, ty, init, std::move(attrs)) {} -Override::Override(Override&&) = default; - Override::~Override() = default; const char* Override::Kind() const { diff --git a/src/tint/ast/override.h b/src/tint/ast/override.h index 531d147248..b824ed3834 100644 --- a/src/tint/ast/override.h +++ b/src/tint/ast/override.h @@ -48,9 +48,6 @@ class Override final : public Castable { const Expression* initializer, utils::VectorRef attributes); - /// Move constructor - Override(Override&&); - /// Destructor ~Override() override; diff --git a/src/tint/ast/parameter.cc b/src/tint/ast/parameter.cc index a2c6e5b474..4a76e5521c 100644 --- a/src/tint/ast/parameter.cc +++ b/src/tint/ast/parameter.cc @@ -30,8 +30,6 @@ Parameter::Parameter(ProgramID pid, utils::VectorRef attrs) : Base(pid, nid, src, n, ty, nullptr, std::move(attrs)) {} -Parameter::Parameter(Parameter&&) = default; - Parameter::~Parameter() = default; const char* Parameter::Kind() const { diff --git a/src/tint/ast/parameter.h b/src/tint/ast/parameter.h index 7ea49ae466..b056afa44c 100644 --- a/src/tint/ast/parameter.h +++ b/src/tint/ast/parameter.h @@ -47,9 +47,6 @@ class Parameter final : public Castable { Type type, utils::VectorRef attributes); - /// Move constructor - Parameter(Parameter&&); - /// Destructor ~Parameter() override; diff --git a/src/tint/ast/phony_expression.cc b/src/tint/ast/phony_expression.cc index 6bce1bf3a5..f2fca968f1 100644 --- a/src/tint/ast/phony_expression.cc +++ b/src/tint/ast/phony_expression.cc @@ -23,8 +23,6 @@ namespace tint::ast { PhonyExpression::PhonyExpression(ProgramID pid, NodeID nid, const Source& src) : Base(pid, nid, src) {} -PhonyExpression::PhonyExpression(PhonyExpression&&) = default; - PhonyExpression::~PhonyExpression() = default; const PhonyExpression* PhonyExpression::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/phony_expression.h b/src/tint/ast/phony_expression.h index d429a51db2..7f59c378e9 100644 --- a/src/tint/ast/phony_expression.h +++ b/src/tint/ast/phony_expression.h @@ -28,8 +28,8 @@ class PhonyExpression final : public Castable { /// @param nid the unique node identifier /// @param src the source of this node PhonyExpression(ProgramID pid, NodeID nid, const Source& src); - /// Move constructor - PhonyExpression(PhonyExpression&&); + + /// Destructor ~PhonyExpression() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/return_statement.cc b/src/tint/ast/return_statement.cc index 459bb721fc..4ac7313e80 100644 --- a/src/tint/ast/return_statement.cc +++ b/src/tint/ast/return_statement.cc @@ -31,8 +31,6 @@ ReturnStatement::ReturnStatement(ProgramID pid, TINT_ASSERT_PROGRAM_IDS_EQUAL_IF_VALID(AST, value, program_id); } -ReturnStatement::ReturnStatement(ReturnStatement&&) = default; - ReturnStatement::~ReturnStatement() = default; const ReturnStatement* ReturnStatement::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/return_statement.h b/src/tint/ast/return_statement.h index 571a738c67..7eae780916 100644 --- a/src/tint/ast/return_statement.h +++ b/src/tint/ast/return_statement.h @@ -35,8 +35,8 @@ class ReturnStatement final : public Castable { /// @param src the source of this node /// @param value the return value ReturnStatement(ProgramID pid, NodeID nid, const Source& src, const Expression* value); - /// Move constructor - ReturnStatement(ReturnStatement&&); + + /// Destructor ~ReturnStatement() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/statement.cc b/src/tint/ast/statement.cc index 7b9ca5deaf..42f01c4d84 100644 --- a/src/tint/ast/statement.cc +++ b/src/tint/ast/statement.cc @@ -31,8 +31,6 @@ namespace tint::ast { Statement::Statement(ProgramID pid, NodeID nid, const Source& src) : Base(pid, nid, src) {} -Statement::Statement(Statement&&) = default; - Statement::~Statement() = default; const char* Statement::Name() const { diff --git a/src/tint/ast/statement.h b/src/tint/ast/statement.h index 616e348120..fa434cc548 100644 --- a/src/tint/ast/statement.h +++ b/src/tint/ast/statement.h @@ -35,8 +35,6 @@ class Statement : public Castable { /// @param nid the unique node identifier /// @param src the source of the expression Statement(ProgramID pid, NodeID nid, const Source& src); - /// Move constructor - Statement(Statement&&); }; } // namespace tint::ast diff --git a/src/tint/ast/struct.cc b/src/tint/ast/struct.cc index 96daeff838..ebd33e2d08 100644 --- a/src/tint/ast/struct.cc +++ b/src/tint/ast/struct.cc @@ -39,8 +39,6 @@ Struct::Struct(ProgramID pid, } } -Struct::Struct(Struct&&) = default; - Struct::~Struct() = default; const Struct* Struct::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/struct.h b/src/tint/ast/struct.h index 36ad08095d..d7c2281f96 100644 --- a/src/tint/ast/struct.h +++ b/src/tint/ast/struct.h @@ -41,9 +41,8 @@ class Struct final : public Castable { const Identifier* name, utils::VectorRef members, utils::VectorRef attributes); - /// Move constructor - Struct(Struct&&); + /// Destructor ~Struct() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/struct_member.cc b/src/tint/ast/struct_member.cc index 10f278d99b..acc20e5bcd 100644 --- a/src/tint/ast/struct_member.cc +++ b/src/tint/ast/struct_member.cc @@ -39,8 +39,6 @@ StructMember::StructMember(ProgramID pid, } } -StructMember::StructMember(StructMember&&) = default; - StructMember::~StructMember() = default; const StructMember* StructMember::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/struct_member.h b/src/tint/ast/struct_member.h index fba504ac9f..27e5b0ca2a 100644 --- a/src/tint/ast/struct_member.h +++ b/src/tint/ast/struct_member.h @@ -43,9 +43,8 @@ class StructMember final : public Castable { const Identifier* name, Type type, utils::VectorRef attributes); - /// Move constructor - StructMember(StructMember&&); + /// Destructor ~StructMember() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/switch_statement.cc b/src/tint/ast/switch_statement.cc index 0445e48fc5..4e5d95d4de 100644 --- a/src/tint/ast/switch_statement.cc +++ b/src/tint/ast/switch_statement.cc @@ -41,8 +41,6 @@ SwitchStatement::SwitchStatement(ProgramID pid, } } -SwitchStatement::SwitchStatement(SwitchStatement&&) = default; - SwitchStatement::~SwitchStatement() = default; const SwitchStatement* SwitchStatement::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/switch_statement.h b/src/tint/ast/switch_statement.h index e91853535c..354b6ad4dc 100644 --- a/src/tint/ast/switch_statement.h +++ b/src/tint/ast/switch_statement.h @@ -36,8 +36,8 @@ class SwitchStatement final : public Castable { const Expression* condition, utils::VectorRef body, utils::VectorRef attributes); - /// Move constructor - SwitchStatement(SwitchStatement&&); + + /// Destructor ~SwitchStatement() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/templated_identifier.cc b/src/tint/ast/templated_identifier.cc index 3a8b545df2..98274b6249 100644 --- a/src/tint/ast/templated_identifier.cc +++ b/src/tint/ast/templated_identifier.cc @@ -38,8 +38,6 @@ TemplatedIdentifier::TemplatedIdentifier(ProgramID pid, } } -TemplatedIdentifier::TemplatedIdentifier(TemplatedIdentifier&&) = default; - TemplatedIdentifier::~TemplatedIdentifier() = default; const TemplatedIdentifier* TemplatedIdentifier::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/templated_identifier.h b/src/tint/ast/templated_identifier.h index 9f4b17bc29..74ddb43667 100644 --- a/src/tint/ast/templated_identifier.h +++ b/src/tint/ast/templated_identifier.h @@ -41,8 +41,8 @@ class TemplatedIdentifier final : public Castable args, utils::VectorRef attrs); - /// Move constructor - TemplatedIdentifier(TemplatedIdentifier&&); + + /// Destructor ~TemplatedIdentifier() override; /// Clones this node and all transitive child nodes using the `CloneContext` `ctx`. diff --git a/src/tint/ast/type_decl.cc b/src/tint/ast/type_decl.cc index 2319b198f6..206bf45c2a 100644 --- a/src/tint/ast/type_decl.cc +++ b/src/tint/ast/type_decl.cc @@ -28,8 +28,6 @@ TypeDecl::TypeDecl(ProgramID pid, NodeID nid, const Source& src, const Identifie } } -TypeDecl::TypeDecl(TypeDecl&&) = default; - TypeDecl::~TypeDecl() = default; } // namespace tint::ast diff --git a/src/tint/ast/type_decl.h b/src/tint/ast/type_decl.h index fb8958ff27..8ec0fe49f4 100644 --- a/src/tint/ast/type_decl.h +++ b/src/tint/ast/type_decl.h @@ -33,9 +33,8 @@ class TypeDecl : public Castable { /// @param src the source of this node for the import statement /// @param name The name of the type TypeDecl(ProgramID pid, NodeID nid, const Source& src, const Identifier* name); - /// Move constructor - TypeDecl(TypeDecl&&); + /// Destructor ~TypeDecl() override; /// The name of the type declaration diff --git a/src/tint/ast/unary_op_expression.cc b/src/tint/ast/unary_op_expression.cc index eec69a05ab..104d74ada0 100644 --- a/src/tint/ast/unary_op_expression.cc +++ b/src/tint/ast/unary_op_expression.cc @@ -30,8 +30,6 @@ UnaryOpExpression::UnaryOpExpression(ProgramID pid, TINT_ASSERT_PROGRAM_IDS_EQUAL_IF_VALID(AST, expr, program_id); } -UnaryOpExpression::UnaryOpExpression(UnaryOpExpression&&) = default; - UnaryOpExpression::~UnaryOpExpression() = default; const UnaryOpExpression* UnaryOpExpression::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/unary_op_expression.h b/src/tint/ast/unary_op_expression.h index a5c2be937e..3639447307 100644 --- a/src/tint/ast/unary_op_expression.h +++ b/src/tint/ast/unary_op_expression.h @@ -34,8 +34,8 @@ class UnaryOpExpression final : public Castable { const Source& source, UnaryOp op, const Expression* expr); - /// Move constructor - UnaryOpExpression(UnaryOpExpression&&); + + /// Destructor ~UnaryOpExpression() override; /// Clones this node and all transitive child nodes using the `CloneContext` diff --git a/src/tint/ast/var.cc b/src/tint/ast/var.cc index bccdbccfad..fdd700adc8 100644 --- a/src/tint/ast/var.cc +++ b/src/tint/ast/var.cc @@ -33,8 +33,6 @@ Var::Var(ProgramID pid, declared_address_space(address_space), declared_access(access) {} -Var::Var(Var&&) = default; - Var::~Var() = default; const char* Var::Kind() const { diff --git a/src/tint/ast/var.h b/src/tint/ast/var.h index 006d8de385..6f08a6f0fe 100644 --- a/src/tint/ast/var.h +++ b/src/tint/ast/var.h @@ -61,9 +61,6 @@ class Var final : public Castable { const Expression* initializer, utils::VectorRef attributes); - /// Move constructor - Var(Var&&); - /// Destructor ~Var() override; diff --git a/src/tint/ast/variable.cc b/src/tint/ast/variable.cc index 2aa60bfb92..4a4f756044 100644 --- a/src/tint/ast/variable.cc +++ b/src/tint/ast/variable.cc @@ -36,8 +36,6 @@ Variable::Variable(ProgramID pid, TINT_ASSERT_PROGRAM_IDS_EQUAL_IF_VALID(AST, initializer, program_id); } -Variable::Variable(Variable&&) = default; - Variable::~Variable() = default; } // namespace tint::ast diff --git a/src/tint/ast/variable.h b/src/tint/ast/variable.h index 70e5116c97..2230ac3684 100644 --- a/src/tint/ast/variable.h +++ b/src/tint/ast/variable.h @@ -58,9 +58,6 @@ class Variable : public Castable { const Expression* initializer, utils::VectorRef attributes); - /// Move constructor - Variable(Variable&&); - /// Destructor ~Variable() override; diff --git a/src/tint/ast/variable_decl_statement.cc b/src/tint/ast/variable_decl_statement.cc index 79ee92606c..62c5797a77 100644 --- a/src/tint/ast/variable_decl_statement.cc +++ b/src/tint/ast/variable_decl_statement.cc @@ -29,8 +29,6 @@ VariableDeclStatement::VariableDeclStatement(ProgramID pid, TINT_ASSERT_PROGRAM_IDS_EQUAL_IF_VALID(AST, variable, program_id); } -VariableDeclStatement::VariableDeclStatement(VariableDeclStatement&&) = default; - VariableDeclStatement::~VariableDeclStatement() = default; const VariableDeclStatement* VariableDeclStatement::Clone(CloneContext* ctx) const { diff --git a/src/tint/ast/variable_decl_statement.h b/src/tint/ast/variable_decl_statement.h index b71d0b2acc..99a9a5d346 100644 --- a/src/tint/ast/variable_decl_statement.h +++ b/src/tint/ast/variable_decl_statement.h @@ -32,8 +32,8 @@ class VariableDeclStatement final : public Castable { const Expression* condition, const BlockStatement* body, utils::VectorRef attributes); - /// Move constructor - WhileStatement(WhileStatement&&); + + /// Destructor ~WhileStatement() override; /// Clones this node and all transitive child nodes using the `CloneContext`