From 9c81f8738a47caff631669dba307cc4b2042a7fb Mon Sep 17 00:00:00 2001 From: Bryan Bernhart Date: Mon, 18 Nov 2019 23:09:38 +0000 Subject: [PATCH] Allow SetBindGroup command to be skipped with dynamic offsets. Fixes a bug where SetBindGroup command would fail to be skipped. BUG=dawn:256 Change-Id: I9815c9d31aa88f6881274a1873cabe17379cc2e0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/13800 Reviewed-by: Austin Eng Commit-Queue: Bryan Bernhart --- src/dawn_native/Commands.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/dawn_native/Commands.cpp b/src/dawn_native/Commands.cpp index b2019a9bf1..3810089066 100644 --- a/src/dawn_native/Commands.cpp +++ b/src/dawn_native/Commands.cpp @@ -254,9 +254,12 @@ namespace dawn_native { commands->NextCommand(); break; - case Command::SetBindGroup: - commands->NextCommand(); - break; + case Command::SetBindGroup: { + SetBindGroupCmd* cmd = commands->NextCommand(); + if (cmd->dynamicOffsetCount > 0) { + commands->NextData(cmd->dynamicOffsetCount); + } + } break; case Command::SetIndexBuffer: commands->NextCommand();