From a35b57f91fe196975d3bb33a2683207c3b645dd5 Mon Sep 17 00:00:00 2001 From: David Neto Date: Tue, 5 Jan 2021 19:22:30 +0000 Subject: [PATCH] spirv-reader: rename to isNan, isInf Fixed: tint:418 Change-Id: I09185880c838d437f84c4ef85528b4d807c0b340 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/36440 Commit-Queue: David Neto Commit-Queue: Ryan Harrison Commit-Queue: dan sinclair Auto-Submit: David Neto Reviewed-by: Ryan Harrison Reviewed-by: dan sinclair --- src/reader/spirv/function.cc | 4 ++-- src/reader/spirv/function_logical_test.cc | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/reader/spirv/function.cc b/src/reader/spirv/function.cc index 92f83e5f24..0e88128cda 100644 --- a/src/reader/spirv/function.cc +++ b/src/reader/spirv/function.cc @@ -212,9 +212,9 @@ const char* GetUnaryBuiltInFunctionName(SpvOp opcode) { case SpvOpAll: return "all"; case SpvOpIsNan: - return "is_nan"; + return "isNan"; case SpvOpIsInf: - return "is_inf"; + return "isInf"; default: break; } diff --git a/src/reader/spirv/function_logical_test.cc b/src/reader/spirv/function_logical_test.cc index 355c223761..e5171cf818 100644 --- a/src/reader/spirv/function_logical_test.cc +++ b/src/reader/spirv/function_logical_test.cc @@ -1380,7 +1380,7 @@ TEST_F(SpvLogicalTest, IsNan_Scalar) { __bool { Call[not set]{ - Identifier[not set]{is_nan} + Identifier[not set]{isNan} ( ScalarConstructor[not set]{50.000000} ) @@ -1410,7 +1410,7 @@ TEST_F(SpvLogicalTest, IsNan_Vector) { __vec_2__bool { Call[not set]{ - Identifier[not set]{is_nan} + Identifier[not set]{isNan} ( TypeConstructor[not set]{ __vec_2__f32 @@ -1444,7 +1444,7 @@ TEST_F(SpvLogicalTest, IsInf_Scalar) { __bool { Call[not set]{ - Identifier[not set]{is_inf} + Identifier[not set]{isInf} ( ScalarConstructor[not set]{50.000000} ) @@ -1474,7 +1474,7 @@ TEST_F(SpvLogicalTest, IsInf_Vector) { __vec_2__bool { Call[not set]{ - Identifier[not set]{is_inf} + Identifier[not set]{isInf} ( TypeConstructor[not set]{ __vec_2__f32