From a6a7e46e54518bd730caf47ef4d4a01ff81f9123 Mon Sep 17 00:00:00 2001 From: "Yan, Shaobo" Date: Tue, 1 Dec 2020 07:57:47 +0000 Subject: [PATCH] Enable CopyTextureForBrowserTests on Vulkan/Metal Backend CopyTextureForBrowser end2end tests had been skipped on Vulkan/Metal backends due to crbug.com/tint/63. Because this issue has been fixed, enable CopyTextureForBrowserTests on Vulkan/Metal backends. However, D3D12 backend with validation layer still stucks. Raise issue crbug.com/dawn/592 and keep tests skip. BUG=dawn:465 Change-Id: I819b3608d07ea7467b33263004e9e19158e73eff Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/34440 Commit-Queue: Corentin Wallez Reviewed-by: Corentin Wallez --- src/tests/end2end/CopyTextureForBrowserTests.cpp | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/tests/end2end/CopyTextureForBrowserTests.cpp b/src/tests/end2end/CopyTextureForBrowserTests.cpp index 146e274b8b..009f4ba537 100644 --- a/src/tests/end2end/CopyTextureForBrowserTests.cpp +++ b/src/tests/end2end/CopyTextureForBrowserTests.cpp @@ -157,9 +157,7 @@ class CopyTextureForBrowserTests : public DawnTest { // Verify CopyTextureForBrowserTests works with internal pipeline. // The case do copy without any transform. TEST_P(CopyTextureForBrowserTests, PassthroughCopy) { - // These tests fails due to crbug.com/tint/63. - DAWN_SKIP_TEST_IF(IsSwiftshader()); - DAWN_SKIP_TEST_IF(IsVulkan()); + // Tests skip due to crbug.com/dawn/592. DAWN_SKIP_TEST_IF(IsD3D12() && IsBackendValidationEnabled()); // OpenGL tests fails due to 'WriteTexture' unimplemented. @@ -177,9 +175,7 @@ TEST_P(CopyTextureForBrowserTests, PassthroughCopy) { } TEST_P(CopyTextureForBrowserTests, VerifyCopyOnXDirection) { - // These tests fails due to crbug.com/tint/63. - DAWN_SKIP_TEST_IF(IsSwiftshader()); - DAWN_SKIP_TEST_IF(IsVulkan()); + // Tests skip due to crbug.com/dawn/592. DAWN_SKIP_TEST_IF(IsD3D12() && IsBackendValidationEnabled()); // OpenGL tests fails due to 'WriteTexture' unimplemented. @@ -197,9 +193,7 @@ TEST_P(CopyTextureForBrowserTests, VerifyCopyOnXDirection) { } TEST_P(CopyTextureForBrowserTests, VerifyCopyOnYDirection) { - // These tests fails due to crbug.com/tint/63. - DAWN_SKIP_TEST_IF(IsSwiftshader()); - DAWN_SKIP_TEST_IF(IsVulkan()); + // Tests skip due to crbug.com/dawn/592. DAWN_SKIP_TEST_IF(IsD3D12() && IsBackendValidationEnabled()); // OpenGL tests fails due to 'WriteTexture' unimplemented. @@ -217,9 +211,7 @@ TEST_P(CopyTextureForBrowserTests, VerifyCopyOnYDirection) { } TEST_P(CopyTextureForBrowserTests, VerifyCopyFromLargeTexture) { - // These tests fails due to crbug.com/tint/63. - DAWN_SKIP_TEST_IF(IsSwiftshader()); - DAWN_SKIP_TEST_IF(IsVulkan()); + // Tests skip due to crbug.com/dawn/592. DAWN_SKIP_TEST_IF(IsD3D12() && IsBackendValidationEnabled()); // OpenGL tests fails due to 'WriteTexture' unimplemented.