From a7bb5a5b74f5703fcde1e6af239a01f4f9043d6e Mon Sep 17 00:00:00 2001 From: Austin Eng Date: Wed, 16 Dec 2020 09:37:40 +0000 Subject: [PATCH] Remove the hardcoded device tick in Server::HandleCommands This was here to ensure all callbacks return, but this can now be done by calling device.Tick - which Chromium does periodically. Remove it now, especially since it will be incorrect when the wire supports more than one device. Bug: dawn:384 Change-Id: If948ffe8931be7ba989f733efd64549d0c56b382 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/35841 Commit-Queue: Corentin Wallez Reviewed-by: Jiawei Shao Reviewed-by: Corentin Wallez --- generator/templates/dawn_wire/server/ServerHandlers.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/generator/templates/dawn_wire/server/ServerHandlers.cpp b/generator/templates/dawn_wire/server/ServerHandlers.cpp index 01e73e782b..22bbc8c8f8 100644 --- a/generator/templates/dawn_wire/server/ServerHandlers.cpp +++ b/generator/templates/dawn_wire/server/ServerHandlers.cpp @@ -90,8 +90,6 @@ namespace dawn_wire { namespace server { {% endfor %} const volatile char* Server::HandleCommandsImpl(const volatile char* commands, size_t size) { - mProcs.deviceTick(DeviceObjects().Get(1)->handle); - while (size >= sizeof(CmdHeader) + sizeof(WireCmd)) { // Start by chunked command handling, if it is done, then it means the whole buffer // was consumed by it, so we return a pointer to the end of the commands.