From a8bcec3ac10b778bf8ed11dedf493472ecb4a55f Mon Sep 17 00:00:00 2001 From: David Neto Date: Fri, 27 Mar 2020 21:11:05 +0000 Subject: [PATCH] [spirv-reader] Add TODO for ArrayStride Bug: tint:3 Change-Id: I9655ddbe48f2660f88be68bc52c9467d805043ab Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/18080 Reviewed-by: Ryan Harrison Commit-Queue: Ryan Harrison --- src/reader/spirv/parser_impl.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/reader/spirv/parser_impl.cc b/src/reader/spirv/parser_impl.cc index 2d3a9535c3..8679f03158 100644 --- a/src/reader/spirv/parser_impl.cc +++ b/src/reader/spirv/parser_impl.cc @@ -183,6 +183,7 @@ ast::type::Type* ParserImpl::ConvertType(uint32_t type_id) { break; } case spvtools::opt::analysis::Type::kRuntimeArray: { + // TODO(dneto): Handle ArrayStride. Blocked by crbug.com/tint/30 const auto* rtarr_ty = spirv_type->AsRuntimeArray(); auto* ast_elem_ty = ConvertType(type_mgr_->GetId(rtarr_ty->element_type())); @@ -194,6 +195,7 @@ ast::type::Type* ParserImpl::ConvertType(uint32_t type_id) { break; } case spvtools::opt::analysis::Type::kArray: { + // TODO(dneto): Handle ArrayStride. Blocked by crbug.com/tint/30 const auto* arr_ty = spirv_type->AsArray(); auto* ast_elem_ty = ConvertType(type_mgr_->GetId(arr_ty->element_type())); if (ast_elem_ty == nullptr) {