From ab6a9b9906ca60fd08a68fdcb24415efb794b987 Mon Sep 17 00:00:00 2001 From: Austin Eng Date: Fri, 26 May 2023 03:18:14 +0000 Subject: [PATCH] Skip dawn_end2end_tests on d3d11 NVIDIA Suspect causing undefined behavior seen in crbug.com/1448982 The D3D11 backend is producing validation layers errors, so that could be the root cause. Bug: chromium:1448982, dawn:1847 Change-Id: I3fa943f6f9fb48f6cf05da0e571041e6d0c48bed Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/134542 Reviewed-by: Loko Kung Commit-Queue: Austin Eng Auto-Submit: Austin Eng Kokoro: Kokoro --- src/dawn/tests/DawnTest.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/dawn/tests/DawnTest.cpp b/src/dawn/tests/DawnTest.cpp index f34e69cb9f..30bb0f5c1e 100644 --- a/src/dawn/tests/DawnTest.cpp +++ b/src/dawn/tests/DawnTest.cpp @@ -456,6 +456,14 @@ void DawnTestEnvironment::SelectPreferredAdapterProperties(const dawn::native::I // All adapters are selected by default. bool selected = true; + + // TODO(chromium:1448982, dawn:1847): Suspect causing undefined behavior due to + // incorrect API usage. Re-enable after fixing. + if (properties.backendType == wgpu::BackendType::D3D11 && + dawn::gpu_info::IsNvidia(properties.vendorID)) { + selected = false; + } + // The adapter is deselected if: if (mHasBackendTypeFilter) { // It doesn't match the backend type, if present.