From b033c9da8e163f9eea0e7283191971a2b8975796 Mon Sep 17 00:00:00 2001 From: Ryan Harrison Date: Wed, 27 Jan 2021 22:15:14 +0000 Subject: [PATCH] Enable tests in GpuMemorySynchronizationTests.cpp The blocking issues in Tint for the tests in this file have been resolved, so they can be re-enabled. There is one outstanding TODO related to Tint in the file about re-writting one of the shaders, which the root issue for is still open. BUG=tint:398 Change-Id: Ia173a33d7ea88b6355dff8b02fd8394f2fa61fd7 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/39120 Commit-Queue: Ryan Harrison Commit-Queue: Austin Eng Auto-Submit: Ryan Harrison Reviewed-by: Austin Eng --- .../end2end/GpuMemorySynchronizationTests.cpp | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/tests/end2end/GpuMemorySynchronizationTests.cpp b/src/tests/end2end/GpuMemorySynchronizationTests.cpp index 30b9c467ae..ffdc643015 100644 --- a/src/tests/end2end/GpuMemorySynchronizationTests.cpp +++ b/src/tests/end2end/GpuMemorySynchronizationTests.cpp @@ -21,13 +21,6 @@ class GpuMemorySyncTests : public DawnTest { protected: - void SetUp() override { - DawnTest::SetUp(); - - // TODO(crbug.com/tint/398): GLSL builtins don't work with SPIR-V reader. - DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator")); - } - wgpu::Buffer CreateBuffer() { wgpu::BufferDescriptor srcDesc; srcDesc.size = 4; @@ -308,13 +301,6 @@ DAWN_INSTANTIATE_TEST(GpuMemorySyncTests, class StorageToUniformSyncTests : public DawnTest { protected: - void SetUp() override { - DawnTest::SetUp(); - - // TODO(crbug.com/tint/398): GLSL builtins don't work with SPIR-V reader. - DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator")); - } - void CreateBuffer() { wgpu::BufferDescriptor bufferDesc; bufferDesc.size = sizeof(float);