From b6acae6d353d3a4b9b9054a72239144ead122f8d Mon Sep 17 00:00:00 2001 From: Corentin Wallez Date: Mon, 14 Oct 2019 12:38:10 +0000 Subject: [PATCH] Suppress BufferUploadPerf for setSubData of 16MB on Vulkan TBR=enga@chromium.org BUG=dawn:239 Change-Id: Ie6dda6df45326d57d7ea8f04670904afee25b51d Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12161 Reviewed-by: Corentin Wallez Commit-Queue: Corentin Wallez --- src/tests/perf_tests/BufferUploadPerf.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/tests/perf_tests/BufferUploadPerf.cpp b/src/tests/perf_tests/BufferUploadPerf.cpp index fa85aaf25f..fcc85a5169 100644 --- a/src/tests/perf_tests/BufferUploadPerf.cpp +++ b/src/tests/perf_tests/BufferUploadPerf.cpp @@ -147,9 +147,12 @@ void BufferUploadPerf::Step() { } TEST_P(BufferUploadPerf, Run) { - // TODO(crbug.com/dawn/239): Investigate why large buffer uploads via SetSubData fail on Metal. + // TODO(crbug.com/dawn/239): Investigate why large buffer uploads via SetSubData fail on some + // configurations. DAWN_SKIP_TEST_IF(IsMetal() && GetParam().uploadMethod == UploadMethod::SetSubData && GetParam().uploadSize == UploadSize::BufferSize_16MB); + DAWN_SKIP_TEST_IF(IsVulkan() && GetParam().uploadMethod == UploadMethod::SetSubData && + GetParam().uploadSize == UploadSize::BufferSize_16MB); RunTest(); }