diff --git a/src/dawn/CPPLINT.cfg b/src/dawn/CPPLINT.cfg index 3a4f1d294e..7500cc9712 100644 --- a/src/dawn/CPPLINT.cfg +++ b/src/dawn/CPPLINT.cfg @@ -8,6 +8,3 @@ filter=-runtime/explicit filter=-runtime/indentation_namespace filter=-runtime/int filter=-runtime/threadsafe_fn -filter=-whitespace/blank_line -filter=-whitespace/comments -filter=-whitespace/todo diff --git a/src/dawn/native/BindGroup.cpp b/src/dawn/native/BindGroup.cpp index 503e6137e4..b0c2869c34 100644 --- a/src/dawn/native/BindGroup.cpp +++ b/src/dawn/native/BindGroup.cpp @@ -308,7 +308,7 @@ namespace dawn::native { // external textures have been expanded into their underlying contents. For this reason // we must identify external texture binding entries by checking the bind group entry // itself. - // TODO:(dawn:1293): Store external textures in + // TODO(dawn:1293): Store external textures in // BindGroupLayoutBase::BindingDataPointers::bindings so checking external textures can // be moved in the switch below. const ExternalTextureBindingEntry* externalTextureBindingEntry = nullptr; diff --git a/src/dawn/native/BindGroup.h b/src/dawn/native/BindGroup.h index 6ec3c7a633..2664c4f30f 100644 --- a/src/dawn/native/BindGroup.h +++ b/src/dawn/native/BindGroup.h @@ -86,7 +86,7 @@ namespace dawn::native { Ref mLayout; BindGroupLayoutBase::BindingDataPointers mBindingData; - // TODO:(dawn:1293): Store external textures in + // TODO(dawn:1293): Store external textures in // BindGroupLayoutBase::BindingDataPointers::bindings std::vector> mBoundExternalTextures; }; diff --git a/src/dawn/native/BindGroupLayout.cpp b/src/dawn/native/BindGroupLayout.cpp index 201aecc118..5db20417e7 100644 --- a/src/dawn/native/BindGroupLayout.cpp +++ b/src/dawn/native/BindGroupLayout.cpp @@ -203,7 +203,7 @@ namespace dawn::native { // increment the binding counts for an additional sampled textures and a // sampler so that an external texture will occupy the correct number of // slots for correct validation of shader binding limits. - // TODO:(dawn:1082): Consider removing this and instead making a change to + // TODO(dawn:1082): Consider removing this and instead making a change to // the validation. constexpr uint32_t kUnimplementedSampledTexturesPerExternalTexture = 2; constexpr uint32_t kUnimplementedSamplersPerExternalTexture = 1; diff --git a/src/dawn/native/ResourceMemoryAllocation.h b/src/dawn/native/ResourceMemoryAllocation.h index 5fea0f1131..fee117e2c7 100644 --- a/src/dawn/native/ResourceMemoryAllocation.h +++ b/src/dawn/native/ResourceMemoryAllocation.h @@ -24,7 +24,6 @@ namespace dawn::native { // Allocation method determines how memory was sub-divided. // Used by the device to get the allocator that was responsible for the allocation. enum class AllocationMethod { - // Memory not sub-divided. kDirect, diff --git a/src/dawn/native/d3d12/AdapterD3D12.cpp b/src/dawn/native/d3d12/AdapterD3D12.cpp index d31b9afef6..cbedea0dcd 100644 --- a/src/dawn/native/d3d12/AdapterD3D12.cpp +++ b/src/dawn/native/d3d12/AdapterD3D12.cpp @@ -306,7 +306,6 @@ namespace dawn::native::d3d12 { } D3D12_MESSAGE_ID denyIds[] = { - // // Permanent IDs: list of warnings that are not applicable // diff --git a/src/dawn/native/d3d12/ResourceAllocatorManagerD3D12.h b/src/dawn/native/d3d12/ResourceAllocatorManagerD3D12.h index 41058ce8c2..2e3d0f264b 100644 --- a/src/dawn/native/d3d12/ResourceAllocatorManagerD3D12.h +++ b/src/dawn/native/d3d12/ResourceAllocatorManagerD3D12.h @@ -32,7 +32,6 @@ namespace dawn::native::d3d12 { // https://docs.microsoft.com/en-us/windows/win32/api/d3d12/ne-d3d12-d3d12_heap_flags // https://docs.microsoft.com/en-us/windows/win32/api/d3d12/ne-d3d12-d3d12_heap_type enum ResourceHeapKind { - // Resource heap tier 2 // Allows resource heaps to contain all buffer and textures types. // This enables better heap re-use by avoiding the need for separate heaps and diff --git a/src/dawn/tests/end2end/BufferZeroInitTests.cpp b/src/dawn/tests/end2end/BufferZeroInitTests.cpp index 5788ddd1a6..ce40c335dc 100644 --- a/src/dawn/tests/end2end/BufferZeroInitTests.cpp +++ b/src/dawn/tests/end2end/BufferZeroInitTests.cpp @@ -1135,8 +1135,8 @@ TEST_P(BufferZeroInitTest, SetVertexBuffer) { // draw call. A backend which implements robust buffer access via clamping should // still see zeros at the end of the buffer. TEST_P(BufferZeroInitTest, PaddingInitialized) { - DAWN_SUPPRESS_TEST_IF(IsANGLE()); // TODO(crbug.com/dawn/1084). - DAWN_SUPPRESS_TEST_IF(IsLinux() && IsVulkan() && IsNvidia()); // TODO(crbug.com/dawn/1214). + DAWN_SUPPRESS_TEST_IF(IsANGLE()); // TODO(crbug.com/dawn/1084) + DAWN_SUPPRESS_TEST_IF(IsLinux() && IsVulkan() && IsNvidia()); // TODO(crbug.com/dawn/1214) constexpr wgpu::TextureFormat kColorAttachmentFormat = wgpu::TextureFormat::RGBA8Unorm; // A small sub-4-byte format means a single vertex can fit entirely within the padded buffer, diff --git a/src/dawn/tests/end2end/VideoViewsTests.cpp b/src/dawn/tests/end2end/VideoViewsTests.cpp index c03ee6f1ff..216ace0b13 100644 --- a/src/dawn/tests/end2end/VideoViewsTests.cpp +++ b/src/dawn/tests/end2end/VideoViewsTests.cpp @@ -91,11 +91,11 @@ std::vector VideoViewsTests::GetTestTextureData(wgpu::TextureFormat for // clang-format off return { - Wy, Wy, Ry, Ry, // plane 0, start + 0 + Wy, Wy, Ry, Ry, // plane 0, start + 0 Wy, Wy, Ry, Ry, Yy, Yy, By, By, Yy, Yy, By, By, - Wu, Wv, Ru, Rv, // plane 1, start + 16 + Wu, Wv, Ru, Rv, // plane 1, start + 16 Yu, Yv, Bu, Bv, }; // clang-format on diff --git a/src/dawn/tests/unittests/StackContainerTests.cpp b/src/dawn/tests/unittests/StackContainerTests.cpp index a42721594a..3dd2d47b40 100644 --- a/src/dawn/tests/unittests/StackContainerTests.cpp +++ b/src/dawn/tests/unittests/StackContainerTests.cpp @@ -130,7 +130,7 @@ TEST(StackContainer, BufferAlignment) { #if !defined(DAWN_COMPILER_GCC) || defined(__x86_64__) || defined(__i386__) // It seems that non-X86 gcc doesn't respect greater than 16 byte alignment. // See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33721 for details. - // TODO(sbc):re-enable this if GCC starts respecting higher alignments. + // TODO(sbc): Re-enable this if GCC starts respecting higher alignments. StackVector, 1> aligned256; aligned256->push_back(AlignedData<256>()); EXPECT_ALIGNED(&aligned256[0], 256);