From ba7793b8f8bf0d1f797d1fba64a00cdb0805c58c Mon Sep 17 00:00:00 2001 From: Kai Ninomiya Date: Thu, 26 May 2022 22:51:05 +0000 Subject: [PATCH] Remove TextureView test suppressions for Mac AMD The "Mac Pro FYI (AMD)" bot these were added for probably doesn't exist anymore, and this issue seemed to be fixed long ago, in macOS 10.13. Issue: dawn:58 Change-Id: I3490a39a32f6b80111574d123327a0e6865f2c25 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/91741 Reviewed-by: Austin Eng Kokoro: Kokoro Commit-Queue: Kai Ninomiya Auto-Submit: Kai Ninomiya --- src/dawn/tests/end2end/TextureViewTests.cpp | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/dawn/tests/end2end/TextureViewTests.cpp b/src/dawn/tests/end2end/TextureViewTests.cpp index 2ad6cd032d..38ac5238dc 100644 --- a/src/dawn/tests/end2end/TextureViewTests.cpp +++ b/src/dawn/tests/end2end/TextureViewTests.cpp @@ -552,20 +552,12 @@ TEST_P(TextureViewSamplingTest, TextureCubeMapArrayOnWholeTexture) { // Test sampling from a cube map texture array view that covers a sub part of a 2D array texture. TEST_P(TextureViewSamplingTest, TextureCubeMapArrayViewOnPartOfTexture) { - // Test failing on the GPU FYI Mac Pro (AMD), see - // https://bugs.chromium.org/p/dawn/issues/detail?id=58 - DAWN_SUPPRESS_TEST_IF(IsMacOS() && IsMetal() && IsAMD()); - TextureCubeMapTest(20, 3, 12, true); } // Test sampling from a cube map texture array view that covers the last layer of a 2D array // texture. TEST_P(TextureViewSamplingTest, TextureCubeMapArrayViewCoveringLastLayer) { - // Test failing on the GPU FYI Mac Pro (AMD), see - // https://bugs.chromium.org/p/dawn/issues/detail?id=58 - DAWN_SUPPRESS_TEST_IF(IsMacOS() && IsMetal() && IsAMD()); - constexpr uint32_t kTotalLayers = 20; constexpr uint32_t kBaseLayer = 8; TextureCubeMapTest(kTotalLayers, kBaseLayer, kTotalLayers - kBaseLayer, true); @@ -573,10 +565,6 @@ TEST_P(TextureViewSamplingTest, TextureCubeMapArrayViewCoveringLastLayer) { // Test sampling from a cube map array texture view that only has a single cube map. TEST_P(TextureViewSamplingTest, TextureCubeMapArrayViewSingleCubeMap) { - // Test failing on the GPU FYI Mac Pro (AMD), see - // https://bugs.chromium.org/p/dawn/issues/detail?id=58 - DAWN_SUPPRESS_TEST_IF(IsMacOS() && IsMetal() && IsAMD()); - TextureCubeMapTest(20, 7, 6, true); }