From bda18d2b8d6bf994fc98c633708f1ee71dede0c9 Mon Sep 17 00:00:00 2001 From: Yuly Novikov Date: Wed, 1 Mar 2023 20:21:44 +0000 Subject: [PATCH] Skip MaxBufferBindingSize on Metal AMD Fails on MacBook Pro 2019 Bug: dawn:1683 Change-Id: I335df3ae7e7cd9432d937a3b7d117f77b6143fa4 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/122200 Reviewed-by: Austin Eng Kokoro: Kokoro Commit-Queue: Yuly Novikov --- src/dawn/tests/end2end/MaxLimitTests.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/dawn/tests/end2end/MaxLimitTests.cpp b/src/dawn/tests/end2end/MaxLimitTests.cpp index 1654bb90e2..a603db848b 100644 --- a/src/dawn/tests/end2end/MaxLimitTests.cpp +++ b/src/dawn/tests/end2end/MaxLimitTests.cpp @@ -113,6 +113,8 @@ TEST_P(MaxLimitTests, MaxBufferBindingSize) { // TODO(dawn:1549) Fails on Qualcomm-based Android devices. DAWN_SUPPRESS_TEST_IF(IsAndroid() && IsQualcomm()); + // TODO(crbug.com/dawn/1683) Fails on MacBook Pro 2019 + DAWN_SUPPRESS_TEST_IF(IsMacOS() && IsMetal() && IsAMD()); for (wgpu::BufferUsage usage : {wgpu::BufferUsage::Storage, wgpu::BufferUsage::Uniform}) { uint64_t maxBufferBindingSize;