From d1448056887540ac4a83f918c584037c982942fd Mon Sep 17 00:00:00 2001 From: Jiawei Shao Date: Wed, 27 Jul 2022 10:09:25 +0000 Subject: [PATCH] Skip tests about writeonly storage texture In render pass on ANGLE StorageTextureTests.WriteonlyStorageTextureInFragmentShader and StorageTextureZeroInitTests. WriteonlyStorageTextureClearsToZeroInRenderPass starts to fail on the bots after the latest roll of ANGLE, so we have to temporarily suppress them. Bug: dawn:1503 Test: dawn_end2end_tests Change-Id: Id8abf7c0a5bd30e5de12c838f871e1ab896ab4fd Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97127 Reviewed-by: Ben Clayton Kokoro: Kokoro Commit-Queue: Ben Clayton --- src/dawn/tests/end2end/StorageTextureTests.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/dawn/tests/end2end/StorageTextureTests.cpp b/src/dawn/tests/end2end/StorageTextureTests.cpp index d0eb80ac34..11f43046bc 100644 --- a/src/dawn/tests/end2end/StorageTextureTests.cpp +++ b/src/dawn/tests/end2end/StorageTextureTests.cpp @@ -696,6 +696,9 @@ TEST_P(StorageTextureTests, WriteonlyStorageTextureInFragmentShader) { // NVidia OpenGLES drivers. DAWN_SUPPRESS_TEST_IF(IsNvidia() && IsLinux() && IsOpenGLES()); + // TODO(crbug.com/dawn/1503): Investigate the regression in ANGLE that causes the test failure. + DAWN_SUPPRESS_TEST_IF(IsANGLE()); + for (wgpu::TextureFormat format : utils::kAllTextureFormats) { if (!utils::TextureFormatSupportsStorageTexture(format)) { continue; @@ -913,6 +916,9 @@ fn doTest() -> bool { // Verify that the texture is correctly cleared to 0 before its first usage as a write-only storage // storage texture in a render pass. TEST_P(StorageTextureZeroInitTests, WriteonlyStorageTextureClearsToZeroInRenderPass) { + // TODO(crbug.com/dawn/1503): Investigate the regression in ANGLE that causes the test failure. + DAWN_SUPPRESS_TEST_IF(IsANGLE()); + // Prepare the write-only storage texture. wgpu::Texture writeonlyStorageTexture = CreateTexture( wgpu::TextureFormat::R32Uint,