Remove tint's usage of Validator

Also update comments and arch design to remove references to the
Validator.

Bug: tint:642
Change-Id: Ic0b4779ae4712a393ff209014daf25e23f32be6d
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/47061
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
This commit is contained in:
Antonio Maiorano
2021-04-08 14:08:47 +00:00
committed by Commit Bot service account
parent 101f463992
commit d15391e802
6 changed files with 12 additions and 35 deletions

View File

@@ -262,8 +262,8 @@ std::map<uint32_t, Scalar> Inspector::GetConstantIDs() {
}
// If there are conflicting defintions for a constant id, that is invalid
// WGSL, so the validator should catch it. Thus here the inspector just
// assumes all definitians of the constant id are the same, so only needs
// WGSL, so the resolver should catch it. Thus here the inspector just
// assumes all definitions of the constant id are the same, so only needs
// to find the first reference to constant id.
uint32_t constant_id = var->constant_id();
if (result.find(constant_id) != result.end()) {

View File

@@ -256,7 +256,7 @@ TEST_P(VariableDecorationTest, IsValid) {
}
}
INSTANTIATE_TEST_SUITE_P(
ValidatorTest,
ResolverDecorationValidationTest,
VariableDecorationTest,
testing::Values(TestParams{DecorationKind::kAccess, false},
TestParams{DecorationKind::kAlign, false},
@@ -290,7 +290,7 @@ TEST_P(FunctionDecorationTest, IsValid) {
}
}
INSTANTIATE_TEST_SUITE_P(
ValidatorTest,
ResolverDecorationValidationTest,
FunctionDecorationTest,
testing::Values(TestParams{DecorationKind::kAccess, false},
TestParams{DecorationKind::kAlign, false},

View File

@@ -1252,8 +1252,7 @@ bool Resolver::MemberAccessor(ast::MemberAccessorExpression* expr) {
}
} else {
// The vector will have a number of components equal to the length of
// the swizzle. This assumes the validator will check that the swizzle
// is correct.
// the swizzle.
ret = builder_->create<type::Vector>(vec->type(),
static_cast<uint32_t>(size));
}