From d23fdd3624d16665a68ab5d0af3efd61bff21260 Mon Sep 17 00:00:00 2001 From: Corentin Wallez Date: Tue, 18 Dec 2018 18:04:42 +0000 Subject: [PATCH] Fix the suppression on OpenGL to not specify the GPU The OpenGL backend doesn't expose PCI device and vendor IDs yet which means that IsAMD() is always false, making the test not skipped. TBR=senorblanco@chromium.org BUG=chromium:915430 Change-Id: Ic630080df442826b572cbd294978820109424229 Reviewed-on: https://dawn-review.googlesource.com/c/3381 Reviewed-by: Corentin Wallez Commit-Queue: Corentin Wallez --- src/tests/end2end/InputStateTests.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/tests/end2end/InputStateTests.cpp b/src/tests/end2end/InputStateTests.cpp index 8c99e23454..219f8f5a60 100644 --- a/src/tests/end2end/InputStateTests.cpp +++ b/src/tests/end2end/InputStateTests.cpp @@ -243,7 +243,8 @@ TEST_P(InputStateTest, ZeroStride) { // Test attributes defaults to (0, 0, 0, 1) if the input state doesn't have all components TEST_P(InputStateTest, AttributeExpanding) { - DAWN_SKIP_TEST_IF(IsLinux() && IsOpenGL() && IsAMD()); + // This test was failing only on AMD but the OpenGL backend doesn't gather PCI info yet. + DAWN_SKIP_TEST_IF(IsLinux() && IsOpenGL()); // R32F case {