From d59fec5d706eb7ff403e83ae69ed999a3c13f6df Mon Sep 17 00:00:00 2001 From: "Li, Hao" Date: Tue, 15 Oct 2019 01:42:45 +0000 Subject: [PATCH] Skip LargeBufferFails test with NVIDIA for enabling Vulkan validation layers on Windows Fails on NVIDIA cards when Vulkan validation layers are enabled becuase the maximum size of a single allocation cannot be larger than or equal to 4G on some platforms. BUG=dawn:241 Change-Id: I863a2219287d3d363b3013027ba8fc9df846b42d Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12141 Reviewed-by: Corentin Wallez Reviewed-by: Austin Eng Commit-Queue: Hao Li --- src/tests/end2end/BufferTests.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/tests/end2end/BufferTests.cpp b/src/tests/end2end/BufferTests.cpp index 2b0f10bc35..98f23878b7 100644 --- a/src/tests/end2end/BufferTests.cpp +++ b/src/tests/end2end/BufferTests.cpp @@ -635,6 +635,11 @@ TEST_P(CreateBufferMappedTests, LargeBufferFails) { // TODO(http://crbug.com/dawn/27): Missing support. DAWN_SKIP_TEST_IF(IsMetal() || IsOpenGL()); + // TODO(http://crbug.com/dawn/241): Fails on NVIDIA cards when Vulkan validation layers are + // enabled becuase the maximum size of a single allocation cannot be larger than or equal to + // 4G on some platforms. + DAWN_SKIP_TEST_IF(IsVulkan() && IsNvidia() && IsBackendValidationEnabled()); + dawn::BufferDescriptor descriptor; descriptor.size = std::numeric_limits::max(); descriptor.usage = dawn::BufferUsage::MapRead | dawn::BufferUsage::CopyDst;