From d7451857dd6f14a8fcd99cbc39edccb762e9065a Mon Sep 17 00:00:00 2001 From: Ryan Harrison Date: Wed, 27 Jan 2021 22:20:04 +0000 Subject: [PATCH] Update/enable tests in VertexStateTests One test has the blocking issue updated to what is currently causing the failure, and another is passing now, so can be fully enabled. BUG=tint:114,tint:398 Change-Id: I1735349bdff6f0c36990358b43b17df9c2175970 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/39180 Commit-Queue: Ryan Harrison Commit-Queue: Austin Eng Auto-Submit: Ryan Harrison Reviewed-by: Austin Eng --- src/tests/end2end/VertexStateTests.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/tests/end2end/VertexStateTests.cpp b/src/tests/end2end/VertexStateTests.cpp index 44bf8896a1..72d18bafe8 100644 --- a/src/tests/end2end/VertexStateTests.cpp +++ b/src/tests/end2end/VertexStateTests.cpp @@ -534,7 +534,7 @@ TEST_P(VertexStateTest, LastAllowedVertexBuffer) { // Test that overlapping vertex attributes are permitted and load data correctly TEST_P(VertexStateTest, OverlappingVertexAttributes) { - // TODO(crbug.com/tint/398): GLSL builtins don't work with SPIR-V reader. + // TODO(crbug.com/tint/114): Tint needs to support 1.4 version of OpSelect DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator")); utils::BasicRenderPass renderPass = utils::CreateBasicRenderPass(device, 3, 3); @@ -631,9 +631,6 @@ class OptionalVertexStateTest : public DawnTest {}; // Test that vertex input is not required in render pipeline descriptor. TEST_P(OptionalVertexStateTest, Basic) { - // TODO(crbug.com/tint/398): GLSL builtins don't work with SPIR-V reader. - DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator")); - utils::BasicRenderPass renderPass = utils::CreateBasicRenderPass(device, 3, 3); wgpu::ShaderModule vsModule =