encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-09 13:38:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle complex cases in Inspector::GenerateSamplerTargets

Browse Source 
This code was implicitly assuming that all resources it was looking
for would be directly referenced at the intrinsic callsite, and not
passed via function parameters.

This was causing a crash in more complex cases.

The inspector code has been updated to handle cases where the
resources are not being directly referenced.

Unneeded calls to GenerateSamplerTargets() are removed.

Utility function GetOriginatingResources() is added to handle walking up
call sites to resolve resources.

Text shader based test runner is added to the Inspector tests to make
expressing complex tests easier.

BUG=tint:967

Change-Id: I2ecb6d57c518003da59f38b261bae4d62ce7e6ac
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/59340
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
This commit is contained in:
Ryan Harrison
2021-07-27 15:42:51 +00:00
committed by Tint LUCI CQ
parent dffa60ca98
commit dee93c6b9a
7 changed files with 491 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/BUILD.gn
View File

@@ -224,6 +224,8 @@ tint_unittests_source_set("tint_unittests_core_src") {
"../src/inspector/inspector_test.cc",
"../src/inspector/test_inspector_builder.cc",
"../src/inspector/test_inspector_builder.h",
"../src/inspector/test_inspector_runner.cc",
"../src/inspector/test_inspector_runner.h",
"../src/intrinsic_table_test.cc",
"../src/program_builder_test.cc",
"../src/program_test.cc",