From e0390b89670ffcb9b741d08e81a06345d5782077 Mon Sep 17 00:00:00 2001 From: Jiawei Shao Date: Wed, 13 Oct 2021 04:19:26 +0000 Subject: [PATCH] Fix compilation error after ComputePipelineBase becomes virtual This patch fixes a compilation error after the CL "Avoid redundant creation of ComputePipelineBase in GetCachedComputePipeline" is landed after "Adds destroy handling for BindGroupLayout without new backend changes yet" is merged into upstream. BUG=dawn:529 Change-Id: I5dcb2370093a96703ceb0618f3590364b4eff382 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/66283 Reviewed-by: Zhaoming Jiang Reviewed-by: Shaobo Yan Reviewed-by: Austin Eng Commit-Queue: Austin Eng --- src/dawn_native/Device.cpp | 4 ---- src/dawn_native/Device.h | 1 + src/tests/unittests/native/mocks/DeviceMock.h | 4 ++-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/dawn_native/Device.cpp b/src/dawn_native/Device.cpp index 03fe3b9977..fef1331ea0 100644 --- a/src/dawn_native/Device.cpp +++ b/src/dawn_native/Device.cpp @@ -24,7 +24,6 @@ #include "dawn_native/CommandBuffer.h" #include "dawn_native/CommandEncoder.h" #include "dawn_native/CompilationMessages.h" -#include "dawn_native/ComputePipeline.h" #include "dawn_native/CreatePipelineAsyncTask.h" #include "dawn_native/DynamicUploader.h" #include "dawn_native/ErrorData.h" @@ -35,13 +34,10 @@ #include "dawn_native/InternalPipelineStore.h" #include "dawn_native/ObjectType_autogen.h" #include "dawn_native/PersistentCache.h" -#include "dawn_native/PipelineLayout.h" #include "dawn_native/QuerySet.h" #include "dawn_native/Queue.h" #include "dawn_native/RenderBundleEncoder.h" -#include "dawn_native/RenderPipeline.h" #include "dawn_native/Sampler.h" -#include "dawn_native/ShaderModule.h" #include "dawn_native/Surface.h" #include "dawn_native/SwapChain.h" #include "dawn_native/Texture.h" diff --git a/src/dawn_native/Device.h b/src/dawn_native/Device.h index 92c1cd3b64..1fc37f03b8 100644 --- a/src/dawn_native/Device.h +++ b/src/dawn_native/Device.h @@ -16,6 +16,7 @@ #define DAWNNATIVE_DEVICE_H_ #include "dawn_native/Commands.h" +#include "dawn_native/ComputePipeline.h" #include "dawn_native/Error.h" #include "dawn_native/Features.h" #include "dawn_native/Format.h" diff --git a/src/tests/unittests/native/mocks/DeviceMock.h b/src/tests/unittests/native/mocks/DeviceMock.h index e83e37a2f9..26d600b0e6 100644 --- a/src/tests/unittests/native/mocks/DeviceMock.h +++ b/src/tests/unittests/native/mocks/DeviceMock.h @@ -63,8 +63,8 @@ namespace dawn_native { CreateBufferImpl, (const BufferDescriptor*), (override)); - MOCK_METHOD(ResultOrError>, - CreateComputePipelineImpl, + MOCK_METHOD(Ref, + CreateUninitializedComputePipelineImpl, (const ComputePipelineDescriptor*), (override)); MOCK_METHOD(ResultOrError>,