From e32457fa11ec80677e26066dbc1099c46ef71d3f Mon Sep 17 00:00:00 2001 From: Brendon Tiszka Date: Thu, 17 Nov 2022 22:08:23 +0000 Subject: [PATCH] Revert "Add assertions to ServerInlineMemoryTransferService to catch corrupted states while fuzzing with DawnWireServerFuzzer and tests." This reverts commit f3666c45f3362c7faf7cbdd9328ac76d21327a2a. Reason for revert: Did not realize these assertions could knowingly be reached after this fix for crbug.com/1340654 Original change's description: > Add assertions to ServerInlineMemoryTransferService to catch corrupted states while fuzzing with DawnWireServerFuzzer and tests. > > Bug: chromium:1340654,chromium:1374495,chromium:1376477 > Change-Id: Icfb008a1cd6dbd8af32f3aedc90ef29e29a0465b > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106041 > Commit-Queue: Brendon Tiszka > Reviewed-by: Corentin Wallez > Reviewed-by: Austin Eng > Kokoro: Kokoro # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1340654,chromium:1374495 Change-Id: I5bff56e32266721ec418a545ad72c1065c73d526 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/109461 Commit-Queue: Brendon Tiszka Kokoro: Kokoro Reviewed-by: Austin Eng --- src/dawn/wire/server/ServerInlineMemoryTransferService.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/dawn/wire/server/ServerInlineMemoryTransferService.cpp b/src/dawn/wire/server/ServerInlineMemoryTransferService.cpp index c5f84d4cef..84ecb7b182 100644 --- a/src/dawn/wire/server/ServerInlineMemoryTransferService.cpp +++ b/src/dawn/wire/server/ServerInlineMemoryTransferService.cpp @@ -51,8 +51,6 @@ class InlineMemoryTransferService : public MemoryTransferService { size_t deserializeSize, size_t offset, size_t size) override { - ASSERT(offset <= mDataLength); - ASSERT(size <= mDataLength - offset); if (deserializeSize != size || mTargetData == nullptr || deserializePointer == nullptr) { return false;