From e9ce8326b7843be34e8a31a5a54600cb924c83f2 Mon Sep 17 00:00:00 2001 From: Ben Clayton Date: Thu, 19 May 2022 23:05:40 +0000 Subject: [PATCH] tint: Minor, miscellaneous cleanups MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit • Rename the 'friendly names' for the abstract numeric types so they match the style in the intrinsic table. • Fix a comment so the literal type is correct. Change-Id: Ie8d7363743c8c359340de3bc6db9a3456d299d34 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/91021 Commit-Queue: Ben Clayton Reviewed-by: Antonio Maiorano Kokoro: Kokoro --- src/tint/resolver/var_let_test.cc | 2 +- src/tint/sem/abstract_float.cc | 2 +- src/tint/sem/abstract_int.cc | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/tint/resolver/var_let_test.cc b/src/tint/resolver/var_let_test.cc index 4c62bdd2e9..4306736539 100644 --- a/src/tint/resolver/var_let_test.cc +++ b/src/tint/resolver/var_let_test.cc @@ -86,7 +86,7 @@ TEST_F(ResolverVarLetTest, VarDeclWithConstructor) { // struct S { i : i32; } // alias A = S; // fn F(){ - // var i : i32 = 1; + // var i : i32 = 1i; // var u : u32 = 1u; // var f : f32 = 1.f; // var b : bool = true; diff --git a/src/tint/sem/abstract_float.cc b/src/tint/sem/abstract_float.cc index 1f0c8b4ec9..6f32e998e5 100644 --- a/src/tint/sem/abstract_float.cc +++ b/src/tint/sem/abstract_float.cc @@ -34,7 +34,7 @@ bool AbstractFloat::Equals(const sem::Type& other) const { } std::string AbstractFloat::FriendlyName(const SymbolTable&) const { - return "AbstractFloat"; + return "abstract-float"; } } // namespace tint::sem diff --git a/src/tint/sem/abstract_int.cc b/src/tint/sem/abstract_int.cc index 6851514b4e..682c50aaaf 100644 --- a/src/tint/sem/abstract_int.cc +++ b/src/tint/sem/abstract_int.cc @@ -34,7 +34,7 @@ bool AbstractInt::Equals(const sem::Type& other) const { } std::string AbstractInt::FriendlyName(const SymbolTable&) const { - return "AbstractInt"; + return "abstract-int"; } } // namespace tint::sem