From e9f42997b213f1b287aa31698e22b2bca6976853 Mon Sep 17 00:00:00 2001 From: Stephen White Date: Thu, 11 Feb 2021 13:09:14 +0000 Subject: [PATCH] Enable more tests on OpenGL and OpenGL ES backends. Some of these are skipped by lack of optional feature support, but at least this brings them on the radar by increasing the skip counts for the GL backends. Bug: dawn:580 Change-Id: I3439f41584e70dd51f6d0f7826ef9da7c046020e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/41401 Reviewed-by: Austin Eng Reviewed-by: Corentin Wallez Commit-Queue: Stephen White --- src/tests/end2end/DeviceLostTests.cpp | 2 ++ src/tests/end2end/QueryTests.cpp | 9 ++++++++- src/tests/end2end/ShaderFloat16Tests.cpp | 7 ++++++- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/src/tests/end2end/DeviceLostTests.cpp b/src/tests/end2end/DeviceLostTests.cpp index 1295288ce4..a15ba940e3 100644 --- a/src/tests/end2end/DeviceLostTests.cpp +++ b/src/tests/end2end/DeviceLostTests.cpp @@ -534,4 +534,6 @@ DAWN_INSTANTIATE_TEST(DeviceLostTest, D3D12Backend(), MetalBackend(), NullBackend(), + OpenGLBackend(), + OpenGLESBackend(), VulkanBackend()); diff --git a/src/tests/end2end/QueryTests.cpp b/src/tests/end2end/QueryTests.cpp index aee3cc7dd9..e1d7c1de07 100644 --- a/src/tests/end2end/QueryTests.cpp +++ b/src/tests/end2end/QueryTests.cpp @@ -289,6 +289,8 @@ TEST_P(PipelineStatisticsQueryTests, QuerySetCreation) { DAWN_INSTANTIATE_TEST(PipelineStatisticsQueryTests, D3D12Backend(), MetalBackend(), + OpenGLBackend(), + OpenGLESBackend(), VulkanBackend()); class TimestampExpectation : public detail::Expectation { @@ -531,4 +533,9 @@ TEST_P(TimestampQueryTests, ResolveToBufferWithOffset) { } } -DAWN_INSTANTIATE_TEST(TimestampQueryTests, D3D12Backend(), MetalBackend(), VulkanBackend()); +DAWN_INSTANTIATE_TEST(TimestampQueryTests, + D3D12Backend(), + MetalBackend(), + OpenGLBackend(), + OpenGLESBackend(), + VulkanBackend()); diff --git a/src/tests/end2end/ShaderFloat16Tests.cpp b/src/tests/end2end/ShaderFloat16Tests.cpp index 8972616df3..2daa639c55 100644 --- a/src/tests/end2end/ShaderFloat16Tests.cpp +++ b/src/tests/end2end/ShaderFloat16Tests.cpp @@ -111,4 +111,9 @@ TEST_P(ShaderFloat16Tests, Basic16BitFloatFeaturesTest) { EXPECT_BUFFER_U16_RANGE_EQ(expected, bufferOut, 0, 2); } -DAWN_INSTANTIATE_TEST(ShaderFloat16Tests, D3D12Backend(), MetalBackend(), VulkanBackend()); +DAWN_INSTANTIATE_TEST(ShaderFloat16Tests, + D3D12Backend(), + MetalBackend(), + OpenGLBackend(), + OpenGLESBackend(), + VulkanBackend());