From eef7a6a58c636160bf2d0b2f0ba4cef1954994a8 Mon Sep 17 00:00:00 2001 From: Ben Clayton Date: Tue, 30 Mar 2021 16:23:27 +0000 Subject: [PATCH] Disable tests for D3D12 + tint that fail due 'undeclared identifier' Bug: tint:688 Change-Id: Ic1f0fbd6da112557711595eae38b5d034bbe594b Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46374 Commit-Queue: Ben Clayton Reviewed-by: Corentin Wallez --- src/tests/end2end/ComputeSharedMemoryTests.cpp | 7 +++++++ src/tests/end2end/ObjectCachingTests.cpp | 10 +++++++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/src/tests/end2end/ComputeSharedMemoryTests.cpp b/src/tests/end2end/ComputeSharedMemoryTests.cpp index 246be95f9d..c78a06e78a 100644 --- a/src/tests/end2end/ComputeSharedMemoryTests.cpp +++ b/src/tests/end2end/ComputeSharedMemoryTests.cpp @@ -22,6 +22,13 @@ class ComputeSharedMemoryTests : public DawnTest { public: static constexpr uint32_t kInstances = 11; + void SetUp() override { + DawnTest::SetUp(); + + // TODO(crbug.com/tint/688): error: undeclared identifier '_tint_7' + DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator")); + } + void BasicTest(const char* shader); }; diff --git a/src/tests/end2end/ObjectCachingTests.cpp b/src/tests/end2end/ObjectCachingTests.cpp index bf233b7208..ce8758c5b2 100644 --- a/src/tests/end2end/ObjectCachingTests.cpp +++ b/src/tests/end2end/ObjectCachingTests.cpp @@ -17,7 +17,15 @@ #include "utils/ComboRenderPipelineDescriptor.h" #include "utils/WGPUHelpers.h" -class ObjectCachingTest : public DawnTest {}; +class ObjectCachingTest : public DawnTest { + protected: + void SetUp() override { + DawnTest::SetUp(); + + // TODO(crbug.com/tint/688): error: undeclared identifier '_tint_7' + DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator")); + } +}; // Test that BindGroupLayouts are correctly deduplicated. TEST_P(ObjectCachingTest, BindGroupLayoutDeduplication) {