From f56d8954e343b97f516b76467139a4a0ed736b73 Mon Sep 17 00:00:00 2001
From: Antonio Maiorano <amaiorano@google.com>
Date: Mon, 26 Sep 2022 14:24:35 +0000
Subject: [PATCH] tint/fxc: delete and regen skips for e2e tests to capture FXC
 error messages in expected file

Helps with triaging.

Change-Id: I596fb33d9d60e2e364175cdd0ff1966f71423e99
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103640
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
---
 .../gen/literal/saturate/462535.wgsl.expected.fxc.hlsl      | 5 ++++-
 .../gen/literal/saturate/cd2028.wgsl.expected.fxc.hlsl      | 5 ++++-
 .../gen/literal/saturate/dcde71.wgsl.expected.fxc.hlsl      | 5 ++++-
 .../gen/literal/saturate/e8df56.wgsl.expected.fxc.hlsl      | 6 +++++-
 .../builtins/gen/var/saturate/462535.wgsl.expected.fxc.hlsl | 6 +++++-
 .../builtins/gen/var/saturate/cd2028.wgsl.expected.fxc.hlsl | 6 +++++-
 .../builtins/gen/var/saturate/dcde71.wgsl.expected.fxc.hlsl | 6 +++++-
 .../builtins/gen/var/saturate/e8df56.wgsl.expected.fxc.hlsl | 6 +++++-
 8 files changed, 37 insertions(+), 8 deletions(-)

diff --git a/test/tint/builtins/gen/literal/saturate/462535.wgsl.expected.fxc.hlsl b/test/tint/builtins/gen/literal/saturate/462535.wgsl.expected.fxc.hlsl
index 0c7e9db687..6698fae15f 100644
--- a/test/tint/builtins/gen/literal/saturate/462535.wgsl.expected.fxc.hlsl
+++ b/test/tint/builtins/gen/literal/saturate/462535.wgsl.expected.fxc.hlsl
@@ -1,4 +1,4 @@
-SKIP: FAILED - f16 not supported with FXC
+SKIP: FAILED
 
 void saturate_462535() {
   vector<float16_t, 3> res = saturate((float16_t(0.0h)).xxx);
@@ -30,3 +30,6 @@ void compute_main() {
   saturate_462535();
   return;
 }
+FXC validation failure:
+C:\src\dawn\test\tint\Shader@0x00000234CFF040C0(2,10-18): error X3000: syntax error: unexpected token 'float16_t'
+
diff --git a/test/tint/builtins/gen/literal/saturate/cd2028.wgsl.expected.fxc.hlsl b/test/tint/builtins/gen/literal/saturate/cd2028.wgsl.expected.fxc.hlsl
index 44a52f480c..50c0dd1f3d 100644
--- a/test/tint/builtins/gen/literal/saturate/cd2028.wgsl.expected.fxc.hlsl
+++ b/test/tint/builtins/gen/literal/saturate/cd2028.wgsl.expected.fxc.hlsl
@@ -1,4 +1,4 @@
-SKIP: FAILED - f16 not supported with FXC
+SKIP: FAILED
 
 void saturate_cd2028() {
   vector<float16_t, 2> res = saturate((float16_t(0.0h)).xx);
@@ -30,3 +30,6 @@ void compute_main() {
   saturate_cd2028();
   return;
 }
+FXC validation failure:
+C:\src\dawn\test\tint\Shader@0x00000147A2EDE4A0(2,10-18): error X3000: syntax error: unexpected token 'float16_t'
+
diff --git a/test/tint/builtins/gen/literal/saturate/dcde71.wgsl.expected.fxc.hlsl b/test/tint/builtins/gen/literal/saturate/dcde71.wgsl.expected.fxc.hlsl
index f7a8be78bb..548bc74dfa 100644
--- a/test/tint/builtins/gen/literal/saturate/dcde71.wgsl.expected.fxc.hlsl
+++ b/test/tint/builtins/gen/literal/saturate/dcde71.wgsl.expected.fxc.hlsl
@@ -1,4 +1,4 @@
-SKIP: FAILED - f16 not supported with FXC
+SKIP: FAILED
 
 void saturate_dcde71() {
   vector<float16_t, 4> res = saturate((float16_t(0.0h)).xxxx);
@@ -30,3 +30,6 @@ void compute_main() {
   saturate_dcde71();
   return;
 }
+FXC validation failure:
+C:\src\dawn\test\tint\Shader@0x000002580D780150(2,10-18): error X3000: syntax error: unexpected token 'float16_t'
+
diff --git a/test/tint/builtins/gen/literal/saturate/e8df56.wgsl.expected.fxc.hlsl b/test/tint/builtins/gen/literal/saturate/e8df56.wgsl.expected.fxc.hlsl
index 1f09eefd4e..8bc21b2342 100644
--- a/test/tint/builtins/gen/literal/saturate/e8df56.wgsl.expected.fxc.hlsl
+++ b/test/tint/builtins/gen/literal/saturate/e8df56.wgsl.expected.fxc.hlsl
@@ -1,4 +1,4 @@
-SKIP: FAILED - f16 not supported with FXC
+SKIP: FAILED
 
 void saturate_e8df56() {
   float16_t res = saturate(float16_t(0.0h));
@@ -30,3 +30,7 @@ void compute_main() {
   saturate_e8df56();
   return;
 }
+FXC validation failure:
+C:\src\dawn\test\tint\Shader@0x0000020A83F5F990(2,3-11): error X3000: unrecognized identifier 'float16_t'
+C:\src\dawn\test\tint\Shader@0x0000020A83F5F990(2,13-15): error X3000: unrecognized identifier 'res'
+
diff --git a/test/tint/builtins/gen/var/saturate/462535.wgsl.expected.fxc.hlsl b/test/tint/builtins/gen/var/saturate/462535.wgsl.expected.fxc.hlsl
index 18f8f61c7b..7a4deca624 100644
--- a/test/tint/builtins/gen/var/saturate/462535.wgsl.expected.fxc.hlsl
+++ b/test/tint/builtins/gen/var/saturate/462535.wgsl.expected.fxc.hlsl
@@ -1,4 +1,4 @@
-SKIP: FAILED - f16 not supported with FXC
+SKIP: FAILED
 
 void saturate_462535() {
   vector<float16_t, 3> arg_0 = (float16_t(0.0h)).xxx;
@@ -31,3 +31,7 @@ void compute_main() {
   saturate_462535();
   return;
 }
+FXC validation failure:
+C:\src\dawn\test\tint\Shader@0x000001DC3F306920(2,10-18): error X3000: syntax error: unexpected token 'float16_t'
+C:\src\dawn\test\tint\Shader@0x000001DC3F306920(3,10-18): error X3000: syntax error: unexpected token 'float16_t'
+
diff --git a/test/tint/builtins/gen/var/saturate/cd2028.wgsl.expected.fxc.hlsl b/test/tint/builtins/gen/var/saturate/cd2028.wgsl.expected.fxc.hlsl
index 71204cd52d..314bc8aa3c 100644
--- a/test/tint/builtins/gen/var/saturate/cd2028.wgsl.expected.fxc.hlsl
+++ b/test/tint/builtins/gen/var/saturate/cd2028.wgsl.expected.fxc.hlsl
@@ -1,4 +1,4 @@
-SKIP: FAILED - f16 not supported with FXC
+SKIP: FAILED
 
 void saturate_cd2028() {
   vector<float16_t, 2> arg_0 = (float16_t(0.0h)).xx;
@@ -31,3 +31,7 @@ void compute_main() {
   saturate_cd2028();
   return;
 }
+FXC validation failure:
+C:\src\dawn\test\tint\Shader@0x00000112C07589F0(2,10-18): error X3000: syntax error: unexpected token 'float16_t'
+C:\src\dawn\test\tint\Shader@0x00000112C07589F0(3,10-18): error X3000: syntax error: unexpected token 'float16_t'
+
diff --git a/test/tint/builtins/gen/var/saturate/dcde71.wgsl.expected.fxc.hlsl b/test/tint/builtins/gen/var/saturate/dcde71.wgsl.expected.fxc.hlsl
index 63af37a0ff..75dd7782da 100644
--- a/test/tint/builtins/gen/var/saturate/dcde71.wgsl.expected.fxc.hlsl
+++ b/test/tint/builtins/gen/var/saturate/dcde71.wgsl.expected.fxc.hlsl
@@ -1,4 +1,4 @@
-SKIP: FAILED - f16 not supported with FXC
+SKIP: FAILED
 
 void saturate_dcde71() {
   vector<float16_t, 4> arg_0 = (float16_t(0.0h)).xxxx;
@@ -31,3 +31,7 @@ void compute_main() {
   saturate_dcde71();
   return;
 }
+FXC validation failure:
+C:\src\dawn\test\tint\Shader@0x0000023B2F7F4970(2,10-18): error X3000: syntax error: unexpected token 'float16_t'
+C:\src\dawn\test\tint\Shader@0x0000023B2F7F4970(3,10-18): error X3000: syntax error: unexpected token 'float16_t'
+
diff --git a/test/tint/builtins/gen/var/saturate/e8df56.wgsl.expected.fxc.hlsl b/test/tint/builtins/gen/var/saturate/e8df56.wgsl.expected.fxc.hlsl
index 2ddd244d5f..3a649ba4e9 100644
--- a/test/tint/builtins/gen/var/saturate/e8df56.wgsl.expected.fxc.hlsl
+++ b/test/tint/builtins/gen/var/saturate/e8df56.wgsl.expected.fxc.hlsl
@@ -1,4 +1,4 @@
-SKIP: FAILED - f16 not supported with FXC
+SKIP: FAILED
 
 void saturate_e8df56() {
   float16_t arg_0 = float16_t(0.0h);
@@ -31,3 +31,7 @@ void compute_main() {
   saturate_e8df56();
   return;
 }
+FXC validation failure:
+C:\src\dawn\test\tint\Shader@0x000001DB75B70300(2,3-11): error X3000: unrecognized identifier 'float16_t'
+C:\src\dawn\test\tint\Shader@0x000001DB75B70300(2,13-17): error X3000: unrecognized identifier 'arg_0'
+