From f9582c8aa57b341d7d19058c55a569bbbd70bd36 Mon Sep 17 00:00:00 2001 From: Stephen White Date: Tue, 26 Jan 2021 13:05:14 +0000 Subject: [PATCH] Skip failing TextureFormat tests on SwANGLE. Same underlying failure as SwiftShader. Bug: dawn:580 dawn:147 Change-Id: I57c88ce6afaf7014f3cd4487b04ddab93b248d15 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/38783 Reviewed-by: Austin Eng Reviewed-by: Corentin Wallez Commit-Queue: Stephen White --- src/tests/end2end/TextureFormatTests.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/tests/end2end/TextureFormatTests.cpp b/src/tests/end2end/TextureFormatTests.cpp index baa05bb5a7..8bbd5d071f 100644 --- a/src/tests/end2end/TextureFormatTests.cpp +++ b/src/tests/end2end/TextureFormatTests.cpp @@ -597,7 +597,7 @@ TEST_P(TextureFormatTest, RGBA32Float) { TEST_P(TextureFormatTest, R16Float) { // TODO(https://crbug.com/swiftshader/147) Rendering INFINITY isn't handled correctly by // swiftshader - DAWN_SKIP_TEST_IF(IsVulkan() && IsSwiftshader()); + DAWN_SKIP_TEST_IF(IsVulkan() && IsSwiftshader() || IsANGLE()); DoFloat16Test({wgpu::TextureFormat::R16Float, 2, wgpu::TextureComponentType::Float, 1}); } @@ -606,7 +606,7 @@ TEST_P(TextureFormatTest, R16Float) { TEST_P(TextureFormatTest, RG16Float) { // TODO(https://crbug.com/swiftshader/147) Rendering INFINITY isn't handled correctly by // swiftshader - DAWN_SKIP_TEST_IF(IsVulkan() && IsSwiftshader()); + DAWN_SKIP_TEST_IF(IsVulkan() && IsSwiftshader() || IsANGLE()); DoFloat16Test({wgpu::TextureFormat::RG16Float, 4, wgpu::TextureComponentType::Float, 2}); } @@ -615,7 +615,7 @@ TEST_P(TextureFormatTest, RG16Float) { TEST_P(TextureFormatTest, RGBA16Float) { // TODO(https://crbug.com/swiftshader/147) Rendering INFINITY isn't handled correctly by // swiftshader - DAWN_SKIP_TEST_IF(IsVulkan() && IsSwiftshader()); + DAWN_SKIP_TEST_IF(IsVulkan() && IsSwiftshader() || IsANGLE()); DoFloat16Test({wgpu::TextureFormat::RGBA16Float, 8, wgpu::TextureComponentType::Float, 4}); }