From f995e4adc10ca303411a945c7a78477711af04c6 Mon Sep 17 00:00:00 2001 From: Stephen White Date: Tue, 1 Dec 2020 18:33:27 +0000 Subject: [PATCH] Enable BufferTests on OpenGL ES. Skip those which currently do not pass (same as GL backend). BUG=dawn:580 Change-Id: Id307cfb998c981d65621eb98761c22d73e5b0f81 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/34403 Reviewed-by: Austin Eng Reviewed-by: Corentin Wallez Commit-Queue: Stephen White --- src/tests/end2end/BufferTests.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/tests/end2end/BufferTests.cpp b/src/tests/end2end/BufferTests.cpp index 5b084fb9b7..dfbb7db2f3 100644 --- a/src/tests/end2end/BufferTests.cpp +++ b/src/tests/end2end/BufferTests.cpp @@ -707,6 +707,7 @@ TEST_P(BufferTests, ZeroSizedBuffer) { TEST_P(BufferTests, CreateBufferOOM) { // TODO(http://crbug.com/dawn/27): Missing support. DAWN_SKIP_TEST_IF(IsOpenGL()); + DAWN_SKIP_TEST_IF(IsOpenGLES()); DAWN_SKIP_TEST_IF(IsAsan()); wgpu::BufferDescriptor descriptor; @@ -724,6 +725,7 @@ TEST_P(BufferTests, CreateBufferOOM) { TEST_P(BufferTests, BufferMappedAtCreationOOM) { // TODO(http://crbug.com/dawn/27): Missing support. DAWN_SKIP_TEST_IF(IsOpenGL()); + DAWN_SKIP_TEST_IF(IsOpenGLES()); DAWN_SKIP_TEST_IF(IsAsan()); // TODO(http://crbug.com/dawn/579): PartitionAlloc raises an exception on OOM even with @@ -773,6 +775,7 @@ TEST_P(BufferTests, BufferMappedAtCreationOOM) { TEST_P(BufferTests, CreateBufferOOMMapAsync) { // TODO(http://crbug.com/dawn/27): Missing support. DAWN_SKIP_TEST_IF(IsOpenGL()); + DAWN_SKIP_TEST_IF(IsOpenGLES()); DAWN_SKIP_TEST_IF(IsAsan()); auto RunTest = [this](const wgpu::BufferDescriptor& descriptor) { @@ -809,4 +812,5 @@ DAWN_INSTANTIATE_TEST(BufferTests, D3D12Backend(), MetalBackend(), OpenGLBackend(), + OpenGLESBackend(), VulkanBackend());