From fbaa306056c1c98e7fdc5c09c1ed8bf147bd768c Mon Sep 17 00:00:00 2001 From: Stephen White Date: Mon, 1 Feb 2021 19:17:28 +0000 Subject: [PATCH] Skip OpArrayLengthTest.Vertex on ANGLE. Bug: dawn:197 dawn:447 Change-Id: I75e13530d6568e03df97b032517c3fe56d84f0fe Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/39941 Reviewed-by: Corentin Wallez Reviewed-by: Austin Eng Commit-Queue: Stephen White --- src/tests/end2end/OpArrayLengthTests.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/tests/end2end/OpArrayLengthTests.cpp b/src/tests/end2end/OpArrayLengthTests.cpp index 198d21df2b..f753d095cd 100644 --- a/src/tests/end2end/OpArrayLengthTests.cpp +++ b/src/tests/end2end/OpArrayLengthTests.cpp @@ -209,10 +209,10 @@ TEST_P(OpArrayLengthTest, Fragment) { // Test OpArrayLength in the vertex stage TEST_P(OpArrayLengthTest, Vertex) { // TODO(cwallez@chromium.org): The computations for length() of unsized buffer is broken on - // Nvidia OpenGL. See https://bugs.chromium.org/p/dawn/issues/detail?id=197 + // Nvidia OpenGL. Also failing on SwANGLE. See + // https://bugs.chromium.org/p/dawn/issues/detail?id=197 DAWN_SKIP_TEST_IF(IsNvidia() && IsOpenGL()); - DAWN_SKIP_TEST_IF(IsNvidia() && IsOpenGLES()); - + DAWN_SKIP_TEST_IF(IsNvidia() && IsOpenGLES() || IsANGLE()); // TODO(crbug.com/dawn/657): Returned data is slightly incorrect in this case. DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator") && IsIntel() && IsOpenGL());