From fbf7092ab3b6ee3a4791ff9f6e216a5c31b20019 Mon Sep 17 00:00:00 2001 From: Corentin Wallez Date: Thu, 11 Apr 2019 18:30:54 +0000 Subject: [PATCH] PushConstantsTest: Don't use additive blending One of the test was doing additive blending with a render target that was uninitialized causing flaky failure. This additive blending was useful when we had multi-pass render passes but isn't anymore. BUG=dawn:133 Change-Id: I0aef3dc31e98dbc51c267dc1e481429930162a93 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6540 Reviewed-by: Corentin Wallez Reviewed-by: Austin Eng Reviewed-by: Kai Ninomiya Commit-Queue: Kai Ninomiya --- src/tests/end2end/PushConstantTests.cpp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/tests/end2end/PushConstantTests.cpp b/src/tests/end2end/PushConstantTests.cpp index e385a17c1e..0bd371c366 100644 --- a/src/tests/end2end/PushConstantTests.cpp +++ b/src/tests/end2end/PushConstantTests.cpp @@ -195,13 +195,6 @@ class PushConstantTest: public DawnTest { descriptor.cFragmentStage.module = fsModule; descriptor.primitiveTopology = dawn::PrimitiveTopology::PointList; - dawn::BlendDescriptor blend; - blend.operation = dawn::BlendOperation::Add; - blend.srcFactor = dawn::BlendFactor::One; - blend.dstFactor = dawn::BlendFactor::One; - descriptor.cColorStates[0]->alphaBlend = blend; - descriptor.cColorStates[0]->colorBlend = blend; - return device.CreateRenderPipeline(&descriptor); } };