From fc47fbfaf3d128399b138e0584e91f1bea2a8b10 Mon Sep 17 00:00:00 2001 From: Antonio Maiorano Date: Wed, 7 Apr 2021 15:31:11 +0000 Subject: [PATCH] Disable BindGroupTests for D3D12 + tint regardless of backend validation Bug: tint:681 Change-Id: Icfc928d8f3ad92d48786d8a67ffbb4b7ae5febf0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/47020 Reviewed-by: Corentin Wallez Commit-Queue: Antonio Maiorano --- src/tests/end2end/BindGroupTests.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/tests/end2end/BindGroupTests.cpp b/src/tests/end2end/BindGroupTests.cpp index 2e84df1e1f..7d222bcdc0 100644 --- a/src/tests/end2end/BindGroupTests.cpp +++ b/src/tests/end2end/BindGroupTests.cpp @@ -155,9 +155,8 @@ TEST_P(BindGroupTests, ReusedBindGroupSingleSubmit) { // It contains a transformation matrix for the VS and the fragment color for the FS. // These must result in different register offsets in the native APIs. TEST_P(BindGroupTests, ReusedUBO) { - // TODO(crbug.com/tint/681): Validation fails for D3D12 with use_tint_generator - DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator") && - IsBackendValidationEnabled()); + // TODO(crbug.com/tint/681): Fails for D3D12 with use_tint_generator + DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator")); utils::BasicRenderPass renderPass = utils::CreateBasicRenderPass(device, kRTSize, kRTSize); @@ -243,9 +242,8 @@ TEST_P(BindGroupTests, ReusedUBO) { // shader. In D3D12 for example, these different types of bindings end up in different namespaces, // but the register offsets used must match between the shader module and descriptor range. TEST_P(BindGroupTests, UBOSamplerAndTexture) { - // TODO(crbug.com/tint/681): Validation fails for D3D12 with use_tint_generator - DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator") && - IsBackendValidationEnabled()); + // TODO(crbug.com/tint/681): Fails for D3D12 with use_tint_generator + DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator")); utils::BasicRenderPass renderPass = utils::CreateBasicRenderPass(device, kRTSize, kRTSize);