From fd64b10b0d3bc3ee376918a23e33d1baa9f61e0f Mon Sep 17 00:00:00 2001 From: dan sinclair Date: Mon, 11 Apr 2022 14:25:11 +0000 Subject: [PATCH] Fixup readability/braces lint warning. This CL removes some trailing ;'s which aren't needed to enables the readability/braces warning. Bug: dawn:1339 Change-Id: I776267b4282b1345e6b4258d1aff3d7de9fecb8a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86210 Reviewed-by: Corentin Wallez Reviewed-by: Ben Clayton Commit-Queue: Dan Sinclair Auto-Submit: Dan Sinclair --- src/dawn/CPPLINT.cfg | 1 - src/dawn/node/binding/AsyncRunner.h | 2 +- src/dawn/node/binding/GPUDevice.cpp | 4 ++-- src/dawn/node/binding/GPUTextureView.cpp | 2 +- src/dawn/node/interop/Core.h | 6 +++--- 5 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/dawn/CPPLINT.cfg b/src/dawn/CPPLINT.cfg index d2c79b20eb..b172426856 100644 --- a/src/dawn/CPPLINT.cfg +++ b/src/dawn/CPPLINT.cfg @@ -4,7 +4,6 @@ filter=-build/include_order filter=-build/include_what_you_use filter=-build/namespaces filter=-legal/copyright -filter=-readability/braces filter=-readability/casting filter=-readability/inheritance filter=-readability/namespace diff --git a/src/dawn/node/binding/AsyncRunner.h b/src/dawn/node/binding/AsyncRunner.h index 9ed6e5c5e0..9b1fcf496d 100644 --- a/src/dawn/node/binding/AsyncRunner.h +++ b/src/dawn/node/binding/AsyncRunner.h @@ -58,7 +58,7 @@ namespace wgpu::binding { // Calls AsyncRunner::Begin() inline AsyncTask(std::shared_ptr runner) : runner_(std::move(runner)) { runner_->Begin(); - }; + } // Destructor. // Calls AsyncRunner::End() diff --git a/src/dawn/node/binding/GPUDevice.cpp b/src/dawn/node/binding/GPUDevice.cpp index 8175c319c5..05546948e5 100644 --- a/src/dawn/node/binding/GPUDevice.cpp +++ b/src/dawn/node/binding/GPUDevice.cpp @@ -487,11 +487,11 @@ namespace wgpu::binding { std::variant GPUDevice::getLabel(Napi::Env) { UNIMPLEMENTED(); - }; + } void GPUDevice::setLabel(Napi::Env, std::variant value) { UNIMPLEMENTED(); - }; + } interop::Interface GPUDevice::getOnuncapturederror(Napi::Env) { // TODO(dawn:1348): Implement support for the "unhandlederror" event. diff --git a/src/dawn/node/binding/GPUTextureView.cpp b/src/dawn/node/binding/GPUTextureView.cpp index 7998f6c03a..43c88f1f30 100644 --- a/src/dawn/node/binding/GPUTextureView.cpp +++ b/src/dawn/node/binding/GPUTextureView.cpp @@ -31,6 +31,6 @@ namespace wgpu::binding { void GPUTextureView::setLabel(Napi::Env, std::variant value) { UNIMPLEMENTED(); - }; + } } // namespace wgpu::binding diff --git a/src/dawn/node/interop/Core.h b/src/dawn/node/interop/Core.h index 49ebb40263..b3bda97d67 100644 --- a/src/dawn/node/interop/Core.h +++ b/src/dawn/node/interop/Core.h @@ -340,7 +340,7 @@ namespace wgpu::interop { return Success; } return Error("value is not a ArrayBuffer"); - }; + } static inline Napi::Value ToJS(Napi::Env, ArrayBuffer value) { return value; } @@ -355,7 +355,7 @@ namespace wgpu::interop { return Success; } return Error("value is not a TypedArray"); - }; + } static inline Napi::Value ToJS(Napi::Env, ArrayBuffer value) { return value; } @@ -391,7 +391,7 @@ namespace wgpu::interop { return Error("value is not a TypedArray of the correct element type"); } return Error("value is not a TypedArray"); - }; + } static inline Napi::Value ToJS(Napi::Env, ArrayBuffer value) { return value; }