From ff2d2d808ed3d672222cedc831463a469e98a613 Mon Sep 17 00:00:00 2001 From: Austin Eng Date: Thu, 23 Jun 2022 21:26:18 +0000 Subject: [PATCH] Suppress running dawn_end2end_tests on Windows Intel Vulkan This configuration is very flaky, so suppress it to remove flakiness from CQ. We don't expose Vulkan on Windows for WebGPU so we're not losing test coverage for WebGPU. We'll want to fix and re-enable this for Dawn Native in the future. Bug: chromium:1338622, dawn:1392 Change-Id: I67f8472a5f6256107419de05d6f7420a75761331 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94640 Reviewed-by: Loko Kung Reviewed-by: Shrek Shao Commit-Queue: Austin Eng Kokoro: Kokoro --- src/dawn/tests/DawnTest.cpp | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/dawn/tests/DawnTest.cpp b/src/dawn/tests/DawnTest.cpp index 49386e8125..dfd2c54bf4 100644 --- a/src/dawn/tests/DawnTest.cpp +++ b/src/dawn/tests/DawnTest.cpp @@ -551,6 +551,16 @@ void DawnTestEnvironment::SelectPreferredAdapterProperties(const dawn::native::I (properties.backendType == wgpu::BackendType::Null); } +#if DAWN_PLATFORM_IS(WINDOWS) + if (selected && !mRunSuppressedTests && + properties.backendType == wgpu::BackendType::Vulkan && + gpu_info::IsIntel(properties.vendorID)) { + dawn::WarningLog() + << "Deselecting Windows Intel Vulkan adapter. See https://crbug.com/1338622."; + selected &= false; + } +#endif + // In Windows Remote Desktop sessions we may be able to discover multiple adapters that // have the same name and backend type. We will just choose one adapter from them in our // tests.