// Copyright 2020 The Dawn Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. #include #include "dawn/tests/unittests/validation/DeprecatedAPITests.h" #include "dawn/common/Constants.h" #include "dawn/utils/ComboRenderPipelineDescriptor.h" #include "dawn/utils/WGPUHelpers.h" WGPUDevice DeprecationTests::CreateTestDevice(dawn::native::Adapter dawnAdapter) { wgpu::DeviceDescriptor descriptor = {}; wgpu::DawnTogglesDescriptor deviceTogglesDesc = {}; const char* enabledToggles[1] = {kDisallowDeprecatedAPIsToggleName}; deviceTogglesDesc.enabledToggles = enabledToggles; deviceTogglesDesc.enabledTogglesCount = 1; if (GetParam()) { descriptor.nextInChain = &deviceTogglesDesc; } return dawnAdapter.CreateDevice(&descriptor); } // Test that setting attachment rather than view for render pass color and depth/stencil attachments // is deprecated. TEST_P(DeprecationTests, ReadOnlyDepthStencilStoreLoadOpsAttachment) { utils::BasicRenderPass renderPass = utils::CreateBasicRenderPass(device, 1, 1); wgpu::RenderPassEncoder pass; // Check that setting load/store ops with read only depth/stencil attachments gives a warning. wgpu::TextureDescriptor descriptor; descriptor.dimension = wgpu::TextureDimension::e2D; descriptor.size = {1, 1, 1}; descriptor.sampleCount = 1; descriptor.format = wgpu::TextureFormat::Depth24PlusStencil8; descriptor.mipLevelCount = 1; descriptor.usage = wgpu::TextureUsage::RenderAttachment; wgpu::Texture depthStencil = device.CreateTexture(&descriptor); wgpu::RenderPassDepthStencilAttachment* depthAttachment = &renderPass.renderPassInfo.cDepthStencilAttachmentInfo; renderPass.renderPassInfo.depthStencilAttachment = depthAttachment; depthAttachment->view = depthStencil.CreateView(); depthAttachment->depthReadOnly = true; depthAttachment->stencilReadOnly = true; depthAttachment->depthLoadOp = wgpu::LoadOp::Load; depthAttachment->depthStoreOp = wgpu::StoreOp::Store; depthAttachment->stencilLoadOp = wgpu::LoadOp::Undefined; depthAttachment->stencilStoreOp = wgpu::StoreOp::Undefined; { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); EXPECT_DEPRECATION_WARNING_ONLY(pass = encoder.BeginRenderPass(&renderPass.renderPassInfo)); pass.End(); EXPECT_DEPRECATION_ERROR_ONLY(encoder.Finish();); } depthAttachment->depthLoadOp = wgpu::LoadOp::Undefined; depthAttachment->depthStoreOp = wgpu::StoreOp::Undefined; depthAttachment->stencilLoadOp = wgpu::LoadOp::Load; depthAttachment->stencilStoreOp = wgpu::StoreOp::Store; { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); EXPECT_DEPRECATION_WARNING_ONLY(pass = encoder.BeginRenderPass(&renderPass.renderPassInfo)); pass.End(); EXPECT_DEPRECATION_ERROR_ONLY(encoder.Finish();); } } // Test that endPass() is deprecated for both render and compute passes. TEST_P(DeprecationTests, EndPass) { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); { utils::BasicRenderPass renderPass = utils::CreateBasicRenderPass(device, 1, 1); wgpu::RenderPassEncoder pass = encoder.BeginRenderPass(&renderPass.renderPassInfo); EXPECT_DEPRECATION_ERROR_OR_WARNING(pass.EndPass()); } { wgpu::ComputePassEncoder pass = encoder.BeginComputePass(); EXPECT_DEPRECATION_ERROR_OR_WARNING(pass.EndPass()); } } // Test that dispatch() and dispatchIndirect() is deprecated. TEST_P(DeprecationTests, Dispatch) { wgpu::ShaderModule module = utils::CreateShaderModule(device, R"( @compute @workgroup_size(1, 1, 1) fn main() { })"); wgpu::ComputePipelineDescriptor csDesc; csDesc.compute.module = module; csDesc.compute.entryPoint = "main"; wgpu::ComputePipeline pipeline = device.CreateComputePipeline(&csDesc); std::array indirectBufferData = {1, 0, 0}; wgpu::Buffer indirectBuffer = utils::CreateBufferFromData( device, &indirectBufferData[0], indirectBufferData.size() * sizeof(uint32_t), wgpu::BufferUsage::Indirect); wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::ComputePassEncoder pass = encoder.BeginComputePass(); pass.SetPipeline(pipeline); EXPECT_DEPRECATION_ERROR_OR_WARNING(pass.Dispatch(1)); EXPECT_DEPRECATION_ERROR_OR_WARNING(pass.DispatchIndirect(indirectBuffer, 0)); pass.End(); } // Test that creating a buffer with size exceeding the maximum buffer size limit should emits a // warning. (dawn:1525) TEST_P(DeprecationTests, MaxBufferSizeValidation) { wgpu::BufferDescriptor descriptor; descriptor.usage = wgpu::BufferUsage::CopySrc | wgpu::BufferUsage::CopyDst; descriptor.size = 256; device.CreateBuffer(&descriptor); descriptor.size = GetSupportedLimits().limits.maxBufferSize; device.CreateBuffer(&descriptor); descriptor.size = GetSupportedLimits().limits.maxBufferSize + 1; EXPECT_DEPRECATION_ERROR_OR_WARNING(device.CreateBuffer(&descriptor)); } // Test that multisampled texture with sampleType == float should be deprecated. TEST_P(DeprecationTests, MultisampledTextureSampleType) { EXPECT_DEPRECATION_ERROR_OR_WARNING(utils::MakeBindGroupLayout( device, { {0, wgpu::ShaderStage::Compute, wgpu::TextureSampleType::Float, wgpu::TextureViewDimension::e2D, true}, })); } INSTANTIATE_TEST_SUITE_P(DeprecatedAPITest, DeprecationTests, testing::Values(true, false), [](const testing::TestParamInfo& info) { return info.param ? "Disallowed" : "Allowed"; });