// Copyright 2018 The Dawn Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. #include "tests/unittests/validation/ValidationTest.h" namespace { class TextureViewValidationTest : public ValidationTest { }; constexpr uint32_t kWidth = 32u; constexpr uint32_t kHeight = 32u; constexpr uint32_t kDefaultMipLevels = 6u; constexpr wgpu::TextureFormat kDefaultTextureFormat = wgpu::TextureFormat::RGBA8Unorm; wgpu::Texture Create2DArrayTexture(wgpu::Device& device, uint32_t arrayLayerCount, uint32_t width = kWidth, uint32_t height = kHeight, uint32_t mipLevelCount = kDefaultMipLevels, uint32_t sampleCount = 1) { wgpu::TextureDescriptor descriptor; descriptor.dimension = wgpu::TextureDimension::e2D; descriptor.size.width = width; descriptor.size.height = height; descriptor.size.depth = arrayLayerCount; descriptor.sampleCount = sampleCount; descriptor.format = kDefaultTextureFormat; descriptor.mipLevelCount = mipLevelCount; descriptor.usage = wgpu::TextureUsage::Sampled; return device.CreateTexture(&descriptor); } wgpu::TextureViewDescriptor CreateDefaultViewDescriptor(wgpu::TextureViewDimension dimension) { wgpu::TextureViewDescriptor descriptor; descriptor.format = kDefaultTextureFormat; descriptor.dimension = dimension; descriptor.baseMipLevel = 0; descriptor.mipLevelCount = kDefaultMipLevels; descriptor.baseArrayLayer = 0; descriptor.arrayLayerCount = 1; return descriptor; } // Test creating texture view on a 2D non-array texture TEST_F(TextureViewValidationTest, CreateTextureViewOnTexture2D) { wgpu::Texture texture = Create2DArrayTexture(device, 1); wgpu::TextureViewDescriptor base2DTextureViewDescriptor = CreateDefaultViewDescriptor(wgpu::TextureViewDimension::e2D); // It is OK to create a 2D texture view on a 2D texture. { wgpu::TextureViewDescriptor descriptor = base2DTextureViewDescriptor; descriptor.arrayLayerCount = 1; texture.CreateView(&descriptor); } // It is an error to view a layer past the end of the texture. { wgpu::TextureViewDescriptor descriptor = base2DTextureViewDescriptor; descriptor.arrayLayerCount = 2; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); } // It is OK to create a 1-layer 2D array texture view on a 2D texture. { wgpu::TextureViewDescriptor descriptor = base2DTextureViewDescriptor; descriptor.dimension = wgpu::TextureViewDimension::e2DArray; descriptor.arrayLayerCount = 1; texture.CreateView(&descriptor); } // baseMipLevel == k && mipLevelCount == 0 means to use levels k..end. { wgpu::TextureViewDescriptor descriptor = base2DTextureViewDescriptor; descriptor.mipLevelCount = 0; descriptor.baseMipLevel = 0; texture.CreateView(&descriptor); descriptor.baseMipLevel = 1; texture.CreateView(&descriptor); descriptor.baseMipLevel = kDefaultMipLevels - 1; texture.CreateView(&descriptor); descriptor.baseMipLevel = kDefaultMipLevels; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); } // It is an error to make the mip level out of range. { wgpu::TextureViewDescriptor descriptor = base2DTextureViewDescriptor; descriptor.baseMipLevel = 0; descriptor.mipLevelCount = kDefaultMipLevels + 1; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); descriptor.baseMipLevel = 1; descriptor.mipLevelCount = kDefaultMipLevels; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); descriptor.baseMipLevel = kDefaultMipLevels - 1; descriptor.mipLevelCount = 2; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); descriptor.baseMipLevel = kDefaultMipLevels; descriptor.mipLevelCount = 1; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); } } // Test creating texture view on a 2D array texture TEST_F(TextureViewValidationTest, CreateTextureViewOnTexture2DArray) { constexpr uint32_t kDefaultArrayLayers = 6; wgpu::Texture texture = Create2DArrayTexture(device, kDefaultArrayLayers); wgpu::TextureViewDescriptor base2DArrayTextureViewDescriptor = CreateDefaultViewDescriptor(wgpu::TextureViewDimension::e2DArray); // It is OK to create a 2D texture view on a 2D array texture. { wgpu::TextureViewDescriptor descriptor = base2DArrayTextureViewDescriptor; descriptor.dimension = wgpu::TextureViewDimension::e2D; descriptor.arrayLayerCount = 1; texture.CreateView(&descriptor); } // It is OK to create a 2D array texture view on a 2D array texture. { wgpu::TextureViewDescriptor descriptor = base2DArrayTextureViewDescriptor; descriptor.arrayLayerCount = kDefaultArrayLayers; texture.CreateView(&descriptor); } // baseArrayLayer == k && arrayLayerCount == 0 means to use layers k..end. { wgpu::TextureViewDescriptor descriptor = base2DArrayTextureViewDescriptor; descriptor.arrayLayerCount = 0; descriptor.baseArrayLayer = 0; texture.CreateView(&descriptor); descriptor.baseArrayLayer = 1; texture.CreateView(&descriptor); descriptor.baseArrayLayer = kDefaultArrayLayers - 1; texture.CreateView(&descriptor); descriptor.baseArrayLayer = kDefaultArrayLayers; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); } // It is an error for the array layer range of the view to exceed that of the texture. { wgpu::TextureViewDescriptor descriptor = base2DArrayTextureViewDescriptor; descriptor.baseArrayLayer = 0; descriptor.arrayLayerCount = kDefaultArrayLayers + 1; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); descriptor.baseArrayLayer = 1; descriptor.arrayLayerCount = kDefaultArrayLayers; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); descriptor.baseArrayLayer = kDefaultArrayLayers - 1; descriptor.arrayLayerCount = 2; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); descriptor.baseArrayLayer = kDefaultArrayLayers; descriptor.arrayLayerCount = 1; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); } } // Using the "none" ("default") values validates the same as explicitly // specifying the values they're supposed to default to. // Variant for a texture with more than 1 array layer. TEST_F(TextureViewValidationTest, TextureViewDescriptorDefaultsArray) { constexpr uint32_t kDefaultArrayLayers = 6; wgpu::Texture texture = Create2DArrayTexture(device, kDefaultArrayLayers); { texture.CreateView(); } { wgpu::TextureViewDescriptor descriptor; descriptor.format = wgpu::TextureFormat::Undefined; texture.CreateView(&descriptor); descriptor.format = wgpu::TextureFormat::RGBA8Unorm; texture.CreateView(&descriptor); descriptor.format = wgpu::TextureFormat::R8Unorm; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); } { wgpu::TextureViewDescriptor descriptor; descriptor.dimension = wgpu::TextureViewDimension::Undefined; texture.CreateView(&descriptor); descriptor.dimension = wgpu::TextureViewDimension::e2DArray; texture.CreateView(&descriptor); descriptor.dimension = wgpu::TextureViewDimension::e2D; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); } { wgpu::TextureViewDescriptor descriptor; // Setting array layers to non-0 means the dimensionality will // default to 2D so by itself it causes an error. descriptor.arrayLayerCount = kDefaultArrayLayers; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); descriptor.dimension = wgpu::TextureViewDimension::e2DArray; texture.CreateView(&descriptor); descriptor.mipLevelCount = kDefaultMipLevels; texture.CreateView(&descriptor); } } // Using the "none" ("default") values validates the same as explicitly // specifying the values they're supposed to default to. // Variant for a texture with only 1 array layer. TEST_F(TextureViewValidationTest, TextureViewDescriptorDefaultsNonArray) { constexpr uint32_t kDefaultArrayLayers = 1; wgpu::Texture texture = Create2DArrayTexture(device, kDefaultArrayLayers); { texture.CreateView(); } { wgpu::TextureViewDescriptor descriptor; descriptor.format = wgpu::TextureFormat::Undefined; texture.CreateView(&descriptor); descriptor.format = wgpu::TextureFormat::RGBA8Unorm; texture.CreateView(&descriptor); descriptor.format = wgpu::TextureFormat::R8Unorm; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); } { wgpu::TextureViewDescriptor descriptor; descriptor.dimension = wgpu::TextureViewDimension::Undefined; texture.CreateView(&descriptor); descriptor.dimension = wgpu::TextureViewDimension::e2D; texture.CreateView(&descriptor); descriptor.dimension = wgpu::TextureViewDimension::e2DArray; texture.CreateView(&descriptor); } { wgpu::TextureViewDescriptor descriptor; descriptor.arrayLayerCount = 0; texture.CreateView(&descriptor); descriptor.arrayLayerCount = 1; texture.CreateView(&descriptor); descriptor.arrayLayerCount = 2; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); } { wgpu::TextureViewDescriptor descriptor; descriptor.mipLevelCount = kDefaultMipLevels; texture.CreateView(&descriptor); descriptor.arrayLayerCount = kDefaultArrayLayers; texture.CreateView(&descriptor); } } // Test creating cube map texture view TEST_F(TextureViewValidationTest, CreateCubeMapTextureView) { constexpr uint32_t kDefaultArrayLayers = 16; wgpu::Texture texture = Create2DArrayTexture(device, kDefaultArrayLayers); wgpu::TextureViewDescriptor base2DArrayTextureViewDescriptor = CreateDefaultViewDescriptor(wgpu::TextureViewDimension::e2DArray); // It is OK to create a cube map texture view with arrayLayerCount == 6. { wgpu::TextureViewDescriptor descriptor = base2DArrayTextureViewDescriptor; descriptor.dimension = wgpu::TextureViewDimension::Cube; descriptor.arrayLayerCount = 6; texture.CreateView(&descriptor); } // It is an error to create a cube map texture view with arrayLayerCount != 6. { wgpu::TextureViewDescriptor descriptor = base2DArrayTextureViewDescriptor; descriptor.dimension = wgpu::TextureViewDimension::Cube; descriptor.arrayLayerCount = 3; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); } // It is OK to create a cube map array texture view with arrayLayerCount % 6 == 0. { wgpu::TextureViewDescriptor descriptor = base2DArrayTextureViewDescriptor; descriptor.dimension = wgpu::TextureViewDimension::CubeArray; descriptor.arrayLayerCount = 12; texture.CreateView(&descriptor); } // It is an error to create a cube map array texture view with arrayLayerCount % 6 != 0. { wgpu::TextureViewDescriptor descriptor = base2DArrayTextureViewDescriptor; descriptor.dimension = wgpu::TextureViewDimension::CubeArray; descriptor.arrayLayerCount = 11; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); } // It is an error to create a cube map texture view with width != height. { wgpu::Texture nonSquareTexture = Create2DArrayTexture(device, 18, 32, 16, 5); wgpu::TextureViewDescriptor descriptor = base2DArrayTextureViewDescriptor; descriptor.dimension = wgpu::TextureViewDimension::Cube; descriptor.arrayLayerCount = 6; ASSERT_DEVICE_ERROR(nonSquareTexture.CreateView(&descriptor)); } // It is an error to create a cube map array texture view with width != height. { wgpu::Texture nonSquareTexture = Create2DArrayTexture(device, 18, 32, 16, 5); wgpu::TextureViewDescriptor descriptor = base2DArrayTextureViewDescriptor; descriptor.dimension = wgpu::TextureViewDimension::CubeArray; descriptor.arrayLayerCount = 12; ASSERT_DEVICE_ERROR(nonSquareTexture.CreateView(&descriptor)); } } // Test the format compatibility rules when creating a texture view. // TODO(jiawei.shao@intel.com): add more tests when the rules are fully implemented. TEST_F(TextureViewValidationTest, TextureViewFormatCompatibility) { wgpu::Texture texture = Create2DArrayTexture(device, 1); wgpu::TextureViewDescriptor base2DTextureViewDescriptor = CreateDefaultViewDescriptor(wgpu::TextureViewDimension::e2D); // It is an error to create a texture view in depth-stencil format on a RGBA texture. { wgpu::TextureViewDescriptor descriptor = base2DTextureViewDescriptor; descriptor.format = wgpu::TextureFormat::Depth24PlusStencil8; ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); } } // Test that it's invalid to create a texture view from a destroyed texture TEST_F(TextureViewValidationTest, DestroyCreateTextureView) { wgpu::Texture texture = Create2DArrayTexture(device, 1); wgpu::TextureViewDescriptor descriptor = CreateDefaultViewDescriptor(wgpu::TextureViewDimension::e2D); texture.Destroy(); ASSERT_DEVICE_ERROR(texture.CreateView(&descriptor)); } // Test that only TextureAspect::All is supported TEST_F(TextureViewValidationTest, AspectMustBeAll) { wgpu::TextureDescriptor descriptor = {}; descriptor.size = {1, 1, 1}; descriptor.format = wgpu::TextureFormat::Depth32Float; descriptor.usage = wgpu::TextureUsage::Sampled | wgpu::TextureUsage::OutputAttachment; wgpu::Texture texture = device.CreateTexture(&descriptor); wgpu::TextureViewDescriptor viewDescriptor = {}; viewDescriptor.aspect = wgpu::TextureAspect::All; texture.CreateView(&viewDescriptor); viewDescriptor.aspect = wgpu::TextureAspect::DepthOnly; ASSERT_DEVICE_ERROR(texture.CreateView(&viewDescriptor)); } } // anonymous namespace