// Copyright 2017 The Dawn Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. #include #include "dawn_native/CommandEncoder.h" #include "tests/unittests/validation/ValidationTest.h" #include "utils/WGPUHelpers.h" using ::testing::HasSubstr; class CommandBufferValidationTest : public ValidationTest {}; // Test for an empty command buffer TEST_F(CommandBufferValidationTest, Empty) { device.CreateCommandEncoder().Finish(); } // Test that a command buffer cannot be ended mid render pass TEST_F(CommandBufferValidationTest, EndedMidRenderPass) { DummyRenderPass dummyRenderPass(device); // Control case, command buffer ended after the pass is ended. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::RenderPassEncoder pass = encoder.BeginRenderPass(&dummyRenderPass); pass.EndPass(); encoder.Finish(); } // Error case, command buffer ended mid-pass. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::RenderPassEncoder pass = encoder.BeginRenderPass(&dummyRenderPass); ASSERT_DEVICE_ERROR( encoder.Finish(), HasSubstr("Command buffer recording ended before [RenderPassEncoder] was ended.")); } // Error case, command buffer ended mid-pass. Trying to use encoders after Finish // should fail too. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::RenderPassEncoder pass = encoder.BeginRenderPass(&dummyRenderPass); ASSERT_DEVICE_ERROR( encoder.Finish(), HasSubstr("Command buffer recording ended before [RenderPassEncoder] was ended.")); ASSERT_DEVICE_ERROR( pass.EndPass(), HasSubstr("Recording in an error or already ended [RenderPassEncoder].")); } } // Test that a command buffer cannot be ended mid compute pass TEST_F(CommandBufferValidationTest, EndedMidComputePass) { // Control case, command buffer ended after the pass is ended. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::ComputePassEncoder pass = encoder.BeginComputePass(); pass.EndPass(); encoder.Finish(); } // Error case, command buffer ended mid-pass. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::ComputePassEncoder pass = encoder.BeginComputePass(); ASSERT_DEVICE_ERROR( encoder.Finish(), HasSubstr("Command buffer recording ended before [ComputePassEncoder] was ended.")); } // Error case, command buffer ended mid-pass. Trying to use encoders after Finish // should fail too. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::ComputePassEncoder pass = encoder.BeginComputePass(); ASSERT_DEVICE_ERROR( encoder.Finish(), HasSubstr("Command buffer recording ended before [ComputePassEncoder] was ended.")); ASSERT_DEVICE_ERROR( pass.EndPass(), HasSubstr("Recording in an error or already ended [ComputePassEncoder].")); } } // Test that a render pass cannot be ended twice TEST_F(CommandBufferValidationTest, RenderPassEndedTwice) { DummyRenderPass dummyRenderPass(device); // Control case, pass is ended once { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::RenderPassEncoder pass = encoder.BeginRenderPass(&dummyRenderPass); pass.EndPass(); encoder.Finish(); } // Error case, pass ended twice { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::RenderPassEncoder pass = encoder.BeginRenderPass(&dummyRenderPass); pass.EndPass(); pass.EndPass(); ASSERT_DEVICE_ERROR( encoder.Finish(), HasSubstr("Recording in an error or already ended [RenderPassEncoder].")); } } // Test that a compute pass cannot be ended twice TEST_F(CommandBufferValidationTest, ComputePassEndedTwice) { // Control case, pass is ended once. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::ComputePassEncoder pass = encoder.BeginComputePass(); pass.EndPass(); encoder.Finish(); } // Error case, pass ended twice { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::ComputePassEncoder pass = encoder.BeginComputePass(); pass.EndPass(); pass.EndPass(); ASSERT_DEVICE_ERROR( encoder.Finish(), HasSubstr("Recording in an error or already ended [ComputePassEncoder].")); } } // Test that beginning a compute pass before ending the previous pass causes an error. TEST_F(CommandBufferValidationTest, BeginComputePassBeforeEndPreviousPass) { DummyRenderPass dummyRenderPass(device); // Beginning a compute pass before ending a render pass causes an error. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::RenderPassEncoder renderPass = encoder.BeginRenderPass(&dummyRenderPass); wgpu::ComputePassEncoder computePass = encoder.BeginComputePass(); computePass.EndPass(); renderPass.EndPass(); ASSERT_DEVICE_ERROR(encoder.Finish()); } // Beginning a compute pass before ending a compute pass causes an error. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::ComputePassEncoder computePass1 = encoder.BeginComputePass(); wgpu::ComputePassEncoder computePass2 = encoder.BeginComputePass(); computePass2.EndPass(); computePass1.EndPass(); ASSERT_DEVICE_ERROR(encoder.Finish()); } } // Test that beginning a render pass before ending the previous pass causes an error. TEST_F(CommandBufferValidationTest, BeginRenderPassBeforeEndPreviousPass) { DummyRenderPass dummyRenderPass(device); // Beginning a render pass before ending the render pass causes an error. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::RenderPassEncoder renderPass1 = encoder.BeginRenderPass(&dummyRenderPass); wgpu::RenderPassEncoder renderPass2 = encoder.BeginRenderPass(&dummyRenderPass); renderPass2.EndPass(); renderPass1.EndPass(); ASSERT_DEVICE_ERROR(encoder.Finish()); } // Beginning a compute pass before ending a compute pass causes an error. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::ComputePassEncoder computePass = encoder.BeginComputePass(); wgpu::RenderPassEncoder renderPass = encoder.BeginRenderPass(&dummyRenderPass); renderPass.EndPass(); computePass.EndPass(); ASSERT_DEVICE_ERROR(encoder.Finish()); } } // Test that encoding command after a successful finish produces an error TEST_F(CommandBufferValidationTest, CallsAfterASuccessfulFinish) { // A buffer that can be used in CopyBufferToBuffer wgpu::BufferDescriptor copyBufferDesc; copyBufferDesc.size = 16; copyBufferDesc.usage = wgpu::BufferUsage::CopySrc | wgpu::BufferUsage::CopyDst; wgpu::Buffer copyBuffer = device.CreateBuffer(©BufferDesc); wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); encoder.Finish(); ASSERT_DEVICE_ERROR(encoder.CopyBufferToBuffer(copyBuffer, 0, copyBuffer, 0, 0)); } // Test that encoding command after a failed finish produces an error TEST_F(CommandBufferValidationTest, CallsAfterAFailedFinish) { // A buffer that can be used in CopyBufferToBuffer wgpu::BufferDescriptor copyBufferDesc; copyBufferDesc.size = 16; copyBufferDesc.usage = wgpu::BufferUsage::CopySrc | wgpu::BufferUsage::CopyDst; wgpu::Buffer copyBuffer = device.CreateBuffer(©BufferDesc); // A buffer that can't be used in CopyBufferToBuffer wgpu::BufferDescriptor bufferDesc; bufferDesc.size = 16; bufferDesc.usage = wgpu::BufferUsage::Uniform; wgpu::Buffer buffer = device.CreateBuffer(&bufferDesc); wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); encoder.CopyBufferToBuffer(buffer, 0, buffer, 0, 0); ASSERT_DEVICE_ERROR(encoder.Finish()); ASSERT_DEVICE_ERROR(encoder.CopyBufferToBuffer(copyBuffer, 0, copyBuffer, 0, 0)); } // Test that passes which are de-referenced prior to ending still allow the correct errors to be // produced. TEST_F(CommandBufferValidationTest, PassDereferenced) { DummyRenderPass dummyRenderPass(device); // Control case, command buffer ended after the pass is ended. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::RenderPassEncoder pass = encoder.BeginRenderPass(&dummyRenderPass); pass.EndPass(); encoder.Finish(); } // Error case, no reference is kept to a render pass. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); encoder.BeginRenderPass(&dummyRenderPass); ASSERT_DEVICE_ERROR( encoder.Finish(), HasSubstr("Command buffer recording ended before [RenderPassEncoder] was ended.")); } // Error case, no reference is kept to a compute pass. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); encoder.BeginComputePass(); ASSERT_DEVICE_ERROR( encoder.Finish(), HasSubstr("Command buffer recording ended before [ComputePassEncoder] was ended.")); } // Error case, beginning a new pass after failing to end a de-referenced pass. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); encoder.BeginRenderPass(&dummyRenderPass); wgpu::ComputePassEncoder pass = encoder.BeginComputePass(); pass.EndPass(); ASSERT_DEVICE_ERROR( encoder.Finish(), HasSubstr("Command buffer recording ended before [RenderPassEncoder] was ended.")); } // Error case, deleting the pass after finishing the command encoder shouldn't generate an // uncaptured error. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::ComputePassEncoder pass = encoder.BeginComputePass(); ASSERT_DEVICE_ERROR( encoder.Finish(), HasSubstr("Command buffer recording ended before [ComputePassEncoder] was ended.")); pass = nullptr; } // Valid case, command encoder is never finished so the de-referenced pass shouldn't // generate an uncaptured error. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); encoder.BeginComputePass(); } } // Test that calling inject validation error produces an error. TEST_F(CommandBufferValidationTest, InjectValidationError) { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); encoder.InjectValidationError("my error"); ASSERT_DEVICE_ERROR(encoder.Finish(), HasSubstr("my error")); } TEST_F(CommandBufferValidationTest, DestroyEncoder) { // Skip these tests if we are using wire because the destroy functionality is not exposed // and needs to use a cast to call manually. We cannot test this in the wire case since the // only way to trigger the destroy call is by losing all references which means we cannot // call finish. DAWN_SKIP_TEST_IF(UsesWire()); DummyRenderPass dummyRenderPass(device); // Control case, command buffer ended after the pass is ended. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::RenderPassEncoder pass = encoder.BeginRenderPass(&dummyRenderPass); pass.EndPass(); encoder.Finish(); } // Destroyed encoder with encoded commands should emit error on finish. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::RenderPassEncoder pass = encoder.BeginRenderPass(&dummyRenderPass); pass.EndPass(); dawn::native::FromAPI(encoder.Get())->Destroy(); ASSERT_DEVICE_ERROR(encoder.Finish(), HasSubstr("Destroyed encoder cannot be finished.")); } // Destroyed encoder with encoded commands shouldn't emit an error if never finished. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::RenderPassEncoder pass = encoder.BeginRenderPass(&dummyRenderPass); pass.EndPass(); dawn::native::FromAPI(encoder.Get())->Destroy(); } // Destroyed encoder should allow encoding, and emit error on finish. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); dawn::native::FromAPI(encoder.Get())->Destroy(); wgpu::RenderPassEncoder pass = encoder.BeginRenderPass(&dummyRenderPass); pass.EndPass(); ASSERT_DEVICE_ERROR(encoder.Finish(), HasSubstr("Destroyed encoder cannot be finished.")); } // Destroyed encoder should allow encoding and shouldn't emit an error if never finished. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); dawn::native::FromAPI(encoder.Get())->Destroy(); wgpu::RenderPassEncoder pass = encoder.BeginRenderPass(&dummyRenderPass); pass.EndPass(); } // Destroying a finished encoder should not emit any errors. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::RenderPassEncoder pass = encoder.BeginRenderPass(&dummyRenderPass); pass.EndPass(); encoder.Finish(); dawn::native::FromAPI(encoder.Get())->Destroy(); } // Destroying an encoder twice should not emit any errors. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); dawn::native::FromAPI(encoder.Get())->Destroy(); dawn::native::FromAPI(encoder.Get())->Destroy(); } // Destroying an encoder twice and then calling finish should fail. { wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); dawn::native::FromAPI(encoder.Get())->Destroy(); dawn::native::FromAPI(encoder.Get())->Destroy(); ASSERT_DEVICE_ERROR(encoder.Finish(), HasSubstr("Destroyed encoder cannot be finished.")); } }