// Copyright 2018 The Dawn Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. #include "common/Constants.h" #include "dawn_native/ShaderModule.h" #include "tests/unittests/validation/ValidationTest.h" #include "utils/WGPUHelpers.h" #include class ShaderModuleValidationTest : public ValidationTest {}; // Test case with a simpler shader that should successfully be created TEST_F(ShaderModuleValidationTest, CreationSuccess) { const char* shader = R"( OpCapability Shader %1 = OpExtInstImport "GLSL.std.450" OpMemoryModel Logical GLSL450 OpEntryPoint Fragment %main "main" %fragColor OpExecutionMode %main OriginUpperLeft OpSource GLSL 450 OpSourceExtension "GL_GOOGLE_cpp_style_line_directive" OpSourceExtension "GL_GOOGLE_include_directive" OpName %main "main" OpName %fragColor "fragColor" OpDecorate %fragColor Location 0 %void = OpTypeVoid %3 = OpTypeFunction %void %float = OpTypeFloat 32 %v4float = OpTypeVector %float 4 %_ptr_Output_v4float = OpTypePointer Output %v4float %fragColor = OpVariable %_ptr_Output_v4float Output %float_1 = OpConstant %float 1 %float_0 = OpConstant %float 0 %12 = OpConstantComposite %v4float %float_1 %float_0 %float_0 %float_1 %main = OpFunction %void None %3 %5 = OpLabel OpStore %fragColor %12 OpReturn OpFunctionEnd)"; utils::CreateShaderModuleFromASM(device, shader); } // Tests that if the output location exceeds kMaxColorAttachments the fragment shader will fail to // be compiled. TEST_F(ShaderModuleValidationTest, FragmentOutputLocationExceedsMaxColorAttachments) { std::ostringstream stream; stream << "[[stage(fragment)]] fn main() -> [[location(" << kMaxColorAttachments << R"()]] vec4 { return vec4(0.0, 1.0, 0.0, 1.0); })"; ASSERT_DEVICE_ERROR(utils::CreateShaderModule(device, stream.str().c_str())); } // Test that it is invalid to create a shader module with no chained descriptor. (It must be // WGSL or SPIRV, not empty) TEST_F(ShaderModuleValidationTest, NoChainedDescriptor) { wgpu::ShaderModuleDescriptor desc = {}; ASSERT_DEVICE_ERROR(device.CreateShaderModule(&desc)); } // Test that it is not allowed to use combined texture and sampler. TEST_F(ShaderModuleValidationTest, CombinedTextureAndSampler) { // SPIR-V ASM produced by glslang for the following fragment shader: // // #version 450 // layout(set = 0, binding = 0) uniform sampler2D tex; // void main () {} // // Note that the following defines an interface combined texture/sampler which is not allowed // in Dawn / WebGPU. // // %8 = OpTypeSampledImage %7 // %_ptr_UniformConstant_8 = OpTypePointer UniformConstant %8 // %tex = OpVariable %_ptr_UniformConstant_8 UniformConstant const char* shader = R"( OpCapability Shader %1 = OpExtInstImport "GLSL.std.450" OpMemoryModel Logical GLSL450 OpEntryPoint Fragment %main "main" OpExecutionMode %main OriginUpperLeft OpSource GLSL 450 OpName %main "main" OpName %tex "tex" OpDecorate %tex DescriptorSet 0 OpDecorate %tex Binding 0 %void = OpTypeVoid %3 = OpTypeFunction %void %float = OpTypeFloat 32 %7 = OpTypeImage %float 2D 0 0 0 1 Unknown %8 = OpTypeSampledImage %7 %_ptr_UniformConstant_8 = OpTypePointer UniformConstant %8 %tex = OpVariable %_ptr_UniformConstant_8 UniformConstant %main = OpFunction %void None %3 %5 = OpLabel OpReturn OpFunctionEnd )"; ASSERT_DEVICE_ERROR(utils::CreateShaderModuleFromASM(device, shader)); } // Test that it is not allowed to declare a multisampled-array interface texture. // TODO(enga): Also test multisampled cube, cube array, and 3D. These have no GLSL keywords. TEST_F(ShaderModuleValidationTest, MultisampledArrayTexture) { // SPIR-V ASM produced by glslang for the following fragment shader: // // #version 450 // layout(set=0, binding=0) uniform texture2DMSArray tex; // void main () {}} // // Note that the following defines an interface array multisampled texture which is not allowed // in Dawn / WebGPU. // // %7 = OpTypeImage %float 2D 0 1 1 1 Unknown // %_ptr_UniformConstant_7 = OpTypePointer UniformConstant %7 // %tex = OpVariable %_ptr_UniformConstant_7 UniformConstant const char* shader = R"( OpCapability Shader %1 = OpExtInstImport "GLSL.std.450" OpMemoryModel Logical GLSL450 OpEntryPoint Fragment %main "main" OpExecutionMode %main OriginUpperLeft OpSource GLSL 450 OpName %main "main" OpName %tex "tex" OpDecorate %tex DescriptorSet 0 OpDecorate %tex Binding 0 %void = OpTypeVoid %3 = OpTypeFunction %void %float = OpTypeFloat 32 %7 = OpTypeImage %float 2D 0 1 1 1 Unknown %_ptr_UniformConstant_7 = OpTypePointer UniformConstant %7 %tex = OpVariable %_ptr_UniformConstant_7 UniformConstant %main = OpFunction %void None %3 %5 = OpLabel OpReturn OpFunctionEnd )"; ASSERT_DEVICE_ERROR(utils::CreateShaderModuleFromASM(device, shader)); } // Tests that shader module compilation messages can be queried. TEST_F(ShaderModuleValidationTest, GetCompilationMessages) { // This test works assuming ShaderModule is backed by a dawn_native::ShaderModuleBase, which // is not the case on the wire. DAWN_SKIP_TEST_IF(UsesWire()); wgpu::ShaderModule shaderModule = utils::CreateShaderModule(device, R"( [[stage(fragment)]] fn main() -> [[location(0)]] vec4 { return vec4(0.0, 1.0, 0.0, 1.0); })"); dawn_native::ShaderModuleBase* shaderModuleBase = reinterpret_cast(shaderModule.Get()); dawn_native::OwnedCompilationMessages* messages = shaderModuleBase->GetCompilationMessages(); messages->ClearMessages(); messages->AddMessage("Info Message"); messages->AddMessage("Warning Message", wgpu::CompilationMessageType::Warning); messages->AddMessage("Error Message", wgpu::CompilationMessageType::Error, 3, 4); auto callback = [](WGPUCompilationInfoRequestStatus status, const WGPUCompilationInfo* info, void* userdata) { ASSERT_EQ(WGPUCompilationInfoRequestStatus_Success, status); ASSERT_NE(nullptr, info); ASSERT_EQ(3u, info->messageCount); const WGPUCompilationMessage* message = &info->messages[0]; ASSERT_STREQ("Info Message", message->message); ASSERT_EQ(WGPUCompilationMessageType_Info, message->type); ASSERT_EQ(0u, message->lineNum); ASSERT_EQ(0u, message->linePos); message = &info->messages[1]; ASSERT_STREQ("Warning Message", message->message); ASSERT_EQ(WGPUCompilationMessageType_Warning, message->type); ASSERT_EQ(0u, message->lineNum); ASSERT_EQ(0u, message->linePos); message = &info->messages[2]; ASSERT_STREQ("Error Message", message->message); ASSERT_EQ(WGPUCompilationMessageType_Error, message->type); ASSERT_EQ(3u, message->lineNum); ASSERT_EQ(4u, message->linePos); }; shaderModule.GetCompilationInfo(callback, nullptr); }