// Copyright 2020 The Tint Authors. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. #include "src/transform/bound_array_accessors.h" #include "src/transform/test_helper.h" namespace tint { namespace transform { namespace { using BoundArrayAccessorsTest = TransformTest; TEST_F(BoundArrayAccessorsTest, Ptrs_Clamp) { auto* src = R"( var a : array; let c : u32 = 1u; fn f() { let b : f32 = a[c]; } )"; auto* expect = R"( var a : array; let c : u32 = 1u; fn f() { let b : f32 = a[min(u32(c), 2u)]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Array_Idx_Nested_Scalar) { auto* src = R"( var a : array; var b : array; var i : u32; fn f() { var c : f32 = a[ b[i] ]; } )"; auto* expect = R"( var a : array; var b : array; var i : u32; fn f() { var c : f32 = a[min(u32(b[min(u32(i), 4u)]), 2u)]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Array_Idx_Scalar) { auto* src = R"( var a : array; fn f() { var b : f32 = a[1]; } )"; auto* expect = R"( var a : array; fn f() { var b : f32 = a[1]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Array_Idx_Expr) { auto* src = R"( var a : array; var c : i32; fn f() { var b : f32 = a[c + 2 - 3]; } )"; auto* expect = R"( var a : array; var c : i32; fn f() { var b : f32 = a[min(u32(((c + 2) - 3)), 2u)]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Array_Idx_Negative) { auto* src = R"( var a : array; fn f() { var b : f32 = a[-1]; } )"; auto* expect = R"( var a : array; fn f() { var b : f32 = a[0]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Array_Idx_OutOfBounds) { auto* src = R"( var a : array; fn f() { var b : f32 = a[3]; } )"; auto* expect = R"( var a : array; fn f() { var b : f32 = a[2]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Vector_Idx_Scalar) { auto* src = R"( var a : vec3; fn f() { var b : f32 = a[1]; } )"; auto* expect = R"( var a : vec3; fn f() { var b : f32 = a[1]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Vector_Idx_Expr) { auto* src = R"( var a : vec3; var c : i32; fn f() { var b : f32 = a[c + 2 - 3]; } )"; auto* expect = R"( var a : vec3; var c : i32; fn f() { var b : f32 = a[min(u32(((c + 2) - 3)), 2u)]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Vector_Swizzle_Idx_Scalar) { auto* src = R"( var a : vec3; fn f() { var b : f32 = a.xy[2]; } )"; auto* expect = R"( var a : vec3; fn f() { var b : f32 = a.xy[1]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Vector_Swizzle_Idx_Var) { auto* src = R"( var a : vec3; var c : i32; fn f() { var b : f32 = a.xy[c]; } )"; auto* expect = R"( var a : vec3; var c : i32; fn f() { var b : f32 = a.xy[min(u32(c), 1u)]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Vector_Swizzle_Idx_Expr) { auto* src = R"( var a : vec3; var c : i32; fn f() { var b : f32 = a.xy[c + 2 - 3]; } )"; auto* expect = R"( var a : vec3; var c : i32; fn f() { var b : f32 = a.xy[min(u32(((c + 2) - 3)), 1u)]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Vector_Idx_Negative) { auto* src = R"( var a : vec3; fn f() { var b : f32 = a[-1]; } )"; auto* expect = R"( var a : vec3; fn f() { var b : f32 = a[0]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Vector_Idx_OutOfBounds) { auto* src = R"( var a : vec3; fn f() { var b : f32 = a[3]; } )"; auto* expect = R"( var a : vec3; fn f() { var b : f32 = a[2]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Matrix_Idx_Scalar) { auto* src = R"( var a : mat3x2; fn f() { var b : f32 = a[2][1]; } )"; auto* expect = R"( var a : mat3x2; fn f() { var b : f32 = a[2][1]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Matrix_Idx_Expr_Column) { auto* src = R"( var a : mat3x2; var c : i32; fn f() { var b : f32 = a[c + 2 - 3][1]; } )"; auto* expect = R"( var a : mat3x2; var c : i32; fn f() { var b : f32 = a[min(u32(((c + 2) - 3)), 2u)][1]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Matrix_Idx_Expr_Row) { auto* src = R"( var a : mat3x2; var c : i32; fn f() { var b : f32 = a[1][c + 2 - 3]; } )"; auto* expect = R"( var a : mat3x2; var c : i32; fn f() { var b : f32 = a[1][min(u32(((c + 2) - 3)), 1u)]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Matrix_Idx_Negative_Column) { auto* src = R"( var a : mat3x2; fn f() { var b : f32 = a[-1][1]; } )"; auto* expect = R"( var a : mat3x2; fn f() { var b : f32 = a[0][1]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Matrix_Idx_Negative_Row) { auto* src = R"( var a : mat3x2; fn f() { var b : f32 = a[2][-1]; } )"; auto* expect = R"( var a : mat3x2; fn f() { var b : f32 = a[2][0]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Matrix_Idx_OutOfBounds_Column) { auto* src = R"( var a : mat3x2; fn f() { var b : f32 = a[5][1]; } )"; auto* expect = R"( var a : mat3x2; fn f() { var b : f32 = a[2][1]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } TEST_F(BoundArrayAccessorsTest, Matrix_Idx_OutOfBounds_Row) { auto* src = R"( var a : mat3x2; fn f() { var b : f32 = a[2][5]; } )"; auto* expect = R"( var a : mat3x2; fn f() { var b : f32 = a[2][1]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } // TODO(dsinclair): Implement when constant_id exists TEST_F(BoundArrayAccessorsTest, DISABLED_Vector_Constant_Id_Clamps) { // [[override(1300)]] let idx : i32; // var a : vec3 // var b : f32 = a[idx] // // ->var b : f32 = a[min(u32(idx), 2)] } // TODO(dsinclair): Implement when constant_id exists TEST_F(BoundArrayAccessorsTest, DISABLED_Array_Constant_Id_Clamps) { // [[override(1300)]] let idx : i32; // var a : array // var b : f32 = a[idx] // // -> var b : f32 = a[min(u32(idx), 3)] } // TODO(dsinclair): Implement when constant_id exists TEST_F(BoundArrayAccessorsTest, DISABLED_Matrix_Column_Constant_Id_Clamps) { // [[override(1300)]] let idx : i32; // var a : mat3x2 // var b : f32 = a[idx][1] // // -> var b : f32 = a[min(u32(idx), 2)][1] } // TODO(dsinclair): Implement when constant_id exists TEST_F(BoundArrayAccessorsTest, DISABLED_Matrix_Row_Constant_Id_Clamps) { // [[override(1300)]] let idx : i32; // var a : mat3x2 // var b : f32 = a[1][idx] // // -> var b : f32 = a[1][min(u32(idx), 0, 1)] } TEST_F(BoundArrayAccessorsTest, RuntimeArray_Clamps) { auto* src = R"( [[block]] struct S { a : f32; b : array; }; [[group(0), binding(0)]] var s : [[access(read)]] S; fn f() { var d : f32 = s.b[25]; } )"; auto* expect = R"( [[block]] struct S { a : f32; b : array; }; [[group(0), binding(0)]] var s : [[access(read)]] S; fn f() { var d : f32 = s.b[min(u32(25), (arrayLength(s.b) - 1u))]; } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } // TODO(dsinclair): Clamp atomics when available. TEST_F(BoundArrayAccessorsTest, DISABLED_Atomics_Clamp) { FAIL(); } // TODO(dsinclair): Clamp texture coord values. Depends on: // https://github.com/gpuweb/gpuweb/issues/1107 TEST_F(BoundArrayAccessorsTest, DISABLED_TextureCoord_Clamp) { FAIL(); } // TODO(dsinclair): Test for scoped variables when Lexical Scopes implemented TEST_F(BoundArrayAccessorsTest, DISABLED_Scoped_Variable) { // var a : array; // var i : u32; // { // var a : array; // var b : f32 = a[i]; // } // var c : f32 = a[i]; // // -> var b : f32 = a[min(u32(i), 4)]; // var c : f32 = a[min(u32(i), 2)]; FAIL(); } // Check that existing use of min() and arrayLength() do not get renamed. TEST_F(BoundArrayAccessorsTest, DontRenameSymbols) { auto* src = R"( [[block]] struct S { a : f32; b : array; }; [[group(0), binding(0)]] var s : [[access(read)]] S; let c : u32 = 1u; fn f() { let b : f32 = s.b[c]; let x : i32 = min(1, 2); let y : u32 = arrayLength(s.b); } )"; auto* expect = R"( [[block]] struct S { a : f32; b : array; }; [[group(0), binding(0)]] var s : [[access(read)]] S; let c : u32 = 1u; fn f() { let b : f32 = s.b[min(u32(c), (arrayLength(s.b) - 1u))]; let x : i32 = min(1, 2); let y : u32 = arrayLength(s.b); } )"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } } // namespace } // namespace transform } // namespace tint