// Copyright 2021 The Tint Authors. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. #include "src/tint/transform/binding_remapper.h" #include #include "src/tint/transform/test_helper.h" namespace tint::transform { namespace { using BindingRemapperTest = TransformTest; TEST_F(BindingRemapperTest, ShouldRunEmptyRemappings) { auto* src = R"()"; DataMap data; data.Add(BindingRemapper::BindingPoints{}, BindingRemapper::AccessControls{}); EXPECT_FALSE(ShouldRun(src, data)); } TEST_F(BindingRemapperTest, ShouldRunBindingPointRemappings) { auto* src = R"()"; DataMap data; data.Add( BindingRemapper::BindingPoints{ {{2, 1}, {1, 2}}, }, BindingRemapper::AccessControls{}); EXPECT_TRUE(ShouldRun(src, data)); } TEST_F(BindingRemapperTest, ShouldRunAccessControlRemappings) { auto* src = R"()"; DataMap data; data.Add(BindingRemapper::BindingPoints{}, BindingRemapper::AccessControls{ {{2, 1}, ast::Access::kWrite}, }); EXPECT_TRUE(ShouldRun(src, data)); } TEST_F(BindingRemapperTest, NoRemappings) { auto* src = R"( struct S { a : f32, } @group(2) @binding(1) var a : S; @group(3) @binding(2) var b : S; @compute @workgroup_size(1) fn f() { } )"; auto* expect = src; DataMap data; data.Add(BindingRemapper::BindingPoints{}, BindingRemapper::AccessControls{}); auto got = Run(src, data); EXPECT_EQ(expect, str(got)); } TEST_F(BindingRemapperTest, RemapBindingPoints) { auto* src = R"( struct S { a : f32, }; @group(2) @binding(1) var a : S; @group(3) @binding(2) var b : S; @compute @workgroup_size(1) fn f() { } )"; auto* expect = R"( struct S { a : f32, } @group(1) @binding(2) var a : S; @group(3) @binding(2) var b : S; @compute @workgroup_size(1) fn f() { } )"; DataMap data; data.Add( BindingRemapper::BindingPoints{ {{2, 1}, {1, 2}}, // Remap {{4, 5}, {6, 7}}, // Not found // Keep @group(3) @binding(2) as is }, BindingRemapper::AccessControls{}); auto got = Run(src, data); EXPECT_EQ(expect, str(got)); } TEST_F(BindingRemapperTest, RemapAccessControls) { auto* src = R"( struct S { a : f32, }; @group(2) @binding(1) var a : S; @group(3) @binding(2) var b : S; @group(4) @binding(3) var c : S; @compute @workgroup_size(1) fn f() { } )"; auto* expect = R"( struct S { a : f32, } @group(2) @binding(1) var a : S; @group(3) @binding(2) var b : S; @group(4) @binding(3) var c : S; @compute @workgroup_size(1) fn f() { } )"; DataMap data; data.Add( BindingRemapper::BindingPoints{}, BindingRemapper::AccessControls{ {{2, 1}, ast::Access::kReadWrite}, // Modify access control // Keep @group(3) @binding(2) as is {{4, 3}, ast::Access::kRead}, // Add access control }); auto got = Run(src, data); EXPECT_EQ(expect, str(got)); } TEST_F(BindingRemapperTest, RemapAll) { auto* src = R"( struct S { a : f32, }; @group(2) @binding(1) var a : S; @group(3) @binding(2) var b : S; @compute @workgroup_size(1) fn f() { } )"; auto* expect = R"( struct S { a : f32, } @group(4) @binding(5) var a : S; @group(6) @binding(7) var b : S; @compute @workgroup_size(1) fn f() { } )"; DataMap data; data.Add( BindingRemapper::BindingPoints{ {{2, 1}, {4, 5}}, {{3, 2}, {6, 7}}, }, BindingRemapper::AccessControls{ {{2, 1}, ast::Access::kReadWrite}, {{3, 2}, ast::Access::kReadWrite}, }); auto got = Run(src, data); EXPECT_EQ(expect, str(got)); } TEST_F(BindingRemapperTest, BindingCollisionsSameEntryPoint) { auto* src = R"( struct S { i : i32, }; @group(2) @binding(1) var a : S; @group(3) @binding(2) var b : S; @group(4) @binding(3) var c : S; @group(5) @binding(4) var d : S; @compute @workgroup_size(1) fn f() { let x : i32 = (((a.i + b.i) + c.i) + d.i); } )"; auto* expect = R"( struct S { i : i32, } @internal(disable_validation__binding_point_collision) @group(1) @binding(1) var a : S; @internal(disable_validation__binding_point_collision) @group(1) @binding(1) var b : S; @internal(disable_validation__binding_point_collision) @group(5) @binding(4) var c : S; @internal(disable_validation__binding_point_collision) @group(5) @binding(4) var d : S; @compute @workgroup_size(1) fn f() { let x : i32 = (((a.i + b.i) + c.i) + d.i); } )"; DataMap data; data.Add( BindingRemapper::BindingPoints{ {{2, 1}, {1, 1}}, {{3, 2}, {1, 1}}, {{4, 3}, {5, 4}}, }, BindingRemapper::AccessControls{}, true); auto got = Run(src, data); EXPECT_EQ(expect, str(got)); } TEST_F(BindingRemapperTest, BindingCollisionsDifferentEntryPoints) { auto* src = R"( struct S { i : i32, }; @group(2) @binding(1) var a : S; @group(3) @binding(2) var b : S; @group(4) @binding(3) var c : S; @group(5) @binding(4) var d : S; @compute @workgroup_size(1) fn f1() { let x : i32 = (a.i + c.i); } @compute @workgroup_size(1) fn f2() { let x : i32 = (b.i + d.i); } )"; auto* expect = R"( struct S { i : i32, } @group(1) @binding(1) var a : S; @group(1) @binding(1) var b : S; @group(5) @binding(4) var c : S; @group(5) @binding(4) var d : S; @compute @workgroup_size(1) fn f1() { let x : i32 = (a.i + c.i); } @compute @workgroup_size(1) fn f2() { let x : i32 = (b.i + d.i); } )"; DataMap data; data.Add( BindingRemapper::BindingPoints{ {{2, 1}, {1, 1}}, {{3, 2}, {1, 1}}, {{4, 3}, {5, 4}}, }, BindingRemapper::AccessControls{}, true); auto got = Run(src, data); EXPECT_EQ(expect, str(got)); } TEST_F(BindingRemapperTest, NoData) { auto* src = R"( struct S { a : f32, } @group(2) @binding(1) var a : S; @group(3) @binding(2) var b : S; @compute @workgroup_size(1) fn f() { } )"; auto* expect = R"(error: missing transform data for tint::transform::BindingRemapper)"; auto got = Run(src); EXPECT_EQ(expect, str(got)); } } // namespace } // namespace tint::transform