// Copyright 2019 The Dawn Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. #include "tests/DawnTest.h" #include "utils/WGPUHelpers.h" class ComputeStorageBufferBarrierTests : public DawnTest { protected: static constexpr uint32_t kNumValues = 100; static constexpr uint32_t kIterations = 100; }; // Test that multiple dispatches to increment values in a storage buffer are synchronized. TEST_P(ComputeStorageBufferBarrierTests, AddIncrement) { std::vector data(kNumValues, 0); std::vector expected(kNumValues, 0x1234 * kIterations); uint64_t bufferSize = static_cast(data.size() * sizeof(uint32_t)); wgpu::Buffer buffer = utils::CreateBufferFromData( device, data.data(), bufferSize, wgpu::BufferUsage::Storage | wgpu::BufferUsage::CopySrc); wgpu::ShaderModule module = utils::CreateShaderModule(device, utils::SingleShaderStage::Compute, R"( #version 450 #define kNumValues 100 layout(std430, set = 0, binding = 0) buffer Buf { uint buf[kNumValues]; }; void main() { buf[gl_GlobalInvocationID.x] += 0x1234; } )"); wgpu::BindGroupLayout bgl = utils::MakeBindGroupLayout( device, {{0, wgpu::ShaderStage::Compute, wgpu::BindingType::StorageBuffer}}); wgpu::BindGroup bindGroup = utils::MakeBindGroup(device, bgl, {{0, buffer, 0, bufferSize}}); wgpu::PipelineLayout layout = utils::MakeBasicPipelineLayout(device, &bgl); wgpu::ComputePipelineDescriptor pipelineDesc = {}; pipelineDesc.layout = layout; pipelineDesc.computeStage.module = module; pipelineDesc.computeStage.entryPoint = "main"; wgpu::ComputePipeline pipeline = device.CreateComputePipeline(&pipelineDesc); wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::ComputePassEncoder pass = encoder.BeginComputePass(); pass.SetPipeline(pipeline); pass.SetBindGroup(0, bindGroup); for (uint32_t i = 0; i < kIterations; ++i) { pass.Dispatch(kNumValues, 1, 1); } pass.EndPass(); wgpu::CommandBuffer commands = encoder.Finish(); queue.Submit(1, &commands); EXPECT_BUFFER_U32_RANGE_EQ(expected.data(), buffer, 0, kNumValues); } // Test that multiple dispatches to increment values by ping-ponging between two storage buffers // are synchronized. TEST_P(ComputeStorageBufferBarrierTests, AddPingPong) { std::vector data(kNumValues, 0); std::vector expectedA(kNumValues, 0x1234 * kIterations); std::vector expectedB(kNumValues, 0x1234 * (kIterations - 1)); uint64_t bufferSize = static_cast(data.size() * sizeof(uint32_t)); wgpu::Buffer bufferA = utils::CreateBufferFromData( device, data.data(), bufferSize, wgpu::BufferUsage::Storage | wgpu::BufferUsage::CopySrc); wgpu::Buffer bufferB = utils::CreateBufferFromData( device, data.data(), bufferSize, wgpu::BufferUsage::Storage | wgpu::BufferUsage::CopySrc); wgpu::ShaderModule module = utils::CreateShaderModule(device, utils::SingleShaderStage::Compute, R"( #version 450 #define kNumValues 100 layout(std430, set = 0, binding = 0) buffer Src { uint src[kNumValues]; }; layout(std430, set = 0, binding = 1) buffer Dst { uint dst[kNumValues]; }; void main() { uint index = gl_GlobalInvocationID.x; dst[index] = src[index] + 0x1234; } )"); wgpu::BindGroupLayout bgl = utils::MakeBindGroupLayout( device, {{0, wgpu::ShaderStage::Compute, wgpu::BindingType::StorageBuffer}, {1, wgpu::ShaderStage::Compute, wgpu::BindingType::StorageBuffer}}); wgpu::BindGroup bindGroupA = utils::MakeBindGroup(device, bgl, { {0, bufferA, 0, bufferSize}, {1, bufferB, 0, bufferSize}, }); wgpu::BindGroup bindGroupB = utils::MakeBindGroup(device, bgl, { {0, bufferB, 0, bufferSize}, {1, bufferA, 0, bufferSize}, }); wgpu::BindGroup bindGroups[2] = {bindGroupA, bindGroupB}; wgpu::PipelineLayout layout = utils::MakeBasicPipelineLayout(device, &bgl); wgpu::ComputePipelineDescriptor pipelineDesc = {}; pipelineDesc.layout = layout; pipelineDesc.computeStage.module = module; pipelineDesc.computeStage.entryPoint = "main"; wgpu::ComputePipeline pipeline = device.CreateComputePipeline(&pipelineDesc); wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); wgpu::ComputePassEncoder pass = encoder.BeginComputePass(); pass.SetPipeline(pipeline); for (uint32_t i = 0; i < kIterations / 2; ++i) { pass.SetBindGroup(0, bindGroups[0]); pass.Dispatch(kNumValues, 1, 1); pass.SetBindGroup(0, bindGroups[1]); pass.Dispatch(kNumValues, 1, 1); } pass.EndPass(); wgpu::CommandBuffer commands = encoder.Finish(); queue.Submit(1, &commands); EXPECT_BUFFER_U32_RANGE_EQ(expectedA.data(), bufferA, 0, kNumValues); EXPECT_BUFFER_U32_RANGE_EQ(expectedB.data(), bufferB, 0, kNumValues); } // Test that Storage to Uniform buffer transitions work and synchronize correctly // by ping-ponging between Storage/Uniform usage in sequential compute passes. TEST_P(ComputeStorageBufferBarrierTests, UniformToStorageAddPingPong) { std::vector data(kNumValues, 0); std::vector expectedA(kNumValues, 0x1234 * kIterations); std::vector expectedB(kNumValues, 0x1234 * (kIterations - 1)); uint64_t bufferSize = static_cast(data.size() * sizeof(uint32_t)); wgpu::Buffer bufferA = utils::CreateBufferFromData( device, data.data(), bufferSize, wgpu::BufferUsage::Storage | wgpu::BufferUsage::Uniform | wgpu::BufferUsage::CopySrc); wgpu::Buffer bufferB = utils::CreateBufferFromData( device, data.data(), bufferSize, wgpu::BufferUsage::Storage | wgpu::BufferUsage::Uniform | wgpu::BufferUsage::CopySrc); wgpu::ShaderModule module = utils::CreateShaderModule(device, utils::SingleShaderStage::Compute, R"( #version 450 #define kNumValues 100 layout(std140, set = 0, binding = 0) uniform Src { uvec4 src[kNumValues / 4]; }; layout(std430, set = 0, binding = 1) buffer Dst { uvec4 dst[kNumValues / 4]; }; void main() { uint index = gl_GlobalInvocationID.x; dst[index] = src[index] + 0x1234; } )"); wgpu::BindGroupLayout bgl = utils::MakeBindGroupLayout( device, {{0, wgpu::ShaderStage::Compute, wgpu::BindingType::UniformBuffer}, {1, wgpu::ShaderStage::Compute, wgpu::BindingType::StorageBuffer}}); wgpu::BindGroup bindGroupA = utils::MakeBindGroup(device, bgl, { {0, bufferA, 0, bufferSize}, {1, bufferB, 0, bufferSize}, }); wgpu::BindGroup bindGroupB = utils::MakeBindGroup(device, bgl, { {0, bufferB, 0, bufferSize}, {1, bufferA, 0, bufferSize}, }); wgpu::BindGroup bindGroups[2] = {bindGroupA, bindGroupB}; wgpu::PipelineLayout layout = utils::MakeBasicPipelineLayout(device, &bgl); wgpu::ComputePipelineDescriptor pipelineDesc = {}; pipelineDesc.layout = layout; pipelineDesc.computeStage.module = module; pipelineDesc.computeStage.entryPoint = "main"; wgpu::ComputePipeline pipeline = device.CreateComputePipeline(&pipelineDesc); wgpu::CommandEncoder encoder = device.CreateCommandEncoder(); for (uint32_t i = 0, b = 0; i < kIterations; ++i, b = 1 - b) { wgpu::ComputePassEncoder pass = encoder.BeginComputePass(); pass.SetPipeline(pipeline); pass.SetBindGroup(0, bindGroups[b]); pass.Dispatch(kNumValues, 1, 1); pass.EndPass(); } wgpu::CommandBuffer commands = encoder.Finish(); queue.Submit(1, &commands); EXPECT_BUFFER_U32_RANGE_EQ(expectedA.data(), bufferA, 0, kNumValues); EXPECT_BUFFER_U32_RANGE_EQ(expectedB.data(), bufferB, 0, kNumValues); } DAWN_INSTANTIATE_TEST(ComputeStorageBufferBarrierTests, D3D12Backend, MetalBackend, OpenGLBackend, VulkanBackend);