dawn-cmake/test/tint/builtins/atomicStore/struct
James Price 0e22bdbae7 tint/msl: Fix emission of private variables
In order to avoid declaring too many function parameters, we
previously modified this transform to redeclare private variables that
are only used inside a single function as function-scope
variables. This was broken as it meant that their values did not
persist across multiple calls to the same function.

Instead, wrap all private variables in a structure and pass it around
as a pointer.

Fixed: tint:1875
Change-Id: I83f5eb1071d57b9c6af56d6cf21b3a32c6e94260
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/124800
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: James Price <jrprice@google.com>
2023-03-20 21:46:01 +00:00
..
array_of_struct.spvasm tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
array_of_struct.spvasm.expected.dxc.hlsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
array_of_struct.spvasm.expected.fxc.hlsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
array_of_struct.spvasm.expected.glsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
array_of_struct.spvasm.expected.msl tint/msl: Fix emission of private variables 2023-03-20 21:46:01 +00:00
array_of_struct.spvasm.expected.spvasm tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
array_of_struct.spvasm.expected.wgsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
array_of_struct.wgsl tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
array_of_struct.wgsl.expected.dxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
array_of_struct.wgsl.expected.fxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
array_of_struct.wgsl.expected.glsl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
array_of_struct.wgsl.expected.msl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
array_of_struct.wgsl.expected.spvasm tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
array_of_struct.wgsl.expected.wgsl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
flat_multiple_atomics.spvasm tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
flat_multiple_atomics.spvasm.expected.dxc.hlsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
flat_multiple_atomics.spvasm.expected.fxc.hlsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
flat_multiple_atomics.spvasm.expected.glsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
flat_multiple_atomics.spvasm.expected.msl tint/msl: Fix emission of private variables 2023-03-20 21:46:01 +00:00
flat_multiple_atomics.spvasm.expected.spvasm tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
flat_multiple_atomics.spvasm.expected.wgsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
flat_multiple_atomics.wgsl tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
flat_multiple_atomics.wgsl.expected.dxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
flat_multiple_atomics.wgsl.expected.fxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
flat_multiple_atomics.wgsl.expected.glsl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
flat_multiple_atomics.wgsl.expected.msl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
flat_multiple_atomics.wgsl.expected.spvasm tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
flat_multiple_atomics.wgsl.expected.wgsl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
flat_single_atomic.spvasm tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
flat_single_atomic.spvasm.expected.dxc.hlsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
flat_single_atomic.spvasm.expected.fxc.hlsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
flat_single_atomic.spvasm.expected.glsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
flat_single_atomic.spvasm.expected.msl tint/msl: Fix emission of private variables 2023-03-20 21:46:01 +00:00
flat_single_atomic.spvasm.expected.spvasm tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
flat_single_atomic.spvasm.expected.wgsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
flat_single_atomic.wgsl tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
flat_single_atomic.wgsl.expected.dxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
flat_single_atomic.wgsl.expected.fxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
flat_single_atomic.wgsl.expected.glsl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
flat_single_atomic.wgsl.expected.msl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
flat_single_atomic.wgsl.expected.spvasm tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
flat_single_atomic.wgsl.expected.wgsl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
nested.spvasm tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
nested.spvasm.expected.dxc.hlsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
nested.spvasm.expected.fxc.hlsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
nested.spvasm.expected.glsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
nested.spvasm.expected.msl tint/msl: Fix emission of private variables 2023-03-20 21:46:01 +00:00
nested.spvasm.expected.spvasm tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
nested.spvasm.expected.wgsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
nested.wgsl tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
nested.wgsl.expected.dxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
nested.wgsl.expected.fxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
nested.wgsl.expected.glsl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
nested.wgsl.expected.msl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
nested.wgsl.expected.spvasm tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
nested.wgsl.expected.wgsl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
struct_of_array.spvasm tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
struct_of_array.spvasm.expected.dxc.hlsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
struct_of_array.spvasm.expected.fxc.hlsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
struct_of_array.spvasm.expected.glsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
struct_of_array.spvasm.expected.msl tint/msl: Fix emission of private variables 2023-03-20 21:46:01 +00:00
struct_of_array.spvasm.expected.spvasm tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
struct_of_array.spvasm.expected.wgsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
struct_of_array.wgsl tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
struct_of_array.wgsl.expected.dxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
struct_of_array.wgsl.expected.fxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
struct_of_array.wgsl.expected.glsl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
struct_of_array.wgsl.expected.msl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
struct_of_array.wgsl.expected.spvasm tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
struct_of_array.wgsl.expected.wgsl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
via_ptr_let.spvasm tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
via_ptr_let.spvasm.expected.dxc.hlsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
via_ptr_let.spvasm.expected.fxc.hlsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
via_ptr_let.spvasm.expected.glsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
via_ptr_let.spvasm.expected.msl tint/msl: Fix emission of private variables 2023-03-20 21:46:01 +00:00
via_ptr_let.spvasm.expected.spvasm tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
via_ptr_let.spvasm.expected.wgsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
via_ptr_let.wgsl tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
via_ptr_let.wgsl.expected.dxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
via_ptr_let.wgsl.expected.fxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
via_ptr_let.wgsl.expected.glsl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
via_ptr_let.wgsl.expected.msl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
via_ptr_let.wgsl.expected.spvasm tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00
via_ptr_let.wgsl.expected.wgsl tint/test: Regenerate expectations 2022-06-25 00:55:59 +00:00