diff --git a/include/LZ77/LZType10.hpp b/include/LZ77/LZType10.hpp index c613625..a3517bc 100644 --- a/include/LZ77/LZType10.hpp +++ b/include/LZ77/LZType10.hpp @@ -6,6 +6,6 @@ class LZType10 : public LZBase { public: explicit LZType10(atInt32 minimumOffset = 1, atInt32 SlidingWindow = 4096, atInt32 MinimumMatch = 3, atInt32 BlockSize = 8); - atUint32 compress(const atUint8* src, atUint8** dstBuf, atUint32 srcLength); - atUint32 decompress(const atUint8* src, atUint8** dst, atUint32 srcLen); + atUint32 compress(const atUint8* src, atUint8** dstBuf, atUint32 srcLength) override; + atUint32 decompress(const atUint8* src, atUint8** dst, atUint32 srcLen) override; }; diff --git a/include/LZ77/LZType11.hpp b/include/LZ77/LZType11.hpp index e5e1c99..7402319 100644 --- a/include/LZ77/LZType11.hpp +++ b/include/LZ77/LZType11.hpp @@ -6,6 +6,6 @@ class LZType11 : public LZBase { public: explicit LZType11(atInt32 MinimumOffset = 1, atInt32 SlidingWindow = 4096, atInt32 MinimumMatch = 3, atInt32 BlockSize = 8); - atUint32 compress(const atUint8* src, atUint8** dst, atUint32 srcLength); - atUint32 decompress(const atUint8* src, atUint8** dst, atUint32 srcLength); + atUint32 compress(const atUint8* src, atUint8** dst, atUint32 srcLength) override; + atUint32 decompress(const atUint8* src, atUint8** dst, atUint32 srcLength) override; }; diff --git a/include/athena/DNAOp.hpp b/include/athena/DNAOp.hpp index a63e550..271dd63 100644 --- a/include/athena/DNAOp.hpp +++ b/include/athena/DNAOp.hpp @@ -56,16 +56,16 @@ constexpr PropId operator"" _propid(const char* s, size_t len) { return {s}; } enum class PropType { None, CRC32, CRC64 }; template -using __IsPODType = typename std::disjunction< +using __IsPODType = std::disjunction< std::is_arithmetic>, std::is_convertible&, atVec2f&>, std::is_convertible&, atVec3f&>, std::is_convertible&, atVec4f&>, std::is_convertible&, atVec2d&>, std::is_convertible&, atVec3d&>, std::is_convertible&, atVec4d&>>; template -inline constexpr bool __IsPODType_v = __IsPODType::value; +constexpr bool __IsPODType_v = __IsPODType::value; template -using __CastPODType = typename std::conditional_t< +using __CastPODType = std::conditional_t< std::is_convertible_v&, atVec2f&>, atVec2f, std::conditional_t< std::is_convertible_v&, atVec3f&>, atVec3f, @@ -78,32 +78,32 @@ using __CastPODType = typename std::conditional_t< std::remove_cv_t>>>>>>; template -inline uint16_t __Read16(IStreamReader& r) { +uint16_t __Read16(IStreamReader& r) { return DNAE == Endian::Big ? r.readUint16Big() : r.readUint16Little(); } template -inline void __Write16(IStreamWriter& w, uint16_t v) { +void __Write16(IStreamWriter& w, uint16_t v) { DNAE == Endian::Big ? w.writeUint16Big(v) : w.writeUint16Little(v); } template -inline uint32_t __Read32(IStreamReader& r) { +uint32_t __Read32(IStreamReader& r) { return DNAE == Endian::Big ? r.readUint32Big() : r.readUint32Little(); } template -inline void __Write32(IStreamWriter& w, uint32_t v) { +void __Write32(IStreamWriter& w, uint32_t v) { DNAE == Endian::Big ? w.writeUint32Big(v) : w.writeUint32Little(v); } template -inline uint64_t __Read64(IStreamReader& r) { +uint64_t __Read64(IStreamReader& r) { return DNAE == Endian::Big ? r.readUint64Big() : r.readUint64Little(); } template -inline void __Write64(IStreamWriter& w, uint64_t v) { +void __Write64(IStreamWriter& w, uint64_t v) { DNAE == Endian::Big ? w.writeUint64Big(v) : w.writeUint64Little(v); } @@ -112,7 +112,7 @@ struct BinarySize { using PropT = std::conditional_t; using StreamT = size_t; template - static typename std::enable_if_t> Do(const PropId& id, T& var, StreamT& s) { + static std::enable_if_t> Do(const PropId& id, T& var, StreamT& s) { if (PropOp != PropType::None) { /* Accessed via Enumerate, header */ s += 6; @@ -121,7 +121,7 @@ struct BinarySize { BinarySize::Do(id, *reinterpret_cast(&var), s); } template - static typename std::enable_if_t<__IsPODType_v> Do(const PropId& id, T& var, StreamT& s) { + static std::enable_if_t<__IsPODType_v> Do(const PropId& id, T& var, StreamT& s) { if (PropOp != PropType::None) { /* Accessed via Enumerate, header */ s += 6; @@ -130,19 +130,17 @@ struct BinarySize { BinarySize::Do(id, static_cast(const_cast&>(var)), s); } template - static typename std::enable_if_t<__IsDNARecord_v && PropOp != PropType::None> Do(const PropId& id, T& var, - StreamT& s) { + static std::enable_if_t<__IsDNARecord_v && PropOp != PropType::None> Do(const PropId& id, T& var, StreamT& s) { /* Accessed via Enumerate, header */ s += 6; var.template Enumerate>(s); } template - static typename std::enable_if_t<__IsDNARecord_v && PropOp == PropType::None> Do(const PropId& id, T& var, - StreamT& s) { + static std::enable_if_t<__IsDNARecord_v && PropOp == PropType::None> Do(const PropId& id, T& var, StreamT& s) { var.template Enumerate>(s); } template - static typename std::enable_if_t> Do(const PropId& id, T& var, StreamT& s) { + static std::enable_if_t> Do(const PropId& id, T& var, StreamT& s) { for (auto& v : var) BinarySize::Do, DNAE>(id, v, s); } @@ -151,14 +149,14 @@ struct BinarySize { BinarySize::Do(id, var, s); } template - static typename std::enable_if_t> Do(const PropId& id, std::vector& vector, - const S& count, StreamT& s) { + static std::enable_if_t> Do(const PropId& id, std::vector& vector, const S& count, + StreamT& s) { for (T& v : vector) BinarySize::Do(id, v, s); } template - static typename std::enable_if_t> Do(const PropId& id, std::vector& vector, const S& count, - StreamT& s) { + static std::enable_if_t> Do(const PropId& id, std::vector& vector, const S& count, + StreamT& s) { /* libc++ specializes vector as a bitstream */ s += vector.size(); } @@ -167,7 +165,7 @@ struct BinarySize { s += count; } template - static typename std::enable_if_t> Do(const PropId& id, T& str, StreamT& s) { + static std::enable_if_t> Do(const PropId& id, T& str, StreamT& s) { s += str.size() + 1; } static void Do(const PropId& id, std::string& str, atInt32 count, StreamT& s) { @@ -177,7 +175,7 @@ struct BinarySize { s += count; } template - static typename std::enable_if_t> Do(const PropId& id, T& str, StreamT& s) { + static std::enable_if_t> Do(const PropId& id, T& str, StreamT& s) { s += str.size() * 2 + 2; } template @@ -263,7 +261,7 @@ struct PropCount { s += 1; } template - static typename std::enable_if_t> Do(const PropId& id, T& str, StreamT& s) { + static std::enable_if_t> Do(const PropId& id, T& str, StreamT& s) { /* Only reports one level of properties */ s += 1; } @@ -272,7 +270,7 @@ struct PropCount { s += 1; } template - static typename std::enable_if_t> Do(const PropId& id, T& str, StreamT& s) { + static std::enable_if_t> Do(const PropId& id, T& str, StreamT& s) { /* Only reports one level of properties */ s += 1; } @@ -290,23 +288,21 @@ struct Read { using PropT = std::conditional_t; using StreamT = IStreamReader; template - static typename std::enable_if_t> Do(const PropId& id, T& var, StreamT& r) { + static std::enable_if_t> Do(const PropId& id, T& var, StreamT& r) { using PODType = std::underlying_type_t; Read::Do(id, *reinterpret_cast(&var), r); } template - static typename std::enable_if_t<__IsPODType_v> Do(const PropId& id, T& var, StreamT& r) { + static std::enable_if_t<__IsPODType_v> Do(const PropId& id, T& var, StreamT& r) { using CastT = __CastPODType; Read::Do(id, static_cast(var), r); } template - static typename std::enable_if_t<__IsDNARecord() && PropOp == PropType::None> Do(const PropId& id, T& var, - StreamT& r) { + static std::enable_if_t<__IsDNARecord() && PropOp == PropType::None> Do(const PropId& id, T& var, StreamT& r) { var.template Enumerate>(r); } template - static typename std::enable_if_t<__IsDNARecord() && PropOp != PropType::None> Do(const PropId& id, T& var, - StreamT& r) { + static std::enable_if_t<__IsDNARecord() && PropOp != PropType::None> Do(const PropId& id, T& var, StreamT& r) { /* Accessed via Lookup, no header */ atUint16 propCount = __Read16(r); for (atUint32 i = 0; i < propCount; ++i) { @@ -324,7 +320,7 @@ struct Read { } } template - static typename std::enable_if_t> Do(const PropId& id, T& var, StreamT& s) { + static std::enable_if_t> Do(const PropId& id, T& var, StreamT& s) { for (auto& v : var) Read::Do, DNAE>(id, v, s); } @@ -333,8 +329,8 @@ struct Read { Read::Do(id, var, s); } template - static typename std::enable_if_t> Do(const PropId& id, std::vector& vector, - const S& count, StreamT& r) { + static std::enable_if_t> Do(const PropId& id, std::vector& vector, const S& count, + StreamT& r) { vector.clear(); vector.reserve(count); for (size_t i = 0; i < static_cast(count); ++i) { @@ -343,8 +339,8 @@ struct Read { } } template - static typename std::enable_if_t> Do(const PropId& id, std::vector& vector, const S& count, - StreamT& r) { + static std::enable_if_t> Do(const PropId& id, std::vector& vector, const S& count, + StreamT& r) { /* libc++ specializes vector as a bitstream */ vector.clear(); vector.reserve(count); @@ -356,12 +352,12 @@ struct Read { r.readUBytesToBuf(buf.get(), count); } template - static typename std::enable_if_t> Do(const PropId& id, T& str, StreamT& r) { + static std::enable_if_t> Do(const PropId& id, T& str, StreamT& r) { str = r.readString(); } static void Do(const PropId& id, std::string& str, atInt32 count, StreamT& r) { str = r.readString(count); } template - static typename std::enable_if_t> Do(const PropId& id, T& str, StreamT& r) { + static std::enable_if_t> Do(const PropId& id, T& str, StreamT& r) { Read::Do(id, str, r); } template @@ -429,7 +425,7 @@ struct Write { using PropT = std::conditional_t; using StreamT = IStreamWriter; template - static typename std::enable_if_t> Do(const PropId& id, T& var, StreamT& w) { + static std::enable_if_t> Do(const PropId& id, T& var, StreamT& w) { if (PropOp != PropType::None) { /* Accessed via Enumerate, header */ if (PropOp == PropType::CRC64) @@ -444,7 +440,7 @@ struct Write { Write::Do(id, *reinterpret_cast(&var), w); } template - static typename std::enable_if_t<__IsPODType_v> Do(const PropId& id, T& var, StreamT& w) { + static std::enable_if_t<__IsPODType_v> Do(const PropId& id, T& var, StreamT& w) { using CastT = __CastPODType; if (PropOp != PropType::None) { /* Accessed via Enumerate, header */ @@ -460,8 +456,7 @@ struct Write { Write::Do(id, static_cast(const_cast&>(var)), w); } template - static typename std::enable_if_t<__IsDNARecord() && PropOp != PropType::None> Do(const PropId& id, T& var, - StreamT& w) { + static std::enable_if_t<__IsDNARecord() && PropOp != PropType::None> Do(const PropId& id, T& var, StreamT& w) { /* Accessed via Enumerate, header */ if (PropOp == PropType::CRC64) __Write64(w, id.crc64); @@ -477,12 +472,11 @@ struct Write { var.template Enumerate>(w); } template - static typename std::enable_if_t<__IsDNARecord() && PropOp == PropType::None> Do(const PropId& id, T& var, - StreamT& w) { + static std::enable_if_t<__IsDNARecord() && PropOp == PropType::None> Do(const PropId& id, T& var, StreamT& w) { var.template Enumerate>(w); } template - static typename std::enable_if_t> Do(const PropId& id, T& var, StreamT& s) { + static std::enable_if_t> Do(const PropId& id, T& var, StreamT& s) { for (auto& v : var) Write::Do, DNAE>(id, v, s); } @@ -491,14 +485,14 @@ struct Write { Write::Do(id, var, s); } template - static typename std::enable_if_t> Do(const PropId& id, std::vector& vector, - const S& count, StreamT& w) { + static std::enable_if_t> Do(const PropId& id, std::vector& vector, const S& count, + StreamT& w) { for (T& v : vector) Write::Do(id, v, w); } template - static typename std::enable_if_t> Do(const PropId& id, std::vector& vector, const S& count, - StreamT& w) { + static std::enable_if_t> Do(const PropId& id, std::vector& vector, const S& count, + StreamT& w) { /* libc++ specializes vector as a bitstream */ for (const T& v : vector) w.writeBool(v); @@ -508,13 +502,12 @@ struct Write { w.writeUBytes(buf.get(), count); } template - static typename std::enable_if_t> Do(const PropId& id, std::string& str, StreamT& w) { + static std::enable_if_t> Do(const PropId& id, std::string& str, StreamT& w) { w.writeString(str); } static void Do(const PropId& id, std::string& str, atInt32 count, StreamT& w) { w.writeString(str, count); } template - static typename std::enable_if_t> Do(const PropId& id, std::wstring& str, - StreamT& w) { + static std::enable_if_t> Do(const PropId& id, std::wstring& str, StreamT& w) { Write::Do(id, str, w); } template @@ -580,22 +573,22 @@ struct ReadYaml { using PropT = std::conditional_t; using StreamT = YAMLDocReader; template - static typename std::enable_if_t> Do(const PropId& id, T& var, StreamT& r) { + static std::enable_if_t> Do(const PropId& id, T& var, StreamT& r) { using PODType = std::underlying_type_t; ReadYaml::Do(id, *reinterpret_cast(&var), r); } template - static typename std::enable_if_t<__IsPODType_v> Do(const PropId& id, T& var, StreamT& r) { + static std::enable_if_t<__IsPODType_v> Do(const PropId& id, T& var, StreamT& r) { using CastT = __CastPODType; ReadYaml::Do(id, static_cast(var), r); } template - static typename std::enable_if_t<__IsDNARecord_v> Do(const PropId& id, T& var, StreamT& r) { + static std::enable_if_t<__IsDNARecord_v> Do(const PropId& id, T& var, StreamT& r) { if (auto rec = r.enterSubRecord(id.name)) var.template Enumerate>(r); } template - static typename std::enable_if_t> Do(const PropId& id, T& var, StreamT& r) { + static std::enable_if_t> Do(const PropId& id, T& var, StreamT& r) { size_t _count; if (auto __v = r.enterSubVector(id.name, _count)) for (size_t i = 0; i < _count && i < std::extent_v; ++i) @@ -606,8 +599,8 @@ struct ReadYaml { /* Squelch size field access */ } template - static typename std::enable_if_t> Do(const PropId& id, std::vector& vector, - const S& count, StreamT& r) { + static std::enable_if_t> Do(const PropId& id, std::vector& vector, const S& count, + StreamT& r) { size_t _count; vector.clear(); if (auto __v = r.enterSubVector(id.name, _count)) { @@ -621,8 +614,8 @@ struct ReadYaml { const_cast(count) = vector.size(); } template - static typename std::enable_if_t> Do(const PropId& id, std::vector& vector, const S& count, - StreamT& r) { + static std::enable_if_t> Do(const PropId& id, std::vector& vector, const S& count, + StreamT& r) { /* libc++ specializes vector as a bitstream */ size_t _count; vector.clear(); @@ -638,12 +631,12 @@ struct ReadYaml { buf = r.readUBytes(id.name); } template - static typename std::enable_if_t> Do(const PropId& id, T& str, StreamT& r) { + static std::enable_if_t> Do(const PropId& id, T& str, StreamT& r) { str = r.readString(id.name); } static void Do(const PropId& id, std::string& str, atInt32 count, StreamT& r) { str = r.readString(id.name); } template - static typename std::enable_if_t> Do(const PropId& id, T& str, StreamT& r) { + static std::enable_if_t> Do(const PropId& id, T& str, StreamT& r) { str = r.readWString(id.name); } template @@ -697,22 +690,22 @@ struct WriteYaml { using PropT = std::conditional_t; using StreamT = YAMLDocWriter; template - static typename std::enable_if_t> Do(const PropId& id, T& var, StreamT& w) { + static std::enable_if_t> Do(const PropId& id, T& var, StreamT& w) { using PODType = std::underlying_type_t; WriteYaml::Do(id, *reinterpret_cast(&var), w); } template - static typename std::enable_if_t<__IsPODType_v> Do(const PropId& id, T& var, StreamT& w) { + static std::enable_if_t<__IsPODType_v> Do(const PropId& id, T& var, StreamT& w) { using CastT = __CastPODType; WriteYaml::Do(id, static_cast(const_cast&>(var)), w); } template - static typename std::enable_if_t<__IsDNARecord_v> Do(const PropId& id, T& var, StreamT& w) { + static std::enable_if_t<__IsDNARecord_v> Do(const PropId& id, T& var, StreamT& w) { if (auto rec = w.enterSubRecord(id.name)) var.template Enumerate>(w); } template - static typename std::enable_if_t> Do(const PropId& id, T& var, StreamT& w) { + static std::enable_if_t> Do(const PropId& id, T& var, StreamT& w) { if (auto __v = w.enterSubVector(id.name)) for (auto& v : var) WriteYaml::Do, DNAE>({}, v, w); @@ -722,15 +715,15 @@ struct WriteYaml { /* Squelch size field access */ } template - static typename std::enable_if_t> Do(const PropId& id, std::vector& vector, - const S& count, StreamT& w) { + static std::enable_if_t> Do(const PropId& id, std::vector& vector, const S& count, + StreamT& w) { if (auto __v = w.enterSubVector(id.name)) for (T& v : vector) WriteYaml::Do(id, v, w); } template - static typename std::enable_if_t> Do(const PropId& id, std::vector& vector, const S& count, - StreamT& w) { + static std::enable_if_t> Do(const PropId& id, std::vector& vector, const S& count, + StreamT& w) { /* libc++ specializes vector as a bitstream */ if (auto __v = w.enterSubVector(id.name)) for (const T& v : vector) @@ -740,12 +733,12 @@ struct WriteYaml { w.writeUBytes(id.name, buf, count); } template - static typename std::enable_if_t> Do(const PropId& id, T& str, StreamT& w) { + static std::enable_if_t> Do(const PropId& id, T& str, StreamT& w) { w.writeString(id.name, str); } static void Do(const PropId& id, std::string& str, atInt32 count, StreamT& w) { w.writeString(id.name, str); } template - static typename std::enable_if_t> Do(const PropId& id, T& str, StreamT& w) { + static std::enable_if_t> Do(const PropId& id, T& str, StreamT& w) { w.writeWString(id.name, str); } template @@ -795,77 +788,77 @@ __WRITE_YAML_S(atVec4f, Endian::Little) { w.writeVec4f(id.name, var); } __WRITE_YAML_S(atVec4d, Endian::Little) { w.writeVec4d(id.name, var); } template -inline void __Do(const PropId& id, T& var, typename Op::StreamT& s) { +void __Do(const PropId& id, T& var, typename Op::StreamT& s) { Op::template Do(id, var, s); } template -inline void __DoSize(const PropId& id, T& var, typename Op::StreamT& s) { +void __DoSize(const PropId& id, T& var, typename Op::StreamT& s) { Op::template DoSize(id, var, s); } template -inline void __Do(const PropId& id, std::vector& vector, const S& count, typename Op::StreamT& s) { +void __Do(const PropId& id, std::vector& vector, const S& count, typename Op::StreamT& s) { Op::template Do(id, vector, count, s); } template -inline void __Do(const PropId& id, std::unique_ptr& buf, size_t count, typename Op::StreamT& s) { +void __Do(const PropId& id, std::unique_ptr& buf, size_t count, typename Op::StreamT& s) { Op::Do(id, buf, count, s); } template -inline void __Do(const PropId& id, std::string& str, atInt32 count, typename Op::StreamT& s) { +void __Do(const PropId& id, std::string& str, atInt32 count, typename Op::StreamT& s) { Op::Do(id, str, count, s); } template -inline void __Do(const PropId& id, std::wstring& str, atInt32 count, typename Op::StreamT& s) { +void __Do(const PropId& id, std::wstring& str, atInt32 count, typename Op::StreamT& s) { Op::template Do(id, str, count, s); } template -inline void __DoSeek(atInt64 delta, athena::SeekOrigin whence, typename Op::StreamT& s) { +void __DoSeek(atInt64 delta, athena::SeekOrigin whence, typename Op::StreamT& s) { Op::DoSeek(delta, whence, s); } template -inline void __DoAlign(atInt64 amount, typename Op::StreamT& s) { +void __DoAlign(atInt64 amount, typename Op::StreamT& s) { Op::DoAlign(amount, s); } template -inline void __Read(T& obj, athena::io::IStreamReader& r) { +void __Read(T& obj, athena::io::IStreamReader& r) { __Do, T, T::DNAEndian>({}, obj, r); } template -inline void __Write(const T& obj, athena::io::IStreamWriter& w) { +void __Write(const T& obj, athena::io::IStreamWriter& w) { __Do, T, T::DNAEndian>({}, const_cast(obj), w); } template -inline void __BinarySize(const T& obj, size_t& s) { +void __BinarySize(const T& obj, size_t& s) { __Do, T, T::DNAEndian>({}, const_cast(obj), s); } template -inline void __PropCount(const T& obj, size_t& s) { +void __PropCount(const T& obj, size_t& s) { const_cast(obj).template Enumerate>(s); } template -inline void __ReadYaml(T& obj, athena::io::YAMLDocReader& r) { +void __ReadYaml(T& obj, athena::io::YAMLDocReader& r) { obj.template Enumerate>(r); } template -inline void __WriteYaml(const T& obj, athena::io::YAMLDocWriter& w) { +void __WriteYaml(const T& obj, athena::io::YAMLDocWriter& w) { const_cast(obj).template Enumerate>(w); } template -inline void __ReadProp(T& obj, athena::io::IStreamReader& r) { +void __ReadProp(T& obj, athena::io::IStreamReader& r) { /* Read root 0xffffffff hash (hashed empty string) */ T::DNAEndian == Endian::Big ? r.readUint32Big() : r.readUint32Little(); atInt64 size = T::DNAEndian == Endian::Big ? r.readUint16Big() : r.readUint16Little(); @@ -877,17 +870,17 @@ inline void __ReadProp(T& obj, athena::io::IStreamReader& r) { } template -inline void __WriteProp(const T& obj, athena::io::IStreamWriter& w) { +void __WriteProp(const T& obj, athena::io::IStreamWriter& w) { __Do, T, T::DNAEndian>({}, const_cast(obj), w); } template -inline void __BinarySizeProp(const T& obj, size_t& s) { +void __BinarySizeProp(const T& obj, size_t& s) { __Do, T, T::DNAEndian>({}, const_cast(obj), s); } template -inline void __ReadProp64(T& obj, athena::io::IStreamReader& r) { +void __ReadProp64(T& obj, athena::io::IStreamReader& r) { /* Read root 0x0 hash (hashed empty string) */ T::DNAEndian == Endian::Big ? r.readUint64Big() : r.readUint64Little(); atInt64 size = T::DNAEndian == Endian::Big ? r.readUint16Big() : r.readUint16Little(); @@ -899,12 +892,12 @@ inline void __ReadProp64(T& obj, athena::io::IStreamReader& r) { } template -inline void __WriteProp64(const T& obj, athena::io::IStreamWriter& w) { +void __WriteProp64(const T& obj, athena::io::IStreamWriter& w) { __Do, T, T::DNAEndian>({}, const_cast(obj), w); } template -inline void __BinarySizeProp64(const T& obj, size_t& s) { +void __BinarySizeProp64(const T& obj, size_t& s) { __Do, T, T::DNAEndian>({}, const_cast(obj), s); } diff --git a/include/athena/DNAYaml.hpp b/include/athena/DNAYaml.hpp index 01d8dc7..0ca0ad4 100644 --- a/include/athena/DNAYaml.hpp +++ b/include/athena/DNAYaml.hpp @@ -9,17 +9,17 @@ namespace athena::io { template -inline const char* __GetDNAName(const T& dna, typename std::enable_if_t>* = 0) { +const char* __GetDNAName(const T& dna, std::enable_if_t>* = nullptr) { return dna.DNATypeV(); } template -inline const char* __GetDNAName(const T& dna, typename std::enable_if_t>* = 0) { +const char* __GetDNAName(const T& dna, std::enable_if_t>* = nullptr) { return dna.DNAType(); } template -inline std::string ToYAMLString(const T& dna) { +std::string ToYAMLString(const T& dna) { YAMLDocWriter docWriter(__GetDNAName(dna)); std::string res; @@ -35,7 +35,7 @@ inline std::string ToYAMLString(const T& dna) { } template -inline bool FromYAMLString(T& dna, std::string_view str) { +bool FromYAMLString(T& dna, std::string_view str) { YAMLStdStringViewReaderState reader(str); YAMLDocReader docReader; yaml_parser_set_input(docReader.getParser(), (yaml_read_handler_t*)YAMLStdStringReader, &reader); @@ -46,7 +46,7 @@ inline bool FromYAMLString(T& dna, std::string_view str) { } template -inline bool ValidateFromYAMLString(std::string_view str) { +bool ValidateFromYAMLString(std::string_view str) { YAMLStdStringViewReaderState reader(str); YAMLDocReader docReader; yaml_parser_set_input(docReader.getParser(), (yaml_read_handler_t*)YAMLStdStringReader, &reader); @@ -55,7 +55,7 @@ inline bool ValidateFromYAMLString(std::string_view str) { } template -inline bool ToYAMLStream(const T& dna, athena::io::IStreamWriter& fout) { +bool ToYAMLStream(const T& dna, athena::io::IStreamWriter& fout) { YAMLDocWriter docWriter(__GetDNAName(dna)); yaml_emitter_set_unicode(docWriter.getEmitter(), true); @@ -66,8 +66,7 @@ inline bool ToYAMLStream(const T& dna, athena::io::IStreamWriter& fout) { } template -inline bool ToYAMLStream(const T& dna, athena::io::IStreamWriter& fout, - void (T::*fn)(YAMLDocWriter& out) const) { +bool ToYAMLStream(const T& dna, athena::io::IStreamWriter& fout, void (T::*fn)(YAMLDocWriter& out) const) { YAMLDocWriter docWriter(__GetDNAName(dna)); yaml_emitter_set_unicode(docWriter.getEmitter(), true); @@ -78,7 +77,7 @@ inline bool ToYAMLStream(const T& dna, athena::io::IStreamWriter& fout, } template -inline bool FromYAMLStream(T& dna, athena::io::IStreamReader& fin) { +bool FromYAMLStream(T& dna, athena::io::IStreamReader& fin) { YAMLDocReader docReader; if (!docReader.parse(&fin)) return false; @@ -87,7 +86,7 @@ inline bool FromYAMLStream(T& dna, athena::io::IStreamReader& fin) { } template -inline bool FromYAMLStream(T& dna, athena::io::IStreamReader& fin, void (T::*fn)(YAMLDocReader& in)) { +bool FromYAMLStream(T& dna, athena::io::IStreamReader& fin, void (T::*fn)(YAMLDocReader& in)) { YAMLDocReader docReader; if (!docReader.parse(&fin)) return false; @@ -96,7 +95,7 @@ inline bool FromYAMLStream(T& dna, athena::io::IStreamReader& fin, void (T::*fn) } template -inline bool MergeToYAMLFile(const T& dna, const NameT& filename) { +bool MergeToYAMLFile(const T& dna, const NameT& filename) { athena::io::FileReader r(filename); YAMLDocWriter docWriter(__GetDNAName(dna), r.isOpen() ? &r : nullptr); r.close(); @@ -109,7 +108,7 @@ inline bool MergeToYAMLFile(const T& dna, const NameT& filename) { } template -inline bool ValidateFromYAMLStream(athena::io::IStreamReader& fin) { +bool ValidateFromYAMLStream(athena::io::IStreamReader& fin) { YAMLDocReader reader; atUint64 pos = fin.position(); yaml_parser_set_input(reader.getParser(), (yaml_read_handler_t*)YAMLAthenaReader, &fin); diff --git a/include/athena/Dir.hpp b/include/athena/Dir.hpp index e18d080..413800c 100644 --- a/include/athena/Dir.hpp +++ b/include/athena/Dir.hpp @@ -14,7 +14,7 @@ public: explicit Dir(std::string_view path); std::string absolutePath() const; - static inline std::string absolutePath(std::string_view path) { return Dir(path).absolutePath(); } + static std::string absolutePath(std::string_view path) { return Dir(path).absolutePath(); } bool isDir() const; static bool isDir(std::string_view dir) { return Dir(dir).isDir(); } diff --git a/include/athena/FileInfo.hpp b/include/athena/FileInfo.hpp index 1b8e01b..58cc753 100644 --- a/include/athena/FileInfo.hpp +++ b/include/athena/FileInfo.hpp @@ -10,33 +10,33 @@ public: explicit FileInfo(std::string_view path = {}); std::string absolutePath() const; - static inline std::string absolutePath(std::string_view lnk) { return FileInfo(lnk).absolutePath(); } + static std::string absolutePath(std::string_view lnk) { return FileInfo(lnk).absolutePath(); } std::string absoluteFilePath() const; - static inline std::string absoluteFilePath(std::string_view path) { return FileInfo(path).absoluteFilePath(); } + static std::string absoluteFilePath(std::string_view path) { return FileInfo(path).absoluteFilePath(); } std::string filename() const; - static inline std::string filename(std::string_view path) { return FileInfo(path).filename(); } + static std::string filename(std::string_view path) { return FileInfo(path).filename(); } std::string path() const { return m_path; } - static inline std::string path(std::string_view path) { return FileInfo(path).path(); } + static std::string path(std::string_view path) { return FileInfo(path).path(); } std::string extension() const; - static inline std::string extension(std::string_view path) { return FileInfo(path).extension(); } + static std::string extension(std::string_view path) { return FileInfo(path).extension(); } atUint64 size() const; - static inline atUint64 size(std::string_view path) { return FileInfo(path).size(); } + static atUint64 size(std::string_view path) { return FileInfo(path).size(); } bool exists() const; - static inline bool exists(std::string_view path) { return FileInfo(path).exists(); } + static bool exists(std::string_view path) { return FileInfo(path).exists(); } bool isLink() const; - static inline bool isLink(std::string_view lnk) { return FileInfo(lnk).isLink(); } + static bool isLink(std::string_view lnk) { return FileInfo(lnk).isLink(); } bool isFile() const; - static inline bool isFile(std::string_view path) { return FileInfo(path).isFile(); } + static bool isFile(std::string_view path) { return FileInfo(path).isFile(); } bool touch() const; - static inline bool touch(std::string_view path) { return FileInfo(path).touch(); } + static bool touch(std::string_view path) { return FileInfo(path).touch(); } private: std::string m_path; diff --git a/include/athena/FileReader.hpp b/include/athena/FileReader.hpp index 16e1f7f..123b3ab 100644 --- a/include/athena/FileReader.hpp +++ b/include/athena/FileReader.hpp @@ -18,9 +18,9 @@ class FileReader : public IStreamReader { public: FileReader(std::string_view filename, atInt32 cacheSize = (32 * 1024), bool globalErr = true); FileReader(std::wstring_view filename, atInt32 cacheSize = (32 * 1024), bool globalErr = true); - virtual ~FileReader(); + ~FileReader() override; - inline std::string filename() const { + std::string filename() const { #if _WIN32 return utility::wideToUtf8(m_filename); #else @@ -28,7 +28,7 @@ public: #endif } - inline std::wstring wfilename() const { + std::wstring wfilename() const { #if _WIN32 return m_filename; #else @@ -38,12 +38,12 @@ public: void open(); void close(); - inline bool isOpen() const { return m_fileHandle != 0; } + bool isOpen() const { return m_fileHandle != 0; } bool save(); - void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current); - atUint64 position() const; - atUint64 length() const; - atUint64 readUBytesToBuf(void* buf, atUint64 len); + void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current) override; + atUint64 position() const override; + atUint64 length() const override; + atUint64 readUBytesToBuf(void* buf, atUint64 len) override; void setCacheSize(const atInt32 blockSize); diff --git a/include/athena/FileWriter.hpp b/include/athena/FileWriter.hpp index 3d8cf38..a095d9b 100644 --- a/include/athena/FileWriter.hpp +++ b/include/athena/FileWriter.hpp @@ -15,16 +15,16 @@ class FileWriter : public IStreamWriter { public: FileWriter(std::string_view filename, bool overwrite = true, bool globalErr = true); FileWriter(std::wstring_view filename, bool overwrite = true, bool globalErr = true); - virtual ~FileWriter(); + ~FileWriter() override; - inline std::string filename() const { + std::string filename() const { #if _WIN32 return utility::wideToUtf8(m_filename); #else return m_filename; #endif } - inline std::wstring wfilename() const { + std::wstring wfilename() const { #if _WIN32 return m_filename; #else @@ -34,11 +34,11 @@ public: void open(bool overwrite = true); void close(); - inline bool isOpen() const { return m_fileHandle != 0; } - void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current); - atUint64 position() const; - atUint64 length() const; - void writeUBytes(const atUint8* data, atUint64 len); + bool isOpen() const { return m_fileHandle != 0; } + void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current) override; + atUint64 position() const override; + atUint64 length() const override; + void writeUBytes(const atUint8* data, atUint64 len) override; #if _WIN32 using HandleType = HANDLE; @@ -99,12 +99,12 @@ public: m_position = 0; } - inline atUint64 position() const { return m_position; } - inline atUint64 length() const { return m_deferredBuffer.size(); } - void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current); - void writeUBytes(const atUint8* data, atUint64 len); + atUint64 position() const override { return m_position; } + atUint64 length() const override { return m_deferredBuffer.size(); } + void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current) override; + void writeUBytes(const atUint8* data, atUint64 len) override; - ~TransactionalFileWriter() { flush(); } + ~TransactionalFileWriter() override { flush(); } }; } // namespace athena::io diff --git a/include/athena/Global.hpp b/include/athena/Global.hpp index 02b5309..f15df4b 100644 --- a/include/athena/Global.hpp +++ b/include/athena/Global.hpp @@ -134,16 +134,15 @@ template struct DNAV; template -using __IsDNARecord = - typename std::disjunction, T>, std::is_base_of, T>>; +using __IsDNARecord = std::disjunction, T>, std::is_base_of, T>>; template -inline constexpr bool __IsDNARecord_v = __IsDNARecord::value; +constexpr bool __IsDNARecord_v = __IsDNARecord::value; template using __IsDNAVRecord = - typename std::disjunction, T>, std::is_base_of, T>>; + std::disjunction, T>, std::is_base_of, T>>; template -inline constexpr bool __IsDNAVRecord_v = __IsDNAVRecord::value; +constexpr bool __IsDNAVRecord_v = __IsDNAVRecord::value; } // namespace io } // namespace athena @@ -163,7 +162,7 @@ std::ostream& operator<<(std::ostream& os, const athena::Endian& endian); template constexpr auto __FIRST_ARG__(First first, Rest...) { return first; } template -inline auto __make_args_checked__(const S& format_str, Args&&... args) { +auto __make_args_checked__(const S& format_str, Args&&... args) { return fmt::internal::make_args_checked(format_str, std::forward(args)...); } diff --git a/include/athena/IStreamReader.hpp b/include/athena/IStreamReader.hpp index 787367b..2826255 100644 --- a/include/athena/IStreamReader.hpp +++ b/include/athena/IStreamReader.hpp @@ -15,14 +15,14 @@ namespace athena::io { */ class IStreamReader : public IStream { public: - virtual ~IStreamReader() = default; + ~IStreamReader() override = default; /** @brief Sets the buffers position relative to the specified position.
* It seeks relative to the current position by default. * @param position where in the buffer to seek * @param origin The Origin to seek relative to */ - virtual void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current) = 0; + void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current) override = 0; /** @brief Sets the buffer's position relative to the next 64-byte aligned position.
*/ @@ -44,19 +44,19 @@ public: * * @return True if at end; False otherwise. */ - bool atEnd() const { return position() >= length(); } + bool atEnd() const override { return position() >= length(); } /** @brief Returns the current position in the stream. * * @return The current position in the stream. */ - virtual atUint64 position() const = 0; + atUint64 position() const override = 0; /** @brief Returns the length of the file. * * @return True length of the file. */ - virtual atUint64 length() const = 0; + atUint64 length() const override = 0; /** @brief Reads a byte at the current position and advances the current position * @@ -68,15 +68,15 @@ public: return val; } template - atInt8 readVal(typename std::enable_if::value>::type* = 0) { + atInt8 readVal(std::enable_if_t>* = nullptr) { return readByte(); } template - atInt8 readValLittle(typename std::enable_if::value>::type* = 0) { + atInt8 readValLittle(std::enable_if_t>* = nullptr) { return readByte(); } template - atInt8 readValBig(typename std::enable_if::value>::type* = 0) { + atInt8 readValBig(std::enable_if_t>* = nullptr) { return readByte(); } @@ -86,15 +86,15 @@ public: */ atUint8 readUByte() { return readByte(); } template - atUint8 readVal(typename std::enable_if::value>::type* = 0) { + atUint8 readVal(std::enable_if_t>* = nullptr) { return readUByte(); } template - atUint8 readValLittle(typename std::enable_if::value>::type* = 0) { + atUint8 readValLittle(std::enable_if_t>* = nullptr) { return readUByte(); } template - atUint8 readValBig(typename std::enable_if::value>::type* = 0) { + atUint8 readValBig(std::enable_if_t>* = nullptr) { return readUByte(); } @@ -146,7 +146,7 @@ public: return m_endian == Big ? utility::BigInt16(val) : utility::LittleInt16(val); } template - atInt16 readVal(typename std::enable_if::value>::type* = 0) { + atInt16 readVal(std::enable_if_t>* = nullptr) { return readInt16(); } @@ -161,7 +161,7 @@ public: return utility::LittleInt16(val); } template - atInt16 readValLittle(typename std::enable_if::value>::type* = 0) { + atInt16 readValLittle(std::enable_if_t>* = nullptr) { return readInt16Little(); } @@ -176,7 +176,7 @@ public: return utility::BigInt16(val); } template - atInt16 readValBig(typename std::enable_if::value>::type* = 0) { + atInt16 readValBig(std::enable_if_t>* = nullptr) { return readInt16Big(); } @@ -187,7 +187,7 @@ public: */ atUint16 readUint16() { return readInt16(); } template - atUint16 readVal(typename std::enable_if::value>::type* = 0) { + atUint16 readVal(std::enable_if_t>* = 0) { return readUint16(); } @@ -202,7 +202,7 @@ public: return utility::LittleUint16(val); } template - atUint16 readValLittle(typename std::enable_if::value>::type* = 0) { + atUint16 readValLittle(std::enable_if_t>* = nullptr) { return readUint16Little(); } @@ -217,7 +217,7 @@ public: return utility::BigUint16(val); } template - atUint16 readValBig(typename std::enable_if::value>::type* = 0) { + atUint16 readValBig(std::enable_if_t>* = nullptr) { return readUint16Big(); } @@ -232,7 +232,7 @@ public: return m_endian == Big ? utility::BigInt32(val) : utility::LittleInt32(val); } template - atInt32 readVal(typename std::enable_if::value>::type* = 0) { + atInt32 readVal(std::enable_if_t>* = nullptr) { return readInt32(); } @@ -247,7 +247,7 @@ public: return utility::LittleInt32(val); } template - atInt32 readValLittle(typename std::enable_if::value>::type* = 0) { + atInt32 readValLittle(std::enable_if_t>* = nullptr) { return readInt32Little(); } @@ -262,7 +262,7 @@ public: return utility::BigInt32(val); } template - atInt32 readValBig(typename std::enable_if::value>::type* = 0) { + atInt32 readValBig(std::enable_if_t>* = nullptr) { return readInt32Big(); } @@ -273,7 +273,7 @@ public: */ atUint32 readUint32() { return readInt32(); } template - atUint32 readVal(typename std::enable_if::value>::type* = 0) { + atUint32 readVal(std::enable_if_t>* = nullptr) { return readUint32(); } @@ -288,7 +288,7 @@ public: return utility::LittleUint32(val); } template - atInt32 readValLittle(typename std::enable_if::value>::type* = 0) { + atInt32 readValLittle(std::enable_if_t>* = nullptr) { return readUint32Little(); } @@ -303,7 +303,7 @@ public: return utility::BigUint32(val); } template - atUint32 readValBig(typename std::enable_if::value>::type* = 0) { + atUint32 readValBig(std::enable_if_t>* = nullptr) { return readUint32Big(); } @@ -318,7 +318,7 @@ public: return m_endian == Big ? utility::BigInt64(val) : utility::LittleInt64(val); } template - atInt64 readVal(typename std::enable_if::value>::type* = 0) { + atInt64 readVal(std::enable_if_t>* = nullptr) { return readInt64(); } @@ -333,7 +333,7 @@ public: return utility::LittleInt64(val); } template - atInt64 readValLittle(typename std::enable_if::value>::type* = 0) { + atInt64 readValLittle(std::enable_if_t>* = nullptr) { return readInt64Little(); } @@ -348,7 +348,7 @@ public: return utility::BigInt64(val); } template - atInt64 readValBig(typename std::enable_if::value>::type* = 0) { + atInt64 readValBig(std::enable_if_t>* = nullptr) { return readInt64Big(); } @@ -359,7 +359,7 @@ public: */ atUint64 readUint64() { return readInt64(); } template - atUint64 readVal(typename std::enable_if::value>::type* = 0) { + atUint64 readVal(std::enable_if_t>* = nullptr) { return readUint64(); } @@ -374,7 +374,7 @@ public: return utility::LittleUint64(val); } template - atUint64 readValLittle(typename std::enable_if::value>::type* = 0) { + atUint64 readValLittle(std::enable_if_t>* = nullptr) { return readUint64Little(); } @@ -389,7 +389,7 @@ public: return utility::BigUint64(val); } template - atUint64 readValBig(typename std::enable_if::value>::type* = 0) { + atUint64 readValBig(std::enable_if_t>* = nullptr) { return readUint64Big(); } @@ -404,7 +404,7 @@ public: return m_endian == Big ? utility::BigFloat(val) : utility::LittleFloat(val); } template - float readVal(typename std::enable_if::value>::type* = 0) { + float readVal(std::enable_if_t>* = nullptr) { return readFloat(); } @@ -419,7 +419,7 @@ public: return utility::LittleFloat(val); } template - float readValLittle(typename std::enable_if::value>::type* = 0) { + float readValLittle(std::enable_if_t>* = nullptr) { return readFloatLittle(); } @@ -434,7 +434,7 @@ public: return utility::BigFloat(val); } template - float readValBig(typename std::enable_if::value>::type* = 0) { + float readValBig(std::enable_if_t>* = nullptr) { return readFloatBig(); } @@ -449,7 +449,7 @@ public: return m_endian == Big ? utility::BigDouble(val) : utility::LittleDouble(val); } template - double readVal(typename std::enable_if::value>::type* = 0) { + double readVal(std::enable_if_t>* = nullptr) { return readDouble(); } @@ -464,7 +464,7 @@ public: return utility::LittleDouble(val); } template - double readValLittle(typename std::enable_if::value>::type* = 0) { + double readValLittle(std::enable_if_t>* = nullptr) { return readDoubleLittle(); } @@ -479,7 +479,7 @@ public: return utility::BigDouble(val); } template - double readValBig(typename std::enable_if::value>::type* = 0) { + double readValBig(std::enable_if_t>* = nullptr) { return readDoubleBig(); } @@ -493,15 +493,15 @@ public: return val != 0; } template - bool readVal(typename std::enable_if::value>::type* = 0) { + bool readVal(std::enable_if_t>* = nullptr) { return readBool(); } template - bool readValLittle(typename std::enable_if::value>::type* = 0) { + bool readValLittle(std::enable_if_t>* = nullptr) { return readBool(); } template - bool readValBig(typename std::enable_if::value>::type* = 0) { + bool readValBig(std::enable_if_t>* = nullptr) { return readBool(); } @@ -527,7 +527,7 @@ public: return s; } template - atVec2f readVal(typename std::enable_if::value>::type* = 0) { + atVec2f readVal(std::enable_if_t>* = nullptr) { return readVec2f(); } @@ -548,7 +548,7 @@ public: return s; } template - atVec2f readValLittle(typename std::enable_if::value>::type* = 0) { + atVec2f readValLittle(std::enable_if_t>* = nullptr) { return readVec2fLittle(); } @@ -569,7 +569,7 @@ public: return s; } template - atVec2f readValBig(typename std::enable_if::value>::type* = 0) { + atVec2f readValBig(std::enable_if_t>* = nullptr) { return readVec2fBig(); } @@ -596,7 +596,7 @@ public: return s; } template - atVec3f readVal(typename std::enable_if::value>::type* = 0) { + atVec3f readVal(std::enable_if_t>* = nullptr) { return readVec3f(); } @@ -617,7 +617,7 @@ public: return s; } template - atVec3f readValLittle(typename std::enable_if::value>::type* = 0) { + atVec3f readValLittle(std::enable_if_t>* = nullptr) { return readVec3fLittle(); } @@ -638,7 +638,7 @@ public: return s; } template - atVec3f readValBig(typename std::enable_if::value>::type* = 0) { + atVec3f readValBig(std::enable_if_t>* = nullptr) { return readVec3fBig(); } @@ -666,7 +666,7 @@ public: return s; } template - atVec4f readVal(typename std::enable_if::value>::type* = 0) { + atVec4f readVal(std::enable_if_t>* = nullptr) { return readVec4f(); } @@ -687,7 +687,7 @@ public: return s; } template - atVec4f readValLittle(typename std::enable_if::value>::type* = 0) { + atVec4f readValLittle(std::enable_if_t>* = nullptr) { return readVec4fLittle(); } @@ -708,7 +708,7 @@ public: return s; } template - atVec4f readValBig(typename std::enable_if::value>::type* = 0) { + atVec4f readValBig(std::enable_if_t>* = nullptr) { return readVec4fBig(); } @@ -734,7 +734,7 @@ public: return s; } template - atVec2d readVal(typename std::enable_if::value>::type* = 0) { + atVec2d readVal(std::enable_if_t>* = nullptr) { return readVec2d(); } @@ -755,7 +755,7 @@ public: return s; } template - atVec2d readValLittle(typename std::enable_if::value>::type* = 0) { + atVec2d readValLittle(std::enable_if_t>* = nullptr) { return readVec2dLittle(); } @@ -776,7 +776,7 @@ public: return s; } template - atVec2d readValBig(typename std::enable_if::value>::type* = 0) { + atVec2d readValBig(std::enable_if_t>* = nullptr) { return readVec2dBig(); } @@ -803,7 +803,7 @@ public: return s; } template - atVec3d readVal(typename std::enable_if::value>::type* = 0) { + atVec3d readVal(std::enable_if_t>* = nullptr) { return readVec3d(); } @@ -824,7 +824,7 @@ public: return s; } template - atVec3d readValLittle(typename std::enable_if::value>::type* = 0) { + atVec3d readValLittle(std::enable_if_t>* = nullptr) { return readVec3dLittle(); } @@ -845,7 +845,7 @@ public: return s; } template - atVec3d readValBig(typename std::enable_if::value>::type* = 0) { + atVec3d readValBig(std::enable_if_t>* = nullptr) { return readVec3dBig(); } @@ -873,7 +873,7 @@ public: return s; } template - atVec4d readVal(typename std::enable_if::value>::type* = 0) { + atVec4d readVal(std::enable_if_t>* = nullptr) { return readVec4d(); } @@ -894,7 +894,7 @@ public: return s; } template - atVec4d readValLittle(typename std::enable_if::value>::type* = 0) { + atVec4d readValLittle(std::enable_if_t>* = nullptr) { return readVec4dLittle(); } @@ -915,7 +915,7 @@ public: return s; } template - atVec4d readValBig(typename std::enable_if::value>::type* = 0) { + atVec4d readValBig(std::enable_if_t>* = nullptr) { return readVec4dBig(); } @@ -946,7 +946,7 @@ public: return ret; } template - std::string readVal(typename std::enable_if::value>::type* = 0) { + std::string readVal(std::enable_if_t>* = nullptr) { return readString(); } @@ -978,7 +978,7 @@ public: return ret; } template - std::wstring readVal(typename std::enable_if::value>::type* = 0) { + std::wstring readVal(std::enable_if_t>* = nullptr) { return readWString(); } @@ -1011,7 +1011,7 @@ public: return ret; } template - std::wstring readValLittle(typename std::enable_if::value>::type* = 0) { + std::wstring readValLittle(std::enable_if_t>* = nullptr) { return readWStringLittle(); } @@ -1043,7 +1043,7 @@ public: return ret; } template - std::wstring readValBig(typename std::enable_if::value>::type* = 0) { + std::wstring readValBig(std::enable_if_t>* = nullptr) { return readWStringBig(); } @@ -1075,7 +1075,7 @@ public: return ret; } template - std::u16string readValBig(typename std::enable_if::value>::type* = 0) { + std::u16string readValBig(std::enable_if_t>* = nullptr) { return readU16StringBig(); } @@ -1107,7 +1107,7 @@ public: return ret; } template - std::u32string readValBig(typename std::enable_if::value>::type* = 0) { + std::u32string readValBig(std::enable_if_t>* = nullptr) { return readU32StringBig(); } @@ -1121,8 +1121,8 @@ public: template void enumerate(std::vector& vector, size_t count, - typename std::enable_if::value || std::is_same::value || - std::is_same::value || std::is_same::value>::type* = 0) { + std::enable_if || std::is_same_v || + std::is_same_v || std::is_same_v>* = nullptr) { vector.clear(); vector.reserve(count); for (size_t i = 0; i < count; ++i) @@ -1137,10 +1137,9 @@ public: * Endianness is little */ template - void enumerateLittle( - std::vector& vector, size_t count, - typename std::enable_if::value || std::is_same::value || - std::is_same::value || std::is_same::value>::type* = 0) { + void enumerateLittle(std::vector& vector, size_t count, + std::enable_if_t || std::is_same_v || + std::is_same_v || std::is_same_v>* = nullptr) { vector.clear(); vector.reserve(count); for (size_t i = 0; i < count; ++i) @@ -1155,10 +1154,9 @@ public: * Endianness is big */ template - void - enumerateBig(std::vector& vector, size_t count, - typename std::enable_if::value || std::is_same::value || - std::is_same::value || std::is_same::value>::type* = 0) { + void enumerateBig(std::vector& vector, size_t count, + std::enable_if_t || std::is_same_v || + std::is_same_v || std::is_same_v>* = nullptr) { vector.clear(); vector.reserve(count); for (size_t i = 0; i < count; ++i) @@ -1171,10 +1169,9 @@ public: * @param count The number of elements to read into vector */ template - void - enumerate(std::vector& vector, size_t count, - typename std::enable_if::value && !std::is_same::value && - !std::is_same::value && !std::is_same::value>::type* = 0) { + void enumerate(std::vector& vector, size_t count, + std::enable_if_t && !std::is_same_v && + !std::is_same_v && !std::is_same_v>* = nullptr) { vector.clear(); vector.reserve(count); for (size_t i = 0; i < count; ++i) { diff --git a/include/athena/IStreamWriter.hpp b/include/athena/IStreamWriter.hpp index e10beaf..f0ea434 100644 --- a/include/athena/IStreamWriter.hpp +++ b/include/athena/IStreamWriter.hpp @@ -9,14 +9,14 @@ namespace athena::io { class IStreamWriter : public IStream { public: - virtual ~IStreamWriter() = default; + ~IStreamWriter() override = default; /** @brief Sets the buffers position relative to the specified position.
* It seeks relative to the current position by default. * @param position where in the buffer to seek * @param origin The location to seek relative to */ - virtual void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current) = 0; + void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current) override = 0; /** @brief Sets the buffers position relative to the next 32-byte aligned position.
*/ @@ -36,19 +36,19 @@ public: * * @return True if at end; False otherwise. */ - bool atEnd() const { return position() >= length(); } + bool atEnd() const override { return position() >= length(); } /** @brief Returns the current position in the stream. * * @return The current position in the stream. */ - virtual atUint64 position() const = 0; + atUint64 position() const override = 0; /** @brief Returns whether or not the stream is at the end. * * @return True if at end; False otherwise. */ - virtual atUint64 length() const = 0; + atUint64 length() const override = 0; /** @brief Writes a byte at the current position and advances the position by one byte. * @param val The value to write @@ -990,10 +990,9 @@ public: * Endianness is set with setEndian */ template - void - enumerate(const std::vector& vector, - typename std::enable_if::value || std::is_same::value || - std::is_same::value || std::is_same::value>::type* = 0) { + void enumerate(const std::vector& vector, + std::enable_if_t || std::is_same_v || std::is_same_v || + std::is_same_v>* = nullptr) { for (const T& item : vector) writeVal(item); } @@ -1004,10 +1003,9 @@ public: * Endianness is little */ template - void enumerateLittle( - const std::vector& vector, - typename std::enable_if::value || std::is_same::value || - std::is_same::value || std::is_same::value>::type* = 0) { + void enumerateLittle(const std::vector& vector, + std::enable_if_t || std::is_same_v || + std::is_same_v || std::is_same_v>* = nullptr) { for (const T& item : vector) writeValLittle(item); } @@ -1018,10 +1016,9 @@ public: * Endianness is big */ template - void - enumerateBig(const std::vector& vector, - typename std::enable_if::value || std::is_same::value || - std::is_same::value || std::is_same::value>::type* = 0) { + void enumerateBig(const std::vector& vector, + std::enable_if_t || std::is_same_v || + std::is_same_v || std::is_same_v>* = nullptr) { for (const T& item : vector) writeValBig(item); } @@ -1030,10 +1027,9 @@ public: * @param vector The std::vector read from when writing data */ template - void - enumerate(const std::vector& vector, - typename std::enable_if::value && !std::is_same::value && - !std::is_same::value && !std::is_same::value>::type* = 0) { + void enumerate(const std::vector& vector, + std::enable_if_t && !std::is_same_v && + !std::is_same_v && !std::is_same_v>* = nullptr) { for (const T& item : vector) item.write(*this); } diff --git a/include/athena/MemoryReader.hpp b/include/athena/MemoryReader.hpp index 1a82c27..6d7064a 100644 --- a/include/athena/MemoryReader.hpp +++ b/include/athena/MemoryReader.hpp @@ -19,7 +19,7 @@ protected: MemoryReader() = default; public: - virtual ~MemoryReader(); + ~MemoryReader() override; /*! \brief This constructor references an existing buffer to read from. * @@ -34,19 +34,19 @@ public: * \param position where in the buffer to seek * \param origin The Origin to seek \sa SeekOrigin */ - void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current); + void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current) override; /*! \brief Returns the current position in the stream. * * \return Int64 The current position in the stream. */ - inline atUint64 position() const { return m_position; } + atUint64 position() const override { return m_position; } /*! \brief Returns whether or not the stream is at the end. * * \return bool True if at end; False otherwise. */ - inline atUint64 length() const { return m_length; } + atUint64 length() const override { return m_length; } /*! \brief Sets the buffer to the given one, deleting the current one.
* BEWARE: As this deletes the current buffer it WILL cause a loss of data @@ -74,7 +74,7 @@ public: * \param len Length to read * \return Number of bytes read */ - atUint64 readUBytesToBuf(void* buf, atUint64 len); + atUint64 readUBytesToBuf(void* buf, atUint64 len) override; protected: const void* m_data = nullptr; diff --git a/include/athena/MemoryWriter.hpp b/include/athena/MemoryWriter.hpp index 28c4d23..b18a9bc 100644 --- a/include/athena/MemoryWriter.hpp +++ b/include/athena/MemoryWriter.hpp @@ -17,7 +17,7 @@ namespace athena::io { */ class MemoryWriter : public IStreamWriter { public: - virtual ~MemoryWriter(); + ~MemoryWriter() override; /*! @brief This constructor references an existing buffer to write to in-place. * @@ -31,21 +31,21 @@ public: * @param position where in the buffer to seek * @param origin The Origin to seek @sa SeekOrigin */ - void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current); + void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current) override; /*! @brief Returns the current position in the stream. * * @return Int64 The current position in the stream. */ - inline atUint64 position() const { return m_position; } + atUint64 position() const override { return m_position; } /*! @brief Returns the length of the stream. * * @return Int64 The length of the stream. */ - inline atUint64 length() const { return m_length; } + atUint64 length() const override { return m_length; } - inline bool isOpen() const { return true; } + bool isOpen() const { return true; } /** @brief Sets the buffer to the given one, deleting the current one if it owns it.
* @param data The new buffer. @@ -65,12 +65,12 @@ public: * * @param filepath The path to write to. */ - inline void setFilepath(const std::string& filepath) { m_filepath = filepath; } + void setFilepath(const std::string& filepath) { m_filepath = filepath; } /*! @brief * Returns the target file */ - inline std::string filepath() const { return m_filepath; } + std::string filepath() const { return m_filepath; } /*! @brief Saves the file to the specified file. * @@ -85,7 +85,7 @@ public: * @param data The buffer to write * @param length The amount to write */ - void writeUBytes(const atUint8* data, atUint64 len); + void writeUBytes(const atUint8* data, atUint64 len) override; protected: MemoryWriter() {} @@ -116,7 +116,7 @@ public: * @param position where in the buffer to seek * @param origin The Origin to seek @sa SeekOrigin */ - void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current); + void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current) override; /*! @brief Sets the buffer to the given one, deleting the current one.
* BEWARE: As this deletes the current buffer it WILL cause a loss of data @@ -135,7 +135,7 @@ public: * @param data The buffer to write * @param length The amount to write */ - void writeUBytes(const atUint8* data, atUint64 len); + void writeUBytes(const atUint8* data, atUint64 len) override; protected: std::unique_ptr m_dataCopy; diff --git a/include/athena/Utility.hpp b/include/athena/Utility.hpp index e2c7c08..1602564 100644 --- a/include/athena/Utility.hpp +++ b/include/athena/Utility.hpp @@ -181,9 +181,9 @@ atUint64 rand64(); std::string join(const std::vector& elems, std::string_view delims); void tolower(std::string& str); void toupper(std::string& str); -bool parseBool(std::string_view boolean, bool* valid = NULL); +bool parseBool(std::string_view boolean, bool* valid = nullptr); -int countChar(std::string_view str, const char chr, int* lastOccur = NULL); +int countChar(std::string_view str, char chr, int* lastOccur = nullptr); // trim from start std::string& ltrim(std::string& s); diff --git a/include/athena/VectorWriter.hpp b/include/athena/VectorWriter.hpp index f17e160..7257812 100644 --- a/include/athena/VectorWriter.hpp +++ b/include/athena/VectorWriter.hpp @@ -22,21 +22,21 @@ public: * @param position where in the buffer to seek * @param origin The Origin to seek @sa SeekOrigin */ - void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current); + void seek(atInt64 pos, SeekOrigin origin = SeekOrigin::Current) override; /*! @brief Returns the current position in the stream. * * @return Int64 The current position in the stream. */ - inline atUint64 position() const { return m_position; } + atUint64 position() const override { return m_position; } /*! @brief Returns the length of the stream. * * @return Int64 The length of the stream. */ - inline atUint64 length() const { return m_data.size(); } + atUint64 length() const override { return m_data.size(); } - inline bool isOpen() const { return true; } + bool isOpen() const { return true; } /*! @brief Obtains reference to underlying std::vector store */ const std::vector& data() const { return m_data; } @@ -48,7 +48,7 @@ public: * @param data The buffer to write * @param length The amount to write */ - void writeUBytes(const atUint8* data, atUint64 len); + void writeUBytes(const atUint8* data, atUint64 len) override; protected: std::vector m_data; diff --git a/include/athena/YAMLCommon.hpp b/include/athena/YAMLCommon.hpp index 7617b14..01e56bd 100644 --- a/include/athena/YAMLCommon.hpp +++ b/include/athena/YAMLCommon.hpp @@ -27,14 +27,14 @@ struct YAMLNode { YAMLNode(yaml_node_type_t type) : m_type(type) {} - inline const YAMLNode* findMapChild(std::string_view key) const { + const YAMLNode* findMapChild(std::string_view key) const { for (const auto& item : m_mapChildren) if (!item.first.compare(key)) return item.second.get(); return nullptr; } - inline void assignMapChild(std::string_view key, std::unique_ptr&& node) { + void assignMapChild(std::string_view key, std::unique_ptr&& node) { for (auto& item : m_mapChildren) if (!item.first.compare(key)) { item.second = std::move(node); diff --git a/include/athena/YAMLDocReader.hpp b/include/athena/YAMLDocReader.hpp index 8fa4c00..45f160c 100644 --- a/include/athena/YAMLDocReader.hpp +++ b/include/athena/YAMLDocReader.hpp @@ -19,15 +19,15 @@ public: void reset(); - inline yaml_parser_t* getParser() { return &m_parser; } + yaml_parser_t* getParser() { return &m_parser; } bool parse(athena::io::IStreamReader* reader); bool ClassTypeOperation(std::function func); bool ValidateClassType(const char* expectedType); - inline const YAMLNode* getRootNode() const { return m_rootNode.get(); } - inline const YAMLNode* getCurNode() const { return m_subStack.empty() ? nullptr : m_subStack.back(); } + const YAMLNode* getRootNode() const { return m_rootNode.get(); } + const YAMLNode* getCurNode() const { return m_subStack.empty() ? nullptr : m_subStack.back(); } std::unique_ptr releaseRootNode() { return std::move(m_rootNode); } class RecordRAII { @@ -54,7 +54,7 @@ public: RecordRAII enterSubRecord(const char* name); template - void enumerate(const char* name, T& record, typename std::enable_if_t<__IsDNARecord_v>* = 0) { + void enumerate(const char* name, T& record, std::enable_if_t<__IsDNARecord_v>* = nullptr) { if (auto rec = enterSubRecord(name)) record.read(*this); } @@ -77,10 +77,9 @@ public: VectorRAII enterSubVector(const char* name, size_t& countOut); template - size_t - enumerate(const char* name, std::vector& vector, - typename std::enable_if_t::value && !std::is_same::value && - !std::is_same::value && !std::is_same::value>* = 0) { + size_t enumerate(const char* name, std::vector& vector, + std::enable_if_t && !std::is_same_v && + !std::is_same_v && !std::is_same_v>* = nullptr) { size_t countOut; if (auto v = enterSubVector(name, countOut)) { vector.clear(); @@ -96,8 +95,8 @@ public: template size_t enumerate(const char* name, std::vector& vector, - typename std::enable_if_t::value || std::is_same::value || - std::is_same::value || std::is_same::value>* = 0) { + std::enable_if_t || std::is_same_v || + std::is_same_v || std::is_same_v>* = nullptr) { size_t countOut; if (auto v = enterSubVector(name, countOut)) { vector.clear(); diff --git a/include/athena/YAMLDocWriter.hpp b/include/athena/YAMLDocWriter.hpp index ae9cbc4..c590674 100644 --- a/include/athena/YAMLDocWriter.hpp +++ b/include/athena/YAMLDocWriter.hpp @@ -20,7 +20,7 @@ public: bool finish(athena::io::IStreamWriter* fout); - inline YAMLNode* getCurNode() const { return m_subStack.empty() ? nullptr : m_subStack.back(); } + YAMLNode* getCurNode() const { return m_subStack.empty() ? nullptr : m_subStack.back(); } class RecordRAII { friend class YAMLDocWriter; @@ -40,7 +40,7 @@ public: RecordRAII enterSubRecord(const char* name); template - void enumerate(const char* name, T& record, typename std::enable_if_t<__IsDNARecord_v>* = 0) { + void enumerate(const char* name, T& record, std::enable_if_t<__IsDNARecord_v>* = nullptr) { if (auto rec = enterSubRecord(name)) record.write(*this); } @@ -63,11 +63,11 @@ public: VectorRAII enterSubVector(const char* name); template - void enumerate(const char* name, const std::vector& vector, - typename std::enable_if_t::value && !std::is_same::value && - !std::is_same::value && !std::is_same::value && - !std::is_same::value && !std::is_same::value && - !std::is_same::value>* = 0) { + void + enumerate(const char* name, const std::vector& vector, + std::enable_if_t && !std::is_same_v && !std::is_same_v && + !std::is_same_v && !std::is_same_v && + !std::is_same_v && !std::is_same_v>* = nullptr) { if (auto v = enterSubVector(name)) for (const T& item : vector) if (auto rec = enterSubRecord(nullptr)) @@ -76,10 +76,9 @@ public: template void enumerate(const char* name, const std::vector& vector, - typename std::enable_if_t::value || std::is_same::value || - std::is_same::value || std::is_same::value || - std::is_same::value || std::is_same::value || - std::is_same::value>* = 0) { + std::enable_if_t || std::is_same_v || std::is_same_v || + std::is_same_v || std::is_same_v || + std::is_same_v || std::is_same_v>* = nullptr) { if (auto v = enterSubVector(name)) for (T item : vector) writeVal(nullptr, item); diff --git a/src/LZ77/LZType11.cpp b/src/LZ77/LZType11.cpp index 41cee43..de26bd8 100644 --- a/src/LZ77/LZType11.cpp +++ b/src/LZ77/LZType11.cpp @@ -106,7 +106,7 @@ atUint32 LZType11::compress(const atUint8* src, atUint8** dst, atUint32 srcLengt } delete[] compressedBytes; - compressedBytes = NULL; + compressedBytes = nullptr; // Add zeros until the file is a multiple of 4 while ((outbuff.position() % 4) != 0) diff --git a/src/athena/Compression.cpp b/src/athena/Compression.cpp index 4f72837..ff23040 100644 --- a/src/athena/Compression.cpp +++ b/src/athena/Compression.cpp @@ -10,7 +10,7 @@ namespace athena::io::Compression { atInt32 decompressZlib(const atUint8* src, atUint32 srcLen, atUint8* dst, atUint32 dstLen) { - z_stream strm = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}; + z_stream strm = {}; strm.total_in = strm.avail_in = srcLen; strm.total_out = strm.avail_out = dstLen; strm.next_in = (Bytef*)src; @@ -45,7 +45,7 @@ atInt32 decompressZlib(const atUint8* src, atUint32 srcLen, atUint8* dst, atUint } atInt32 compressZlib(const atUint8* src, atUint32 srcLen, atUint8* dst, atUint32 dstLen) { - z_stream strm = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}; + z_stream strm = {}; strm.total_in = strm.avail_in = srcLen; strm.total_out = strm.avail_out = dstLen; strm.next_in = (Bytef*)src; diff --git a/src/athena/Dir.cpp b/src/athena/Dir.cpp index 6f6a02c..c9d6d98 100644 --- a/src/athena/Dir.cpp +++ b/src/athena/Dir.cpp @@ -45,7 +45,7 @@ bool Dir::cd(std::string_view path) { bool Dir::rm(std::string_view path) { return !(remove((m_path + "/" + path.data()).c_str()) < 0); } bool Dir::touch() { - srand(time(NULL)); + std::srand(std::time(nullptr)); atUint64 tmp = utility::rand64(); std::string tmpFile = fmt::format(fmt("{:016X}.tmp"), tmp); bool ret = FileInfo(m_path + "/" + tmpFile).touch(); diff --git a/src/athena/FileInfo.cpp b/src/athena/FileInfo.cpp index fb47e01..d78913c 100644 --- a/src/athena/FileInfo.cpp +++ b/src/athena/FileInfo.cpp @@ -104,7 +104,7 @@ bool FileInfo::touch() const { (void)athena::io::FileWriter(m_path); return true; } - if (utimes(m_path.c_str(), NULL) < 0) { + if (utimes(m_path.c_str(), nullptr) < 0) { return false; } #elif defined(_WIN32) @@ -114,7 +114,7 @@ bool FileInfo::touch() const { wchar_t date[80], time[80]; #if !WINDOWS_STORE - fh = CreateFileA(m_path.c_str(), GENERIC_READ | FILE_WRITE_ATTRIBUTES, 0, NULL, CREATE_NEW, 0, NULL); + fh = CreateFileA(m_path.c_str(), GENERIC_READ | FILE_WRITE_ATTRIBUTES, 0, nullptr, CREATE_NEW, 0, nullptr); if (fh == INVALID_HANDLE_VALUE) return false; @@ -122,14 +122,14 @@ bool FileInfo::touch() const { /* * Use GetFileTime() to get the file modification time. */ - if (GetFileTime(fh, NULL, NULL, &modtime) == 0) { + if (GetFileTime(fh, nullptr, nullptr, &modtime) == 0) { CloseHandle(fh); return false; } FileTimeToSystemTime(&modtime, &st); - if (GetDateFormatW(LOCALE_USER_DEFAULT, DATE_LONGDATE, &st, NULL, date, sizeof date / sizeof date[0]) == 0 || - GetTimeFormatW(LOCALE_USER_DEFAULT, 0, &st, NULL, time, sizeof time / sizeof time[0]) == 0) { + if (GetDateFormatW(LOCALE_USER_DEFAULT, DATE_LONGDATE, &st, nullptr, date, sizeof date / sizeof date[0]) == 0 || + GetTimeFormatW(LOCALE_USER_DEFAULT, 0, &st, nullptr, time, sizeof time / sizeof time[0]) == 0) { CloseHandle(fh); return false; } @@ -139,13 +139,13 @@ bool FileInfo::touch() const { * to the current time. */ GetSystemTime(&st); - if (GetDateFormatW(LOCALE_USER_DEFAULT, DATE_LONGDATE, &st, NULL, date, sizeof date / sizeof date[0]) == 0 || - GetTimeFormatW(LOCALE_USER_DEFAULT, 0, &st, NULL, time, sizeof time / sizeof time[0]) == 0) { + if (GetDateFormatW(LOCALE_USER_DEFAULT, DATE_LONGDATE, &st, nullptr, date, sizeof date / sizeof date[0]) == 0 || + GetTimeFormatW(LOCALE_USER_DEFAULT, 0, &st, nullptr, time, sizeof time / sizeof time[0]) == 0) { CloseHandle(fh); return false; } SystemTimeToFileTime(&st, &modtime); - if (SetFileTime(fh, NULL, NULL, &modtime) == 0) { + if (SetFileTime(fh, nullptr, nullptr, &modtime) == 0) { CloseHandle(fh); return false; } diff --git a/src/athena/Socket.cpp b/src/athena/Socket.cpp index 8f2f7c4..129972a 100644 --- a/src/athena/Socket.cpp +++ b/src/athena/Socket.cpp @@ -45,8 +45,8 @@ void IPAddress::resolve(const std::string& address) { addrinfo hints; memset(&hints, 0, sizeof(hints)); hints.ai_family = AF_INET; - addrinfo* result = NULL; - if (getaddrinfo(address.c_str(), NULL, &hints, &result) == 0) { + addrinfo* result = nullptr; + if (getaddrinfo(address.c_str(), nullptr, &hints, &result) == 0) { if (result) { addr = reinterpret_cast(result->ai_addr)->sin_addr; freeaddrinfo(result); diff --git a/src/athena/Utility.cpp b/src/athena/Utility.cpp index da36334..c0665fc 100644 --- a/src/athena/Utility.cpp +++ b/src/athena/Utility.cpp @@ -100,7 +100,7 @@ int countChar(std::string_view str, const char chr, int* lastOccur) { for (char c : str) { if (c == chr) { - if (lastOccur != NULL) + if (lastOccur != nullptr) *lastOccur = index; ret++;