decompals
/
wibo
mirror of https://github.com/decompals/wibo.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix ineffective "x < 0" comparisons in CompareString 

Pointed out by cppcheck.
This commit is contained in:
Simon Lindholm 2023-10-16 20:05:04 +02:00
parent b1dd93d7b7
commit 4bf81a9ec9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dll/kernel32.cpp
View File

@ -1771,7 +1771,7 @@ namespace kernel32 {
return TRUE; return TRUE;
} }
int WIN_FUNC CompareStringA(int Locale, unsigned int dwCmpFlags, const char *lpString1, unsigned int cchCount1, const char *lpString2, unsigned int cchCount2) { int WIN_FUNC CompareStringA(int Locale, unsigned int dwCmpFlags, const char *lpString1, int cchCount1, const char *lpString2, int cchCount2) {
if (cchCount1 < 0) if (cchCount1 < 0)
cchCount1 = strlen(lpString1); cchCount1 = strlen(lpString1);
if (cchCount2 < 0) if (cchCount2 < 0)
@ -1783,7 +1783,7 @@ namespace kernel32 {
return doCompareString(str1, str2, dwCmpFlags); return doCompareString(str1, str2, dwCmpFlags);
} }
int WIN_FUNC CompareStringW(int Locale, unsigned int dwCmpFlags, const uint16_t *lpString1, unsigned int cchCount1, const uint16_t *lpString2, unsigned int cchCount2) { int WIN_FUNC CompareStringW(int Locale, unsigned int dwCmpFlags, const uint16_t *lpString1, int cchCount1, const uint16_t *lpString2, int cchCount2) {
std::string str1 = wideStringToString(lpString1, cchCount1); std::string str1 = wideStringToString(lpString1, cchCount1);
std::string str2 = wideStringToString(lpString2, cchCount2); std::string str2 = wideStringToString(lpString2, cchCount2);