encounter
/
SDL
mirror of https://github.com/encounter/SDL.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed bug 3535 - Misplaced comment #if/#endif closure comment 

Coriiander

This notice is about a misplaced comment.

Often times when we use an #if #endif sequence, the #endif is followed by a comment to indicate what #if statement it belonged to. The SDL_xaudio2.c file contains a misplaced comment, as follows (I stripped the other comments):

#ifdef __GNUC__
#  define SDL_XAUDIO2_HAS_SDK 1
#elif defined(__WINRT__)
#  define SDL_XAUDIO2_HAS_SDK
#include "SDL_xaudio2.h"
#else
#if 0
#include <dxsdkver.h>
#if (!defined(_DXSDK_BUILD_MAJOR) || (_DXSDK_BUILD_MAJOR < 1284))
#  pragma message("Your DirectX SDK is too old. Disabling XAudio2 support.")
#else
#  define SDL_XAUDIO2_HAS_SDK 1
#endif
#endif
#endif /* 0 */



That final /* 0 */ should be moved one line up. Like this (I tabbed it out for you to make it more clear):
This commit is contained in:
Sam Lantinga 2016-12-31 16:21:55 -08:00
parent 880842cfdf
commit 2ba66d0525
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/audio/xaudio2/SDL_xaudio2.c
View File

@ -78,8 +78,8 @@
#else #else
# define SDL_XAUDIO2_HAS_SDK 1 # define SDL_XAUDIO2_HAS_SDK 1
#endif #endif
#endif
#endif /* 0 */ #endif /* 0 */
#endif /* __GNUC__ */
#ifdef SDL_XAUDIO2_HAS_SDK #ifdef SDL_XAUDIO2_HAS_SDK